linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] fixes for 3.12
@ 2013-09-08  0:21 Antti Palosaari
  2013-09-08  0:21 ` [PATCH 1/3] e4000: fix PLL calc bug on 32-bit arch Antti Palosaari
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Antti Palosaari @ 2013-09-08  0:21 UTC (permalink / raw)
  To: linux-media; +Cc: Antti Palosaari

PULL-request will follow soon.

I will send e4000 fix to stable too after a week or two.

Antti Palosaari (2):
  e4000: fix PLL calc bug on 32-bit arch
  msi3101: Kconfig select VIDEOBUF2_VMALLOC

Fengguang Wu (1):
  msi3101: msi3101_ioctl_ops can be static

 drivers/media/tuners/e4000.c                | 2 +-
 drivers/staging/media/msi3101/Kconfig       | 1 +
 drivers/staging/media/msi3101/sdr-msi3101.c | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

-- 
1.7.11.7


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/3] e4000: fix PLL calc bug on 32-bit arch
  2013-09-08  0:21 [PATCH 0/3] fixes for 3.12 Antti Palosaari
@ 2013-09-08  0:21 ` Antti Palosaari
  2013-09-08  0:21 ` [PATCH 2/3] msi3101: msi3101_ioctl_ops can be static Antti Palosaari
  2013-09-08  0:21 ` [PATCH 3/3] msi3101: Kconfig select VIDEOBUF2_VMALLOC Antti Palosaari
  2 siblings, 0 replies; 4+ messages in thread
From: Antti Palosaari @ 2013-09-08  0:21 UTC (permalink / raw)
  To: linux-media; +Cc: Antti Palosaari

Fix long-lasting bug that causes tuning failure of some frequencies
on 32-bit arch.

Special thanks goes to Damien CABROL who finally find root of the bug.
Also big thanks to Jacek Konieczny for donating "non-working" device.

[crope@iki.fi: fix trivial merge conflict]
Reported-by: Jacek Konieczny <jajcus@jajcus.net>
Reported-by: Torsten Seyffarth <t.seyffarth@gmx.de>
Reported-by: Jan Taegert <jantaegert@gmx.net>
Reported-by: Damien CABROL <cabrol.damien@free.fr>
Tested-by: Damien CABROL <cabrol.damien@free.fr>
Tested-by: Jan Taegert <jantaegert@gmx.net>
Signed-off-by: Antti Palosaari <crope@iki.fi>
---
 drivers/media/tuners/e4000.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/tuners/e4000.c b/drivers/media/tuners/e4000.c
index ad9309d..54e2d8a 100644
--- a/drivers/media/tuners/e4000.c
+++ b/drivers/media/tuners/e4000.c
@@ -233,7 +233,7 @@ static int e4000_set_params(struct dvb_frontend *fe)
 	 * or more.
 	 */
 	f_vco = c->frequency * e4000_pll_lut[i].mul;
-	sigma_delta = 0x10000UL * (f_vco % priv->cfg->clock) / priv->cfg->clock;
+	sigma_delta = div_u64(0x10000ULL * (f_vco % priv->cfg->clock), priv->cfg->clock);
 	buf[0] = f_vco / priv->cfg->clock;
 	buf[1] = (sigma_delta >> 0) & 0xff;
 	buf[2] = (sigma_delta >> 8) & 0xff;
-- 
1.7.11.7


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/3] msi3101: msi3101_ioctl_ops can be static
  2013-09-08  0:21 [PATCH 0/3] fixes for 3.12 Antti Palosaari
  2013-09-08  0:21 ` [PATCH 1/3] e4000: fix PLL calc bug on 32-bit arch Antti Palosaari
@ 2013-09-08  0:21 ` Antti Palosaari
  2013-09-08  0:21 ` [PATCH 3/3] msi3101: Kconfig select VIDEOBUF2_VMALLOC Antti Palosaari
  2 siblings, 0 replies; 4+ messages in thread
From: Antti Palosaari @ 2013-09-08  0:21 UTC (permalink / raw)
  To: linux-media; +Cc: Fengguang Wu, Antti Palosaari

From: Fengguang Wu <fengguang.wu@intel.com>

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Antti Palosaari <crope@iki.fi>
---
 drivers/staging/media/msi3101/sdr-msi3101.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/msi3101/sdr-msi3101.c b/drivers/staging/media/msi3101/sdr-msi3101.c
index 24c7b70..7715c85 100644
--- a/drivers/staging/media/msi3101/sdr-msi3101.c
+++ b/drivers/staging/media/msi3101/sdr-msi3101.c
@@ -1657,7 +1657,7 @@ static int vidioc_s_frequency(struct file *file, void *priv,
 			f->frequency * 625UL / 10UL);
 }
 
-const struct v4l2_ioctl_ops msi3101_ioctl_ops = {
+static const struct v4l2_ioctl_ops msi3101_ioctl_ops = {
 	.vidioc_querycap          = msi3101_querycap,
 
 	.vidioc_enum_input        = msi3101_enum_input,
-- 
1.7.11.7


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 3/3] msi3101: Kconfig select VIDEOBUF2_VMALLOC
  2013-09-08  0:21 [PATCH 0/3] fixes for 3.12 Antti Palosaari
  2013-09-08  0:21 ` [PATCH 1/3] e4000: fix PLL calc bug on 32-bit arch Antti Palosaari
  2013-09-08  0:21 ` [PATCH 2/3] msi3101: msi3101_ioctl_ops can be static Antti Palosaari
@ 2013-09-08  0:21 ` Antti Palosaari
  2 siblings, 0 replies; 4+ messages in thread
From: Antti Palosaari @ 2013-09-08  0:21 UTC (permalink / raw)
  To: linux-media; +Cc: Antti Palosaari, kbuild-all

[linuxtv-media:master 395/499] sdr-msi3101.c:undefined reference to
`vb2_vmalloc_memops'

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Cc: kbuild-all@01.org
Signed-off-by: Antti Palosaari <crope@iki.fi>
---
 drivers/staging/media/msi3101/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/media/msi3101/Kconfig b/drivers/staging/media/msi3101/Kconfig
index b94a95a..76d5bbd 100644
--- a/drivers/staging/media/msi3101/Kconfig
+++ b/drivers/staging/media/msi3101/Kconfig
@@ -1,3 +1,4 @@
 config USB_MSI3101
 	tristate "Mirics MSi3101 SDR Dongle"
 	depends on USB && VIDEO_DEV && VIDEO_V4L2
+        select VIDEOBUF2_VMALLOC
-- 
1.7.11.7


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-09-08  0:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-08  0:21 [PATCH 0/3] fixes for 3.12 Antti Palosaari
2013-09-08  0:21 ` [PATCH 1/3] e4000: fix PLL calc bug on 32-bit arch Antti Palosaari
2013-09-08  0:21 ` [PATCH 2/3] msi3101: msi3101_ioctl_ops can be static Antti Palosaari
2013-09-08  0:21 ` [PATCH 3/3] msi3101: Kconfig select VIDEOBUF2_VMALLOC Antti Palosaari

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).