linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/6] Remove redundant spi driver bus initialization
@ 2015-06-23 14:45 Antonio Borneo
  2015-06-23 14:53 ` [PATCH 6/6] [media] s5c73m3: " Antonio Borneo
  0 siblings, 1 reply; 3+ messages in thread
From: Antonio Borneo @ 2015-06-23 14:45 UTC (permalink / raw)
  To: Alan Ott, Alexander Aring, alsa-devel, Andrzej Hajda, devel,
	Greg Kroah-Hartman, Jaroslav Kysela, Jonathan Cameron,
	Kalle Valo, Karol Wrona, Kyungmin Park, Lars-Peter Clausen,
	Liam Girdwood, linux-iio, linux-media, linux-wireless,
	linux-wpan, Mark Brown, Mauro Carvalho Chehab, netdev, patches,
	Solomon Peachy, Takashi Iwai, Varka Bhadram
  Cc: Antonio Borneo, linux-kernel

This cleanup was already completed between end 2011 and early 2012
with a patch series from Lars-Peter Clausen:
https://lkml.org/lkml/2011/11/24/190

Later on new redundant initialization re-appeared here and there.
Time to cleanup again.

And, yes, I'm lazy! I copy-paste the exact same commit message from
Lars-Peter; only minor reformat to stay in 75 char/line and fix the
name of spi_register_driver().

Regards,
Antonio

Antonio Borneo (6):
  ASoC: wm0010: Remove redundant spi driver bus initialization
  iio: ssp_sensors: Remove redundant spi driver bus initialization
  staging: mt29f_spinand: Remove redundant spi driver bus initialization
  net: ieee802154: Remove redundant spi driver bus initialization
  wireless: cw1200: Remove redundant spi driver bus initialization
  [media] s5c73m3: Remove redundant spi driver bus initialization

 drivers/iio/common/ssp_sensors/ssp_dev.c      | 1 -
 drivers/media/i2c/s5c73m3/s5c73m3-spi.c       | 1 -
 drivers/net/ieee802154/cc2520.c               | 1 -
 drivers/net/ieee802154/mrf24j40.c             | 1 -
 drivers/net/wireless/cw1200/cw1200_spi.c      | 1 -
 drivers/staging/mt29f_spinand/mt29f_spinand.c | 1 -
 sound/soc/codecs/wm0010.c                     | 1 -
 7 files changed, 7 deletions(-)

-- 
2.4.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 6/6] [media] s5c73m3: Remove redundant spi driver bus initialization
  2015-06-23 14:45 [PATCH 0/6] Remove redundant spi driver bus initialization Antonio Borneo
@ 2015-06-23 14:53 ` Antonio Borneo
  2015-06-24  5:53   ` Andrzej Hajda
  0 siblings, 1 reply; 3+ messages in thread
From: Antonio Borneo @ 2015-06-23 14:53 UTC (permalink / raw)
  To: Mauro Carvalho Chehab, Kyungmin Park, Andrzej Hajda, linux-media
  Cc: Antonio Borneo, linux-kernel

In ancient times it was necessary to manually initialize the bus
field of an spi_driver to spi_bus_type. These days this is done in
spi_register_driver(), so we can drop the manual assignment.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Kyungmin Park <kyungmin.park@samsung.com>
To: Andrzej Hajda <a.hajda@samsung.com>
To: linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 drivers/media/i2c/s5c73m3/s5c73m3-spi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c
index 63eb190..fa4a5eb 100644
--- a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c
+++ b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c
@@ -149,7 +149,6 @@ int s5c73m3_register_spi_driver(struct s5c73m3 *state)
 	spidrv->remove = s5c73m3_spi_remove;
 	spidrv->probe = s5c73m3_spi_probe;
 	spidrv->driver.name = S5C73M3_SPI_DRV_NAME;
-	spidrv->driver.bus = &spi_bus_type;
 	spidrv->driver.owner = THIS_MODULE;
 	spidrv->driver.of_match_table = s5c73m3_spi_ids;
 
-- 
2.4.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 6/6] [media] s5c73m3: Remove redundant spi driver bus initialization
  2015-06-23 14:53 ` [PATCH 6/6] [media] s5c73m3: " Antonio Borneo
@ 2015-06-24  5:53   ` Andrzej Hajda
  0 siblings, 0 replies; 3+ messages in thread
From: Andrzej Hajda @ 2015-06-24  5:53 UTC (permalink / raw)
  To: Antonio Borneo, Mauro Carvalho Chehab, Kyungmin Park, linux-media
  Cc: linux-kernel

On 06/23/2015 04:53 PM, Antonio Borneo wrote:
> In ancient times it was necessary to manually initialize the bus
> field of an spi_driver to spi_bus_type. These days this is done in
> spi_register_driver(), so we can drop the manual assignment.
>
> Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
> To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> To: Kyungmin Park <kyungmin.park@samsung.com>
> To: Andrzej Hajda <a.hajda@samsung.com>
> To: linux-media@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org

Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

Regards
Andrzej
> ---
>  drivers/media/i2c/s5c73m3/s5c73m3-spi.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c
> index 63eb190..fa4a5eb 100644
> --- a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c
> +++ b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c
> @@ -149,7 +149,6 @@ int s5c73m3_register_spi_driver(struct s5c73m3 *state)
>  	spidrv->remove = s5c73m3_spi_remove;
>  	spidrv->probe = s5c73m3_spi_probe;
>  	spidrv->driver.name = S5C73M3_SPI_DRV_NAME;
> -	spidrv->driver.bus = &spi_bus_type;
>  	spidrv->driver.owner = THIS_MODULE;
>  	spidrv->driver.of_match_table = s5c73m3_spi_ids;
>  


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-06-24  5:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-23 14:45 [PATCH 0/6] Remove redundant spi driver bus initialization Antonio Borneo
2015-06-23 14:53 ` [PATCH 6/6] [media] s5c73m3: " Antonio Borneo
2015-06-24  5:53   ` Andrzej Hajda

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).