* [PATCH v1 1/1] tea575x: convert to library
@ 2015-12-18 20:32 Andy Shevchenko
2016-01-28 12:36 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2015-12-18 20:32 UTC (permalink / raw)
To: Ondrej Zary, Hans Verkuil, linux-media; +Cc: Andy Shevchenko
The module is used only as a library for now. Remove module init and exit
routines to show this.
While here, remove FSF snail address and attach EXPORT_SYMBOL() macros to
corresponding functions.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/media/radio/tea575x.c | 21 ++-------------------
1 file changed, 2 insertions(+), 19 deletions(-)
diff --git a/drivers/media/radio/tea575x.c b/drivers/media/radio/tea575x.c
index 43d1ea5..21cd5de 100644
--- a/drivers/media/radio/tea575x.c
+++ b/drivers/media/radio/tea575x.c
@@ -14,10 +14,6 @@
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
- *
*/
#include <linux/delay.h>
@@ -226,6 +222,7 @@ void snd_tea575x_set_freq(struct snd_tea575x *tea)
snd_tea575x_write(tea, tea->val);
tea->freq = snd_tea575x_val_to_freq(tea, tea->val);
}
+EXPORT_SYMBOL(snd_tea575x_set_freq);
/*
* Linux Video interface
@@ -582,25 +579,11 @@ int snd_tea575x_init(struct snd_tea575x *tea, struct module *owner)
return 0;
}
+EXPORT_SYMBOL(snd_tea575x_init);
void snd_tea575x_exit(struct snd_tea575x *tea)
{
video_unregister_device(&tea->vd);
v4l2_ctrl_handler_free(tea->vd.ctrl_handler);
}
-
-static int __init alsa_tea575x_module_init(void)
-{
- return 0;
-}
-
-static void __exit alsa_tea575x_module_exit(void)
-{
-}
-
-module_init(alsa_tea575x_module_init)
-module_exit(alsa_tea575x_module_exit)
-
-EXPORT_SYMBOL(snd_tea575x_init);
EXPORT_SYMBOL(snd_tea575x_exit);
-EXPORT_SYMBOL(snd_tea575x_set_freq);
--
2.6.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] tea575x: convert to library
2015-12-18 20:32 [PATCH v1 1/1] tea575x: convert to library Andy Shevchenko
@ 2016-01-28 12:36 ` Andy Shevchenko
2016-01-28 13:06 ` Hans Verkuil
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2016-01-28 12:36 UTC (permalink / raw)
To: Ondrej Zary, Hans Verkuil, linux-media
On Fri, 2015-12-18 at 22:32 +0200, Andy Shevchenko wrote:
> The module is used only as a library for now. Remove module init and
> exit
> routines to show this.
>
> While here, remove FSF snail address and attach EXPORT_SYMBOL()
> macros to
> corresponding functions.
Any comment on this?
The patch has been compiled and tested with SF64-PCR radio tuner (fm801
based).
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/media/radio/tea575x.c | 21 ++-------------------
> 1 file changed, 2 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/media/radio/tea575x.c
> b/drivers/media/radio/tea575x.c
> index 43d1ea5..21cd5de 100644
> --- a/drivers/media/radio/tea575x.c
> +++ b/drivers/media/radio/tea575x.c
> @@ -14,10 +14,6 @@
> * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> * GNU General Public License for more details.
> *
> - * You should have received a copy of the GNU General Public
> License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> MA 02111-1307 USA
> - *
> */
>
> #include <linux/delay.h>
> @@ -226,6 +222,7 @@ void snd_tea575x_set_freq(struct snd_tea575x
> *tea)
> snd_tea575x_write(tea, tea->val);
> tea->freq = snd_tea575x_val_to_freq(tea, tea->val);
> }
> +EXPORT_SYMBOL(snd_tea575x_set_freq);
>
> /*
> * Linux Video interface
> @@ -582,25 +579,11 @@ int snd_tea575x_init(struct snd_tea575x *tea,
> struct module *owner)
>
> return 0;
> }
> +EXPORT_SYMBOL(snd_tea575x_init);
>
> void snd_tea575x_exit(struct snd_tea575x *tea)
> {
> video_unregister_device(&tea->vd);
> v4l2_ctrl_handler_free(tea->vd.ctrl_handler);
> }
> -
> -static int __init alsa_tea575x_module_init(void)
> -{
> - return 0;
> -}
> -
> -static void __exit alsa_tea575x_module_exit(void)
> -{
> -}
> -
> -module_init(alsa_tea575x_module_init)
> -module_exit(alsa_tea575x_module_exit)
> -
> -EXPORT_SYMBOL(snd_tea575x_init);
> EXPORT_SYMBOL(snd_tea575x_exit);
> -EXPORT_SYMBOL(snd_tea575x_set_freq);
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] tea575x: convert to library
2016-01-28 12:36 ` Andy Shevchenko
@ 2016-01-28 13:06 ` Hans Verkuil
0 siblings, 0 replies; 3+ messages in thread
From: Hans Verkuil @ 2016-01-28 13:06 UTC (permalink / raw)
To: Andy Shevchenko, Ondrej Zary, Hans Verkuil, linux-media
On 01/28/2016 01:36 PM, Andy Shevchenko wrote:
> On Fri, 2015-12-18 at 22:32 +0200, Andy Shevchenko wrote:
>> The module is used only as a library for now. Remove module init and
>> exit
>> routines to show this.
>>
>> While here, remove FSF snail address and attach EXPORT_SYMBOL()
>> macros to
>> corresponding functions.
>
> Any comment on this?
Not yet. It's in my todo pile so I will get to it. It's low prio, so
this might take some time.
Regards,
Hans
>
> The patch has been compiled and tested with SF64-PCR radio tuner (fm801
> based).
>
>>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>> drivers/media/radio/tea575x.c | 21 ++-------------------
>> 1 file changed, 2 insertions(+), 19 deletions(-)
>>
>> diff --git a/drivers/media/radio/tea575x.c
>> b/drivers/media/radio/tea575x.c
>> index 43d1ea5..21cd5de 100644
>> --- a/drivers/media/radio/tea575x.c
>> +++ b/drivers/media/radio/tea575x.c
>> @@ -14,10 +14,6 @@
>> * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> * GNU General Public License for more details.
>> *
>> - * You should have received a copy of the GNU General Public
>> License
>> - * along with this program; if not, write to the Free Software
>> - * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
>> MA 02111-1307 USA
>> - *
>> */
>>
>> #include <linux/delay.h>
>> @@ -226,6 +222,7 @@ void snd_tea575x_set_freq(struct snd_tea575x
>> *tea)
>> snd_tea575x_write(tea, tea->val);
>> tea->freq = snd_tea575x_val_to_freq(tea, tea->val);
>> }
>> +EXPORT_SYMBOL(snd_tea575x_set_freq);
>>
>> /*
>> * Linux Video interface
>> @@ -582,25 +579,11 @@ int snd_tea575x_init(struct snd_tea575x *tea,
>> struct module *owner)
>>
>> return 0;
>> }
>> +EXPORT_SYMBOL(snd_tea575x_init);
>>
>> void snd_tea575x_exit(struct snd_tea575x *tea)
>> {
>> video_unregister_device(&tea->vd);
>> v4l2_ctrl_handler_free(tea->vd.ctrl_handler);
>> }
>> -
>> -static int __init alsa_tea575x_module_init(void)
>> -{
>> - return 0;
>> -}
>> -
>> -static void __exit alsa_tea575x_module_exit(void)
>> -{
>> -}
>> -
>> -module_init(alsa_tea575x_module_init)
>> -module_exit(alsa_tea575x_module_exit)
>> -
>> -EXPORT_SYMBOL(snd_tea575x_init);
>> EXPORT_SYMBOL(snd_tea575x_exit);
>> -EXPORT_SYMBOL(snd_tea575x_set_freq);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-28 13:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-18 20:32 [PATCH v1 1/1] tea575x: convert to library Andy Shevchenko
2016-01-28 12:36 ` Andy Shevchenko
2016-01-28 13:06 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).