* [PATCH] arm64: dts: sdm845: add video nodes
@ 2018-11-20 10:08 Malathi Gottam
2018-11-21 6:35 ` Sibi Sankar
2018-11-27 7:31 ` Alexandre Courbot
0 siblings, 2 replies; 5+ messages in thread
From: Malathi Gottam @ 2018-11-20 10:08 UTC (permalink / raw)
To: stanimir.varbanov, hverkuil, mchehab
Cc: linux-media, linux-kernel, linux-arm-msm, acourbot, vgarodia, mgottam
This adds video nodes to sdm845 based on the examples
in the bindings.
Signed-off-by: Malathi Gottam <mgottam@codeaurora.org>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 0c9a2aa..d82487d 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -84,6 +84,10 @@
reg = <0 0x86200000 0 0x2d00000>;
no-map;
};
+ venus_region: venus@95800000 {
+ reg = <0x0 0x95800000 0x0 0x500000>;
+ no-map;
+ };
};
cpus {
@@ -1103,5 +1107,35 @@
status = "disabled";
};
};
+
+ video-codec@aa00000 {
+ compatible = "qcom,sdm845-venus";
+ reg = <0x0aa00000 0xff000>;
+ interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
+ power-domains = <&videocc VENUS_GDSC>;
+ clocks = <&videocc VIDEO_CC_VENUS_CTL_CORE_CLK>,
+ <&videocc VIDEO_CC_VENUS_AHB_CLK>,
+ <&videocc VIDEO_CC_VENUS_CTL_AXI_CLK>;
+ clock-names = "core", "iface", "bus";
+ iommus = <&apps_smmu 0x10a0 0x8>,
+ <&apps_smmu 0x10b0 0x0>;
+ memory-region = <&venus_region>;
+
+ video-core0 {
+ compatible = "venus-decoder";
+ clocks = <&videocc VIDEO_CC_VCODEC0_CORE_CLK>,
+ <&videocc VIDEO_CC_VCODEC0_AXI_CLK>;
+ clock-names = "core", "bus";
+ power-domains = <&videocc VCODEC0_GDSC>;
+ };
+
+ video-core1 {
+ compatible = "venus-encoder";
+ clocks = <&videocc VIDEO_CC_VCODEC1_CORE_CLK>,
+ <&videocc VIDEO_CC_VCODEC1_AXI_CLK>;
+ clock-names = "core", "bus";
+ power-domains = <&videocc VCODEC1_GDSC>;
+ };
+ };
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: sdm845: add video nodes
2018-11-20 10:08 [PATCH] arm64: dts: sdm845: add video nodes Malathi Gottam
@ 2018-11-21 6:35 ` Sibi Sankar
2018-11-27 7:31 ` Alexandre Courbot
1 sibling, 0 replies; 5+ messages in thread
From: Sibi Sankar @ 2018-11-21 6:35 UTC (permalink / raw)
To: Malathi Gottam
Cc: stanimir.varbanov, hverkuil, mchehab, linux-media, linux-kernel,
linux-arm-msm, acourbot, vgarodia, linux-arm-msm-owner
Hi Malathi,
On 2018-11-20 15:38, Malathi Gottam wrote:
> This adds video nodes to sdm845 based on the examples
> in the bindings.
>
> Signed-off-by: Malathi Gottam <mgottam@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 34
> ++++++++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 0c9a2aa..d82487d 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -84,6 +84,10 @@
> reg = <0 0x86200000 0 0x2d00000>;
> no-map;
> };
> + venus_region: venus@95800000 {
> + reg = <0x0 0x95800000 0x0 0x500000>;
> + no-map;
> + };
nit: Please make this venus_region: memory@95800000
instead and add a new line before venus_region.
> };
>
> cpus {
> @@ -1103,5 +1107,35 @@
> status = "disabled";
> };
> };
> +
> + video-codec@aa00000 {
> + compatible = "qcom,sdm845-venus";
> + reg = <0x0aa00000 0xff000>;
> + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
> + power-domains = <&videocc VENUS_GDSC>;
> + clocks = <&videocc VIDEO_CC_VENUS_CTL_CORE_CLK>,
> + <&videocc VIDEO_CC_VENUS_AHB_CLK>,
> + <&videocc VIDEO_CC_VENUS_CTL_AXI_CLK>;
> + clock-names = "core", "iface", "bus";
> + iommus = <&apps_smmu 0x10a0 0x8>,
> + <&apps_smmu 0x10b0 0x0>;
> + memory-region = <&venus_region>;
> +
> + video-core0 {
> + compatible = "venus-decoder";
> + clocks = <&videocc VIDEO_CC_VCODEC0_CORE_CLK>,
> + <&videocc VIDEO_CC_VCODEC0_AXI_CLK>;
> + clock-names = "core", "bus";
> + power-domains = <&videocc VCODEC0_GDSC>;
> + };
> +
> + video-core1 {
> + compatible = "venus-encoder";
> + clocks = <&videocc VIDEO_CC_VCODEC1_CORE_CLK>,
> + <&videocc VIDEO_CC_VCODEC1_AXI_CLK>;
> + clock-names = "core", "bus";
> + power-domains = <&videocc VCODEC1_GDSC>;
> + };
> + };
> };
> };
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: sdm845: add video nodes
2018-11-20 10:08 [PATCH] arm64: dts: sdm845: add video nodes Malathi Gottam
2018-11-21 6:35 ` Sibi Sankar
@ 2018-11-27 7:31 ` Alexandre Courbot
2018-11-27 8:24 ` Stanimir Varbanov
1 sibling, 1 reply; 5+ messages in thread
From: Alexandre Courbot @ 2018-11-27 7:31 UTC (permalink / raw)
To: mgottam
Cc: Stanimir Varbanov, Hans Verkuil, Mauro Carvalho Chehab,
Linux Media Mailing List, LKML, linux-arm-msm, vgarodia
On Tue, Nov 20, 2018 at 7:08 PM Malathi Gottam <mgottam@codeaurora.org> wrote:
>
> This adds video nodes to sdm845 based on the examples
> in the bindings.
>
> Signed-off-by: Malathi Gottam <mgottam@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 34 ++++++++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 0c9a2aa..d82487d 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -84,6 +84,10 @@
> reg = <0 0x86200000 0 0x2d00000>;
> no-map;
> };
> + venus_region: venus@95800000 {
> + reg = <0x0 0x95800000 0x0 0x500000>;
Note that the driver expects a size of 0x600000 here and will fail to
probe if this is smaller.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: sdm845: add video nodes
2018-11-27 7:31 ` Alexandre Courbot
@ 2018-11-27 8:24 ` Stanimir Varbanov
2019-01-16 9:44 ` Stanimir Varbanov
0 siblings, 1 reply; 5+ messages in thread
From: Stanimir Varbanov @ 2018-11-27 8:24 UTC (permalink / raw)
To: Alexandre Courbot, mgottam
Cc: Stanimir Varbanov, Hans Verkuil, Mauro Carvalho Chehab,
Linux Media Mailing List, LKML, linux-arm-msm, vgarodia
Hi Alex,
On 11/27/18 9:31 AM, Alexandre Courbot wrote:
> On Tue, Nov 20, 2018 at 7:08 PM Malathi Gottam <mgottam@codeaurora.org> wrote:
>>
>> This adds video nodes to sdm845 based on the examples
>> in the bindings.
>>
>> Signed-off-by: Malathi Gottam <mgottam@codeaurora.org>
>> ---
>> arch/arm64/boot/dts/qcom/sdm845.dtsi | 34 ++++++++++++++++++++++++++++++++++
>> 1 file changed, 34 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> index 0c9a2aa..d82487d 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> @@ -84,6 +84,10 @@
>> reg = <0 0x86200000 0 0x2d00000>;
>> no-map;
>> };
>> + venus_region: venus@95800000 {
>> + reg = <0x0 0x95800000 0x0 0x500000>;
>
> Note that the driver expects a size of 0x600000 here and will fail to
> probe if this is smaller.
>
I have to send a patch to fix that size mismatch as we discussed that it
the other mail thread.
--
regards,
Stan
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: sdm845: add video nodes
2018-11-27 8:24 ` Stanimir Varbanov
@ 2019-01-16 9:44 ` Stanimir Varbanov
0 siblings, 0 replies; 5+ messages in thread
From: Stanimir Varbanov @ 2019-01-16 9:44 UTC (permalink / raw)
To: Stanimir Varbanov, Alexandre Courbot, mgottam
Cc: Hans Verkuil, Mauro Carvalho Chehab, Linux Media Mailing List,
LKML, linux-arm-msm, vgarodia
Hi Alex,
On 11/27/18 10:24 AM, Stanimir Varbanov wrote:
> Hi Alex,
>
> On 11/27/18 9:31 AM, Alexandre Courbot wrote:
>> On Tue, Nov 20, 2018 at 7:08 PM Malathi Gottam <mgottam@codeaurora.org> wrote:
>>>
>>> This adds video nodes to sdm845 based on the examples
>>> in the bindings.
>>>
>>> Signed-off-by: Malathi Gottam <mgottam@codeaurora.org>
>>> ---
>>> arch/arm64/boot/dts/qcom/sdm845.dtsi | 34 ++++++++++++++++++++++++++++++++++
>>> 1 file changed, 34 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>>> index 0c9a2aa..d82487d 100644
>>> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>>> @@ -84,6 +84,10 @@
>>> reg = <0 0x86200000 0 0x2d00000>;
>>> no-map;
>>> };
>>> + venus_region: venus@95800000 {
>>> + reg = <0x0 0x95800000 0x0 0x500000>;
>>
>> Note that the driver expects a size of 0x600000 here and will fail to
>> probe if this is smaller.
>>
>
> I have to send a patch to fix that size mismatch as we discussed that it
> the other mail thread.
>
I sent the size mismatch patch here:
https://patchwork.kernel.org/patch/10753645/
--
regards,
Stan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-16 9:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-20 10:08 [PATCH] arm64: dts: sdm845: add video nodes Malathi Gottam
2018-11-21 6:35 ` Sibi Sankar
2018-11-27 7:31 ` Alexandre Courbot
2018-11-27 8:24 ` Stanimir Varbanov
2019-01-16 9:44 ` Stanimir Varbanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).