From: Philipp Zabel <p.zabel@pengutronix.de>
To: David Binderman <dcb314@hotmail.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: drivers/media/platform/imx-pxp.c:683: possible cut''n'paste error ?
Date: Mon, 28 Jan 2019 12:37:26 +0100 [thread overview]
Message-ID: <1548675446.6421.4.camel@pengutronix.de> (raw)
In-Reply-To: <AM6PR08MB38005C4E593AFF9A77FED8D89C950@AM6PR08MB3800.eurprd08.prod.outlook.com>
On Sun, 2019-01-27 at 08:17 +0000, David Binderman wrote:
> Hello there,
>
> drivers/media/platform/imx-pxp.c:683:24: warning: duplicated ‘if’ condition [-Wd
> uplicated-cond]
>
> Source code is
>
> } else if (ycbcr_enc == V4L2_YCBCR_ENC_709) {
> if (quantization == V4L2_QUANTIZATION_FULL_RANGE)
> csc2_coef = csc2_coef_rec709_full;
> else
> csc2_coef = csc2_coef_rec709_lim;
> } else if (ycbcr_enc == V4L2_YCBCR_ENC_709) {
> if (quantization == V4L2_QUANTIZATION_FULL_RANGE)
> csc2_coef = csc2_coef_bt2020_full;
> else
> csc2_coef = csc2_coef_bt2020_lim;
> } else {
>
> The condition on the second if looks wrong. Suggest code rework.
Thank you, I have sent a patch.
regards
Philipp
parent reply other threads:[~2019-01-28 11:37 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <AM6PR08MB38005C4E593AFF9A77FED8D89C950@AM6PR08MB3800.eurprd08.prod.outlook.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548675446.6421.4.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=dcb314@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).