* Re: drivers/media/platform/imx-pxp.c:683: possible cut''n'paste error ?
[not found] <AM6PR08MB38005C4E593AFF9A77FED8D89C950@AM6PR08MB3800.eurprd08.prod.outlook.com>
@ 2019-01-28 11:37 ` Philipp Zabel
0 siblings, 0 replies; only message in thread
From: Philipp Zabel @ 2019-01-28 11:37 UTC (permalink / raw)
To: David Binderman, mchehab, linux-media, linux-kernel
On Sun, 2019-01-27 at 08:17 +0000, David Binderman wrote:
> Hello there,
>
> drivers/media/platform/imx-pxp.c:683:24: warning: duplicated ‘if’ condition [-Wd
> uplicated-cond]
>
> Source code is
>
> } else if (ycbcr_enc == V4L2_YCBCR_ENC_709) {
> if (quantization == V4L2_QUANTIZATION_FULL_RANGE)
> csc2_coef = csc2_coef_rec709_full;
> else
> csc2_coef = csc2_coef_rec709_lim;
> } else if (ycbcr_enc == V4L2_YCBCR_ENC_709) {
> if (quantization == V4L2_QUANTIZATION_FULL_RANGE)
> csc2_coef = csc2_coef_bt2020_full;
> else
> csc2_coef = csc2_coef_bt2020_lim;
> } else {
>
> The condition on the second if looks wrong. Suggest code rework.
Thank you, I have sent a patch.
regards
Philipp
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-01-28 11:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <AM6PR08MB38005C4E593AFF9A77FED8D89C950@AM6PR08MB3800.eurprd08.prod.outlook.com>
2019-01-28 11:37 ` drivers/media/platform/imx-pxp.c:683: possible cut''n'paste error ? Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).