* [PATCH v2 1/1] staging: media: fix style problem
@ 2019-06-21 4:34 Aliasgar Surti
2019-06-25 7:15 ` Hans Verkuil
0 siblings, 1 reply; 2+ messages in thread
From: Aliasgar Surti @ 2019-06-21 4:34 UTC (permalink / raw)
To: linux-media, gregkh, linux-kernel; +Cc: Aliasgar Surti
From: Aliasgar Surti <aliasgar.surti500@gmail.com>
checkpatch reported "WARNING: line over 80 characters".
This patch fixes the warning for file davinci_vpfe/dm365_isif.c
Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
---
Changes in v2:
- Fixed styling as per suggestion in comments
drivers/staging/media/davinci_vpfe/dm365_isif.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/davinci_vpfe/dm365_isif.c b/drivers/staging/media/davinci_vpfe/dm365_isif.c
index 46fd818..e9c8de1 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_isif.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_isif.c
@@ -532,7 +532,8 @@ static int isif_validate_dfc_params(const struct vpfe_isif_dfc *dfc)
#define DM365_ISIF_MAX_CLVSV 0x1fff
#define DM365_ISIF_MAX_HEIGHT_BLACK_REGION 0x1fff
-static int isif_validate_bclamp_params(const struct vpfe_isif_black_clamp *bclamp)
+static int
+isif_validate_bclamp_params(const struct vpfe_isif_black_clamp *bclamp)
{
int err = -EINVAL;
@@ -593,7 +594,8 @@ isif_validate_raw_params(const struct vpfe_isif_raw_config *params)
return isif_validate_bclamp_params(¶ms->bclamp);
}
-static int isif_set_params(struct v4l2_subdev *sd, const struct vpfe_isif_raw_config *params)
+static int isif_set_params(struct v4l2_subdev *sd,
+ const struct vpfe_isif_raw_config *params)
{
struct vpfe_isif_device *isif = v4l2_get_subdevdata(sd);
int ret = -EINVAL;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/1] staging: media: fix style problem
2019-06-21 4:34 [PATCH v2 1/1] staging: media: fix style problem Aliasgar Surti
@ 2019-06-25 7:15 ` Hans Verkuil
0 siblings, 0 replies; 2+ messages in thread
From: Hans Verkuil @ 2019-06-25 7:15 UTC (permalink / raw)
To: Aliasgar Surti, linux-media, gregkh, linux-kernel
Hi Aliasgar,
Please state the driver in question in the Subject. So:
[PATCHv2] staging/media/davinci_vpfe: fix style problems
That way it is clear to reviewers which driver is modified.
Also there is no need for '1/1' if there is only one patch.
Regards,
Hans
On 6/21/19 6:34 AM, Aliasgar Surti wrote:
> From: Aliasgar Surti <aliasgar.surti500@gmail.com>
>
> checkpatch reported "WARNING: line over 80 characters".
> This patch fixes the warning for file davinci_vpfe/dm365_isif.c
>
> Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
> ---
> Changes in v2:
> - Fixed styling as per suggestion in comments
>
> drivers/staging/media/davinci_vpfe/dm365_isif.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_isif.c b/drivers/staging/media/davinci_vpfe/dm365_isif.c
> index 46fd818..e9c8de1 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_isif.c
> +++ b/drivers/staging/media/davinci_vpfe/dm365_isif.c
> @@ -532,7 +532,8 @@ static int isif_validate_dfc_params(const struct vpfe_isif_dfc *dfc)
> #define DM365_ISIF_MAX_CLVSV 0x1fff
> #define DM365_ISIF_MAX_HEIGHT_BLACK_REGION 0x1fff
>
> -static int isif_validate_bclamp_params(const struct vpfe_isif_black_clamp *bclamp)
> +static int
> +isif_validate_bclamp_params(const struct vpfe_isif_black_clamp *bclamp)
> {
> int err = -EINVAL;
>
> @@ -593,7 +594,8 @@ isif_validate_raw_params(const struct vpfe_isif_raw_config *params)
> return isif_validate_bclamp_params(¶ms->bclamp);
> }
>
> -static int isif_set_params(struct v4l2_subdev *sd, const struct vpfe_isif_raw_config *params)
> +static int isif_set_params(struct v4l2_subdev *sd,
> + const struct vpfe_isif_raw_config *params)
> {
> struct vpfe_isif_device *isif = v4l2_get_subdevdata(sd);
> int ret = -EINVAL;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-25 7:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-21 4:34 [PATCH v2 1/1] staging: media: fix style problem Aliasgar Surti
2019-06-25 7:15 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).