* [PATCH] [media] vsp1: make vsp1_drm_frame_end static
@ 2016-04-13 20:42 Mauro Carvalho Chehab
2016-04-14 16:37 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2016-04-13 20:42 UTC (permalink / raw)
Cc: Mauro Carvalho Chehab, Linux Media Mailing List,
Mauro Carvalho Chehab, Laurent Pinchart, linux-renesas-soc
As reported by smatch:
drivers/media/platform/vsp1/vsp1_drm.c:39:6: warning: no previous prototype for 'vsp1_drm_frame_end' [-Wmissing-prototypes]
void vsp1_drm_frame_end(struct vsp1_pipeline *pipe)
Fixes: ef9621bcd664 ("[media] v4l: vsp1: Store the display list manager in the WPF")
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
---
drivers/media/platform/vsp1/vsp1_drm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/vsp1/vsp1_drm.c b/drivers/media/platform/vsp1/vsp1_drm.c
index 22f67360b750..1f08da4b933b 100644
--- a/drivers/media/platform/vsp1/vsp1_drm.c
+++ b/drivers/media/platform/vsp1/vsp1_drm.c
@@ -36,7 +36,7 @@ void vsp1_drm_display_start(struct vsp1_device *vsp1)
vsp1_dlm_irq_display_start(vsp1->drm->pipe.output->dlm);
}
-void vsp1_drm_frame_end(struct vsp1_pipeline *pipe)
+static void vsp1_drm_frame_end(struct vsp1_pipeline *pipe)
{
vsp1_dlm_irq_frame_end(pipe->output->dlm);
}
--
2.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [media] vsp1: make vsp1_drm_frame_end static
2016-04-13 20:42 [PATCH] [media] vsp1: make vsp1_drm_frame_end static Mauro Carvalho Chehab
@ 2016-04-14 16:37 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2016-04-14 16:37 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Linux Media Mailing List, Mauro Carvalho Chehab, linux-renesas-soc
Hi Mauro,
On Wednesday 13 Apr 2016 17:42:24 Mauro Carvalho Chehab wrote:
> As reported by smatch:
> drivers/media/platform/vsp1/vsp1_drm.c:39:6: warning: no previous prototype
> for 'vsp1_drm_frame_end' [-Wmissing-prototypes] void
> vsp1_drm_frame_end(struct vsp1_pipeline *pipe)
>
> Fixes: ef9621bcd664 ("[media] v4l: vsp1: Store the display list manager in
> the WPF") Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Given that patch "[media] v4l: vsp1: Use display lists with the userspace API"
from the same series removes the function, that's most likely overkill, but it
won't hurt. I would have squashed it into the original commit though, as all
this brings is a smatch warning fix that could only be noticed during
bisection without any runtime impact, so a separate patch doesn't help much.
> ---
> drivers/media/platform/vsp1/vsp1_drm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/vsp1/vsp1_drm.c
> b/drivers/media/platform/vsp1/vsp1_drm.c index 22f67360b750..1f08da4b933b
> 100644
> --- a/drivers/media/platform/vsp1/vsp1_drm.c
> +++ b/drivers/media/platform/vsp1/vsp1_drm.c
> @@ -36,7 +36,7 @@ void vsp1_drm_display_start(struct vsp1_device *vsp1)
> vsp1_dlm_irq_display_start(vsp1->drm->pipe.output->dlm);
> }
>
> -void vsp1_drm_frame_end(struct vsp1_pipeline *pipe)
> +static void vsp1_drm_frame_end(struct vsp1_pipeline *pipe)
> {
> vsp1_dlm_irq_frame_end(pipe->output->dlm);
> }
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-14 16:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-13 20:42 [PATCH] [media] vsp1: make vsp1_drm_frame_end static Mauro Carvalho Chehab
2016-04-14 16:37 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).