From: Sowjanya Komatineni <skomatineni@nvidia.com>
To: <skomatineni@nvidia.com>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>, <sakari.ailus@iki.fi>,
<hverkuil@xs4all.nl>, <luca@lucaceresoli.net>,
<leonl@leopardimaging.com>, <robh+dt@kernel.org>,
<lgirdwood@gmail.com>, <broonie@kernel.org>
Cc: <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v4 1/4] media: i2c: imx274: Fix Y_OUT_SIZE register setting
Date: Mon, 31 Aug 2020 12:52:35 -0700 [thread overview]
Message-ID: <1598903558-9691-2-git-send-email-skomatineni@nvidia.com> (raw)
In-Reply-To: <1598903558-9691-1-git-send-email-skomatineni@nvidia.com>
As per Sony IMX274 Y_OUT_SIZE should be the height of effective
image output from the sensor which are the actual total lines
sent over MIPI CSI to receiver.
So, Y_OUT_SIZE should be same as crop height and this patch fixes it.
Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
---
drivers/media/i2c/imx274.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c
index 6011cec..a4b9dfd 100644
--- a/drivers/media/i2c/imx274.c
+++ b/drivers/media/i2c/imx274.c
@@ -1163,7 +1163,7 @@ static int imx274_apply_trimming(struct stimx274 *imx274)
(-imx274->crop.top / 2) : (imx274->crop.top / 2);
v_cut = (IMX274_MAX_HEIGHT - imx274->crop.height) / 2;
write_v_size = imx274->crop.height + 22;
- y_out_size = imx274->crop.height + 14;
+ y_out_size = imx274->crop.height;
err = imx274_write_mbreg(imx274, IMX274_HMAX_REG_LSB, hmax, 2);
if (!err)
--
2.7.4
next prev parent reply other threads:[~2020-08-31 19:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 19:52 [PATCH v4 0/4] IMX274 fixes and power on and off implementation Sowjanya Komatineni
2020-08-31 19:52 ` Sowjanya Komatineni [this message]
2020-08-31 19:52 ` [PATCH v4 2/4] dt-bindings: media: imx274: Use lower case for supply names Sowjanya Komatineni
2020-08-31 19:52 ` [PATCH v4 3/4] dt-bindings: media: imx274: Move clock and supplies to required properties Sowjanya Komatineni
2020-08-31 20:17 ` Sakari Ailus
2020-08-31 20:37 ` Sowjanya Komatineni
2020-08-31 20:40 ` Sakari Ailus
2020-08-31 20:41 ` Sowjanya Komatineni
2020-08-31 20:26 ` Sakari Ailus
2020-08-31 22:04 ` Sowjanya Komatineni
2020-08-31 19:52 ` [PATCH v4 4/4] media: i2c: imx274: Add IMX274 power on and off sequence Sowjanya Komatineni
2020-08-31 20:23 ` Sakari Ailus
[not found] ` <b4db7b37-a0d7-9324-c47a-53ad22b8c444@nvidia.com>
2020-08-31 20:48 ` Sakari Ailus
2020-08-31 20:54 ` Sowjanya Komatineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1598903558-9691-2-git-send-email-skomatineni@nvidia.com \
--to=skomatineni@nvidia.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=jonathanh@nvidia.com \
--cc=leonl@leopardimaging.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).