From: Sakari Ailus <sakari.ailus@iki.fi>
To: Sowjanya Komatineni <skomatineni@nvidia.com>
Cc: thierry.reding@gmail.com, jonathanh@nvidia.com,
hverkuil@xs4all.nl, luca@lucaceresoli.net,
leonl@leopardimaging.com, robh+dt@kernel.org,
lgirdwood@gmail.com, broonie@kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/4] dt-bindings: media: imx274: Move clock and supplies to required properties
Date: Mon, 31 Aug 2020 23:40:05 +0300 [thread overview]
Message-ID: <20200831204005.GF844@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <5c341ed9-6077-e935-de50-ff9f5f17edcf@nvidia.com>
On Mon, Aug 31, 2020 at 01:37:21PM -0700, Sowjanya Komatineni wrote:
>
> On 8/31/20 1:17 PM, Sakari Ailus wrote:
> > Hi Sowjanya,
> >
> > On Mon, Aug 31, 2020 at 12:52:37PM -0700, Sowjanya Komatineni wrote:
> > > Clock and supplies are external to IMX274 sensor and are dependent
> > > on camera module design.
> > >
> > > So, this patch moves them to required properties.
> > >
> > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
> > > ---
> > > Documentation/devicetree/bindings/media/i2c/imx274.txt | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt
> > > index d0a5c899..b43bed6 100644
> > > --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt
> > > +++ b/Documentation/devicetree/bindings/media/i2c/imx274.txt
> > > @@ -10,15 +10,15 @@ at 1440 Mbps.
> > > Required Properties:
> > > - compatible: value should be "sony,imx274" for imx274 sensor
> > > - reg: I2C bus address of the device
> > > -
> > > -Optional Properties:
> > > -- reset-gpios: Sensor reset GPIO
> > > - clocks: Reference to the input clock.
> > > - clock-names: Should be "inck".
> > > - vana-supply: Sensor 2.8v analog supply.
> > > - vdig-supply: Sensor 1.8v digital core supply.
> > > - vddl-supply: Sensor digital IO 1.2v supply.
> > If these have been optional in the past I don't think we can start
> > requiring them now.
> >
> > The framework will just give the driver a dummy regulator if one isn't
> > found.
> These were added recently with my patches. So I hope should be ok to make
> them required as they are external to sensor
The bindings were added back in 2017, so they're not really recent.
--
Sakari Ailus
next prev parent reply other threads:[~2020-08-31 20:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 19:52 [PATCH v4 0/4] IMX274 fixes and power on and off implementation Sowjanya Komatineni
2020-08-31 19:52 ` [PATCH v4 1/4] media: i2c: imx274: Fix Y_OUT_SIZE register setting Sowjanya Komatineni
2020-08-31 19:52 ` [PATCH v4 2/4] dt-bindings: media: imx274: Use lower case for supply names Sowjanya Komatineni
2020-08-31 19:52 ` [PATCH v4 3/4] dt-bindings: media: imx274: Move clock and supplies to required properties Sowjanya Komatineni
2020-08-31 20:17 ` Sakari Ailus
2020-08-31 20:37 ` Sowjanya Komatineni
2020-08-31 20:40 ` Sakari Ailus [this message]
2020-08-31 20:41 ` Sowjanya Komatineni
2020-08-31 20:26 ` Sakari Ailus
2020-08-31 22:04 ` Sowjanya Komatineni
2020-08-31 19:52 ` [PATCH v4 4/4] media: i2c: imx274: Add IMX274 power on and off sequence Sowjanya Komatineni
2020-08-31 20:23 ` Sakari Ailus
[not found] ` <b4db7b37-a0d7-9324-c47a-53ad22b8c444@nvidia.com>
2020-08-31 20:48 ` Sakari Ailus
2020-08-31 20:54 ` Sowjanya Komatineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831204005.GF844@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=jonathanh@nvidia.com \
--cc=leonl@leopardimaging.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=robh+dt@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).