* [PATCH v2] media: s5p-g2d: Fix a memory leak on ctx->fh.m2m_ctx
@ 2021-05-26 15:18 dillon.minfei
0 siblings, 0 replies; only message in thread
From: dillon.minfei @ 2021-05-26 15:18 UTC (permalink / raw)
To: mchehab+huawei, hverkuil-cisco, a.hajda, mchehab
Cc: linux-arm-kernel, linux-media, linux-kernel, Dillon Min
From: Dillon Min <dillon.minfei@gmail.com>
The m2m_ctx resources was allocated by v4l2_m2m_ctx_init() in g2d_open()
should be freed from g2d_release() when it's not used.
Fix it
Fixes: 918847341af0 ("[media] v4l: add G2D driver for s5p device family")
Signed-off-by: Dillon Min <dillon.minfei@gmail.com>
---
v2: move v4l2_m2m_ctx_release() up to v4l2_ctrl_handler() from Hans's
suggestion, thanks.
drivers/media/platform/s5p-g2d/g2d.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/s5p-g2d/g2d.c b/drivers/media/platform/s5p-g2d/g2d.c
index 15bcb7f6e113..1cb5eaabf340 100644
--- a/drivers/media/platform/s5p-g2d/g2d.c
+++ b/drivers/media/platform/s5p-g2d/g2d.c
@@ -276,6 +276,9 @@ static int g2d_release(struct file *file)
struct g2d_dev *dev = video_drvdata(file);
struct g2d_ctx *ctx = fh2ctx(file->private_data);
+ mutex_lock(&dev->mutex);
+ v4l2_m2m_ctx_release(ctx->fh.m2m_ctx);
+ mutex_unlock(&dev->mutex);
v4l2_ctrl_handler_free(&ctx->ctrl_handler);
v4l2_fh_del(&ctx->fh);
v4l2_fh_exit(&ctx->fh);
--
1.9.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-05-26 15:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-26 15:18 [PATCH v2] media: s5p-g2d: Fix a memory leak on ctx->fh.m2m_ctx dillon.minfei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).