* [PATCH V2] media: i2c: ccs: replace snprintf in show functions with sysfs_emit
@ 2021-10-18 8:00 Qing Wang
2021-10-19 14:51 ` Kieran Bingham
0 siblings, 1 reply; 2+ messages in thread
From: Qing Wang @ 2021-10-18 8:00 UTC (permalink / raw)
To: Sakari Ailus, Mauro Carvalho Chehab, linux-media, linux-kernel; +Cc: Qing Wang
show() should not use snprintf() when formatting the value to be
returned to user space.
Fix the following coccicheck warning:
drivers/media/i2c/ccs/ccs-core.c:3761: WARNING: use scnprintf or sprintf.
Signed-off-by: Qing Wang <wangqing@vivo.com>
---
drivers/media/i2c/ccs/ccs-core.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c
index 5363f3b..9158d3c
--- a/drivers/media/i2c/ccs/ccs-core.c
+++ b/drivers/media/i2c/ccs/ccs-core.c
@@ -2758,13 +2758,13 @@ ident_show(struct device *dev, struct device_attribute *attr, char *buf)
struct ccs_module_info *minfo = &sensor->minfo;
if (minfo->mipi_manufacturer_id)
- return snprintf(buf, PAGE_SIZE, "%4.4x%4.4x%2.2x\n",
- minfo->mipi_manufacturer_id, minfo->model_id,
- minfo->revision_number) + 1;
+ return sysfs_emit(buf, "%4.4x%4.4x%2.2x\n",
+ minfo->mipi_manufacturer_id, minfo->model_id,
+ minfo->revision_number) + 1;
else
- return snprintf(buf, PAGE_SIZE, "%2.2x%4.4x%2.2x\n",
- minfo->smia_manufacturer_id, minfo->model_id,
- minfo->revision_number) + 1;
+ return sysfs_emit(buf, "%2.2x%4.4x%2.2x\n",
+ minfo->smia_manufacturer_id, minfo->model_id,
+ minfo->revision_number) + 1;
}
static DEVICE_ATTR_RO(ident);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V2] media: i2c: ccs: replace snprintf in show functions with sysfs_emit
2021-10-18 8:00 [PATCH V2] media: i2c: ccs: replace snprintf in show functions with sysfs_emit Qing Wang
@ 2021-10-19 14:51 ` Kieran Bingham
0 siblings, 0 replies; 2+ messages in thread
From: Kieran Bingham @ 2021-10-19 14:51 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Qing Wang, Sakari Ailus, linux-kernel,
linux-media
Cc: Qing Wang
Hello,
Quoting Qing Wang (2021-10-18 09:00:36)
> show() should not use snprintf() when formatting the value to be
> returned to user space.
>
> Fix the following coccicheck warning:
> drivers/media/i2c/ccs/ccs-core.c:3761: WARNING: use scnprintf or sprintf.
>
Thank you for posting a v2 with the lines adjusted ...
> Signed-off-by: Qing Wang <wangqing@vivo.com>
> ---
> drivers/media/i2c/ccs/ccs-core.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c
> index 5363f3b..9158d3c
> --- a/drivers/media/i2c/ccs/ccs-core.c
> +++ b/drivers/media/i2c/ccs/ccs-core.c
> @@ -2758,13 +2758,13 @@ ident_show(struct device *dev, struct device_attribute *attr, char *buf)
> struct ccs_module_info *minfo = &sensor->minfo;
>
> if (minfo->mipi_manufacturer_id)
> - return snprintf(buf, PAGE_SIZE, "%4.4x%4.4x%2.2x\n",
> - minfo->mipi_manufacturer_id, minfo->model_id,
> - minfo->revision_number) + 1;
> + return sysfs_emit(buf, "%4.4x%4.4x%2.2x\n",
> + minfo->mipi_manufacturer_id, minfo->model_id,
> + minfo->revision_number) + 1;
However they are still not lined up correctly.
It should look like:
return sysfs_emit(buf, "%4.4x%4.4x%2.2x\n",
minfo->mipi_manufacturer_id, minfo->model_id,
minfo->revision_number) + 1;
With the m from 'minfo' aligned directly below the b from 'buf' to match
the indention.
--
Regards
Kieran
> else
> - return snprintf(buf, PAGE_SIZE, "%2.2x%4.4x%2.2x\n",
> - minfo->smia_manufacturer_id, minfo->model_id,
> - minfo->revision_number) + 1;
> + return sysfs_emit(buf, "%2.2x%4.4x%2.2x\n",
> + minfo->smia_manufacturer_id, minfo->model_id,
> + minfo->revision_number) + 1;
> }
> static DEVICE_ATTR_RO(ident);
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-19 14:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-18 8:00 [PATCH V2] media: i2c: ccs: replace snprintf in show functions with sysfs_emit Qing Wang
2021-10-19 14:51 ` Kieran Bingham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).