Re: [PATCH 2/5] dt-bindings: media: Add bindings for ARM mali-c55

From: Rob Herring <robh@kernel.org>
To: Daniel Scally <dan.scally@ideasonboard.com>
Cc: linux-media@vger.kernel.org, nayden.kanchev@arm.com,
	 linux-arm-kernel@lists.infradead.org, conor+dt@kernel.org,
	 laurent.pinchart@ideasonboard.com, devicetree@vger.kernel.org,
	 krzysztof.kozlowski+dt@linaro.org, mchehab@kernel.org,
	 jerome.forissier@linaro.org, jacopo.mondi@ideasonboard.com,
	 kieran.bingham@ideasonboard.com, robh+dt@kernel.org
Subject: Re: [PATCH 2/5] dt-bindings: media: Add bindings for ARM mali-c55
Date: Wed, 31 Jan 2024 12:28:31 -0600	[thread overview]
Message-ID: <170672571070.2062253.5359379478215022864.robh@kernel.org> (raw)
In-Reply-To: <20240131164709.810587-3-dan.scally@ideasonboard.com>

On Wed, 31 Jan 2024 16:47:06 +0000, Daniel Scally wrote:
> Add the yaml binding for ARM's Mali-C55 Image Signal Processor.
> 
> Acked-by: Nayden Kanchev <nayden.kanchev@arm.com>
> Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>
> ---
>  .../bindings/media/arm,mali-c55.yaml          | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/arm,mali-c55.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/arm,mali-c55.example.dts:29.18-33.13: Warning (unit_address_vs_reg): /example-0/isp@400000/port@0: node has a unit name, but no reg or ranges property
Documentation/devicetree/bindings/media/arm,mali-c55.example.dts:30.32-32.15: Warning (unit_address_vs_reg): /example-0/isp@400000/port@0/endpoint@0: node has a unit name, but no reg or ranges property
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/arm,mali-c55.example.dtb: isp@400000: 'port' is a required property
	from schema $id: http://devicetree.org/schemas/media/arm,mali-c55.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/arm,mali-c55.example.dtb: isp@400000: 'port@0' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/media/arm,mali-c55.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240131164709.810587-3-dan.scally@ideasonboard.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.