Re: [PATCH] media: fdp1: Reduce FCP not found message level to debug

[Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>]

Hi Geert,

On 09/07/2019 10:59, Geert Uytterhoeven wrote:
> When support for the IPMMU is not enabled, the FDP driver may be
> probe-deferred multiple times, causing several messages to be printed
> like:
> 
>     rcar_fdp1 fe940000.fdp1: FCP not found (-517)
>     rcar_fdp1 fe944000.fdp1: FCP not found (-517)
> 
> Fix this by reducing the message level to debug level, as is done in the
> VSP1 driver.

Does the lack of IPMMU prevent the FDP1 being loaded entirely?

If so is that a problem for us? (I thought we were able to run without
the IPMMU)


> Fixes: 4710b752e029f3f8 ("[media] v4l: Add Renesas R-Car FDP1 Driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> The alternative would be to add an explicit check for -EPROBE_DEFER.
> ---
>  drivers/media/platform/rcar_fdp1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/rcar_fdp1.c b/drivers/media/platform/rcar_fdp1.c
> index 43aae9b6bb20e3e8..c23ec127c2776f51 100644
> --- a/drivers/media/platform/rcar_fdp1.c
> +++ b/drivers/media/platform/rcar_fdp1.c
> @@ -2306,7 +2306,7 @@ static int fdp1_probe(struct platform_device *pdev)
>  		fdp1->fcp = rcar_fcp_get(fcp_node);
>  		of_node_put(fcp_node);
>  		if (IS_ERR(fdp1->fcp)) {
> -			dev_err(&pdev->dev, "FCP not found (%ld)\n",
> +			dev_dbg(&pdev->dev, "FCP not found (%ld)\n",
>  				PTR_ERR(fdp1->fcp));

Should we be doing something differently here in the event of no IPMMU then?

Otherwise, if the IPMMU has become a hard dependency, should we add it
to the Kconfig dependencies?


>  			return PTR_ERR(fdp1->fcp);
>  		}
> 

--
Regards

Kieran