From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] media: fdp1: Reduce FCP not found message level to debug
Date: Tue, 9 Jul 2019 12:13:14 +0200 [thread overview]
Message-ID: <CAMuHMdU-iTH0AjCx9TxJn+aWUxF_7D5zqrKrwvC_FPybKFBYMA@mail.gmail.com> (raw)
In-Reply-To: <17f28f31-73e1-5170-a0d5-31ad9826defa@ideasonboard.com>
Hi Kieran,
On Tue, Jul 9, 2019 at 12:07 PM Kieran Bingham
<kieran.bingham+renesas@ideasonboard.com> wrote:
> On 09/07/2019 10:59, Geert Uytterhoeven wrote:
> > When support for the IPMMU is not enabled, the FDP driver may be
> > probe-deferred multiple times, causing several messages to be printed
> > like:
> >
> > rcar_fdp1 fe940000.fdp1: FCP not found (-517)
> > rcar_fdp1 fe944000.fdp1: FCP not found (-517)
> >
> > Fix this by reducing the message level to debug level, as is done in the
> > VSP1 driver.
>
> Does the lack of IPMMU prevent the FDP1 being loaded entirely?
No it doesn't.
If CONFIG_IPMMU_VMSA=n,
rcar_fdp1 fe940000.fdp1: FCP not found (-517)
rcar_fdp1 fe944000.fdp1: FCP not found (-517)
rcar_fdp1 fe940000.fdp1: FCP not found (-517)
rcar_fdp1 fe944000.fdp1: FCP not found (-517)
rcar_fdp1 fe940000.fdp1: FCP not found (-517)
rcar_fdp1 fe944000.fdp1: FCP not found (-517)
rcar_fdp1 fe940000.fdp1: Device registered as /dev/video8
rcar_fdp1 fe944000.fdp1: Device registered as /dev/video9
So the driver succeeds, eventually.
If CONFIG_IPMMU_VMSA=y, it succeeds sooner:
rcar_fdp1 fe940000.fdp1: Device registered as /dev/video0
rcar_fdp1 fe944000.fdp1: Device registered as /dev/video1
Always be prepared to handle -EPROBE_DEFER.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-07-09 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 9:59 [PATCH] media: fdp1: Reduce FCP not found message level to debug Geert Uytterhoeven
2019-07-09 10:07 ` Kieran Bingham
2019-07-09 10:13 ` Geert Uytterhoeven [this message]
2019-07-09 10:18 ` Kieran Bingham
2019-07-09 10:28 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdU-iTH0AjCx9TxJn+aWUxF_7D5zqrKrwvC_FPybKFBYMA@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=geert+renesas@glider.be \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).