From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Zhi Mao <zhi.mao@mediatek.com>,
mchehab@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: shengnan.wang@mediatek.com, yaya.chang@mediatek.com,
10572168@qq.com,
Project_Global_Chrome_Upstream_Group@mediatek.com,
yunkec@chromium.org, conor+dt@kernel.org, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com,
jacopo.mondi@ideasonboard.com, sakari.ailus@linux.intel.com,
hverkuil-cisco@xs4all.nl, heiko@sntech.de,
jernej.skrabec@gmail.com, macromorgan@hotmail.com,
linus.walleij@linaro.org, laurent.pinchart@ideasonboard.com,
hdegoede@redhat.com, tomi.valkeinen@ideasonboard.com,
gerald.loacker@wolfvision.net, andy.shevchenko@gmail.com,
bingbu.cao@intel.com, dan.scally@ideasonboard.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/2] media: i2c: Add GC08A3 image sensor driver
Date: Thu, 7 Dec 2023 09:18:20 +0100 [thread overview]
Message-ID: <1d58c2b9-4206-409c-b312-87f4fb649512@linaro.org> (raw)
In-Reply-To: <20231207052016.25954-2-zhi.mao@mediatek.com>
On 07/12/2023 06:20, Zhi Mao wrote:
> Add a V4L2 sub-device driver for Galaxycore GC08A3 image sensor.
>
> Reviewed-By: yunkec@chromium.org
I don't see review given here:
https://lore.kernel.org/linux-media/20231123115104.32094-1-zhi.mao@mediatek.com/
This does not look like real review. Where was it performed? How
thorough was it? How many review iterations did it include? Why there
is no name but anonymous review?
> Signed-off-by: Zhi Mao <zhi.mao@mediatek.com>
> ---
> drivers/media/i2c/Kconfig | 14 +
> drivers/media/i2c/Makefile | 1 +
> drivers/media/i2c/gc08a3.c | 1888 ++++++++++++++++++++++++++++++++++++
> 3 files changed, 1903 insertions(+)
> create mode 100644 drivers/media/i2c/gc08a3.c
>
...
> +static inline struct gc08a3 *to_gc08a3(struct v4l2_subdev *sd)
> +{
> + return container_of(sd, struct gc08a3, sd);
> +}
> +
> +static int gc08a3_power_on(struct device *dev)
> +{
> + struct i2c_client *client = to_i2c_client(dev);
> + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> + struct gc08a3 *gc08a3 = to_gc08a3(sd);
> + int ret;
> +
> + gpiod_set_value_cansleep(gc08a3->enable_gpio, 0);
Why do you put make enable GPIO low? That's not how enable GPIO is
supposed to work...
> + usleep_range(GC08A3_MIN_SLEEP_US, GC08A3_MAX_SLEEP_US);
> +
> + ret = regulator_bulk_enable(GC08A3_NUM_SUPPLIES, gc08a3->supplies);
> + if (ret < 0) {
> + dev_err(gc08a3->dev, "failed to enable regulators: %d\n", ret);
> + return ret;
> + }
> +
> + ret = clk_prepare_enable(gc08a3->xclk);
> + if (ret < 0) {
> + regulator_bulk_disable(GC08A3_NUM_SUPPLIES, gc08a3->supplies);
> + dev_err(gc08a3->dev, "clk prepare enable failed\n");
> + return ret;
> + }
> +
> + usleep_range(GC08A3_MIN_SLEEP_US, GC08A3_MAX_SLEEP_US);
> +
> + gpiod_set_value_cansleep(gc08a3->enable_gpio, 1);
> + usleep_range(GC08A3_MIN_SLEEP_US, GC08A3_MAX_SLEEP_US);
> +
> + return 0;
> +}
> +
> +static int gc08a3_power_off(struct device *dev)
> +{
> + struct i2c_client *client = to_i2c_client(dev);
> + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> + struct gc08a3 *gc08a3 = to_gc08a3(sd);
> +
> + gpiod_set_value_cansleep(gc08a3->enable_gpio, 0);
How making enable GPIO low is related to power off? Enable means you
turn on some feature, not shutdown. Look at common GPIO consumer
bindings in the kernel.
...
> +static int gc08a3_probe(struct i2c_client *client)
> +{
> + struct device *dev = &client->dev;
> + struct gc08a3 *gc08a3;
> + int ret;
> +
> + ret = gc08a3_parse_fwnode(dev);
> + if (ret)
> + return ret;
> +
> + gc08a3 = devm_kzalloc(dev, sizeof(*gc08a3), GFP_KERNEL);
> + if (!gc08a3)
> + return -ENOMEM;
> +
> + gc08a3->dev = dev;
> +
> + gc08a3->xclk = devm_clk_get(dev, NULL);
> + if (IS_ERR(gc08a3->xclk))
> + return dev_err_probe(dev, PTR_ERR(gc08a3->xclk),
> + "failed to get xclk\n");
Misaligned indentation
> +
> + ret = clk_set_rate(gc08a3->xclk, GC08A3_DEFAULT_CLK_FREQ);
> + if (ret)
> + return dev_err_probe(dev, ret,
> + "failed to set xclk frequency\n");
Misaligned indentation
> +
> + ret = gc08a3_get_regulators(dev, gc08a3);
> + if (ret < 0)
> + return dev_err_probe(dev, ret,
> + "failed to get regulators\n");
Misaligned indentation
> +
> + gc08a3->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW);
> + if (IS_ERR(gc08a3->enable_gpio))
> + return dev_err_probe(dev, PTR_ERR(gc08a3->enable_gpio),
> + "failed to get gpio\n");
Misaligned indentation... probably entire code is misaligned.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-07 8:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 5:20 [PATCH v2 0/2] media: i2c: Add support for GC08A3 sensor Zhi Mao
2023-12-07 5:20 ` [PATCH 1/2] media: i2c: Add GC08A3 image sensor driver Zhi Mao
2023-12-07 8:18 ` Krzysztof Kozlowski [this message]
[not found] ` <e709beb2acaf0cb68c6922f3b48431644e9a0246.camel@mediatek.com>
2024-01-09 8:01 ` Krzysztof Kozlowski
2024-01-09 8:38 ` Laurent Pinchart
2024-01-09 8:44 ` Zhi Mao (毛智)
2024-01-09 10:46 ` Zhi Mao (毛智)
2023-12-07 11:34 ` Sakari Ailus
2023-12-07 12:30 ` Krzysztof Kozlowski
2023-12-07 17:44 ` Conor Dooley
2023-12-08 2:07 ` Zhi Mao (毛智)
2023-12-08 9:54 ` sakari.ailus
[not found] ` <4021c964afebc502860571b1253423fab91b20f1.camel@mediatek.com>
2024-01-09 8:04 ` Krzysztof Kozlowski
2024-01-09 10:41 ` Zhi Mao (毛智)
2024-01-09 11:23 ` sakari.ailus
2023-12-07 5:20 ` [PATCH 2/2] media: dt-bindings: media: i2c: Document GC08A3 bindings Zhi Mao
2023-12-07 8:21 ` Krzysztof Kozlowski
[not found] ` <6b1b6970e715e4bcdb0d72adb8b895b836e34201.camel@mediatek.com>
2024-01-09 8:01 ` Krzysztof Kozlowski
2023-12-07 8:19 ` [PATCH v2 0/2] media: i2c: Add support for GC08A3 sensor Krzysztof Kozlowski
2023-12-07 11:44 ` Laurent Pinchart
2023-12-07 11:45 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d58c2b9-4206-409c-b312-87f4fb649512@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=10572168@qq.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=andy.shevchenko@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bingbu.cao@intel.com \
--cc=conor+dt@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=gerald.loacker@wolfvision.net \
--cc=hdegoede@redhat.com \
--cc=heiko@sntech.de \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=macromorgan@hotmail.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shengnan.wang@mediatek.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=yaya.chang@mediatek.com \
--cc=yunkec@chromium.org \
--cc=zhi.mao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).