From: Conor Dooley <conor@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Zhi Mao <zhi.mao@mediatek.com>,
mchehab@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, shengnan.wang@mediatek.com,
yaya.chang@mediatek.com, 10572168@qq.com,
Project_Global_Chrome_Upstream_Group@mediatek.com,
yunkec@chromium.org, conor+dt@kernel.org, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com,
jacopo.mondi@ideasonboard.com, hverkuil-cisco@xs4all.nl,
heiko@sntech.de, jernej.skrabec@gmail.com,
macromorgan@hotmail.com, linus.walleij@linaro.org,
laurent.pinchart@ideasonboard.com, hdegoede@redhat.com,
tomi.valkeinen@ideasonboard.com, gerald.loacker@wolfvision.net,
andy.shevchenko@gmail.com, bingbu.cao@intel.com,
dan.scally@ideasonboard.com, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/2] media: i2c: Add GC08A3 image sensor driver
Date: Thu, 7 Dec 2023 17:44:32 +0000 [thread overview]
Message-ID: <20231207-outcome-acclaim-d179c8c07fff@spud> (raw)
In-Reply-To: <129e3a8b-5e91-424a-8ff8-b015d5175f1a@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]
On Thu, Dec 07, 2023 at 01:30:35PM +0100, Krzysztof Kozlowski wrote:
> On 07/12/2023 12:34, Sakari Ailus wrote:
> >> + ret = gc08a3_parse_fwnode(dev);
> >> + if (ret)
> >> + return ret;
> >> +
> >> + gc08a3 = devm_kzalloc(dev, sizeof(*gc08a3), GFP_KERNEL);
> >> + if (!gc08a3)
> >> + return -ENOMEM;
> >> +
> >> + gc08a3->dev = dev;
> >> +
> >> + gc08a3->xclk = devm_clk_get(dev, NULL);
> >> + if (IS_ERR(gc08a3->xclk))
> >> + return dev_err_probe(dev, PTR_ERR(gc08a3->xclk),
> >> + "failed to get xclk\n");
> >> +
> >> + ret = clk_set_rate(gc08a3->xclk, GC08A3_DEFAULT_CLK_FREQ);
> >
> > Please see:
> > <URL:https://hverkuil.home.xs4all.nl/spec/driver-api/camera-sensor.html#devicetree>.
>
>
> Oh, that's cool it was documented!
>
> The canonical link would be:
> https://www.kernel.org/doc/html/latest/driver-api/media/camera-sensor.html#devicetree
I believe this is that answer to the "why are these needed" that I asked
on the previous version and never got a response to. Instead, they were
just removed from the binding etc.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-12-07 17:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 5:20 [PATCH v2 0/2] media: i2c: Add support for GC08A3 sensor Zhi Mao
2023-12-07 5:20 ` [PATCH 1/2] media: i2c: Add GC08A3 image sensor driver Zhi Mao
2023-12-07 8:18 ` Krzysztof Kozlowski
[not found] ` <e709beb2acaf0cb68c6922f3b48431644e9a0246.camel@mediatek.com>
2024-01-09 8:01 ` Krzysztof Kozlowski
2024-01-09 8:38 ` Laurent Pinchart
2024-01-09 8:44 ` Zhi Mao (毛智)
2024-01-09 10:46 ` Zhi Mao (毛智)
2023-12-07 11:34 ` Sakari Ailus
2023-12-07 12:30 ` Krzysztof Kozlowski
2023-12-07 17:44 ` Conor Dooley [this message]
2023-12-08 2:07 ` Zhi Mao (毛智)
2023-12-08 9:54 ` sakari.ailus
[not found] ` <4021c964afebc502860571b1253423fab91b20f1.camel@mediatek.com>
2024-01-09 8:04 ` Krzysztof Kozlowski
2024-01-09 10:41 ` Zhi Mao (毛智)
2024-01-09 11:23 ` sakari.ailus
2023-12-07 5:20 ` [PATCH 2/2] media: dt-bindings: media: i2c: Document GC08A3 bindings Zhi Mao
2023-12-07 8:21 ` Krzysztof Kozlowski
[not found] ` <6b1b6970e715e4bcdb0d72adb8b895b836e34201.camel@mediatek.com>
2024-01-09 8:01 ` Krzysztof Kozlowski
2023-12-07 8:19 ` [PATCH v2 0/2] media: i2c: Add support for GC08A3 sensor Krzysztof Kozlowski
2023-12-07 11:44 ` Laurent Pinchart
2023-12-07 11:45 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207-outcome-acclaim-d179c8c07fff@spud \
--to=conor@kernel.org \
--cc=10572168@qq.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=andy.shevchenko@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bingbu.cao@intel.com \
--cc=conor+dt@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=gerald.loacker@wolfvision.net \
--cc=hdegoede@redhat.com \
--cc=heiko@sntech.de \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=macromorgan@hotmail.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shengnan.wang@mediatek.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=yaya.chang@mediatek.com \
--cc=yunkec@chromium.org \
--cc=zhi.mao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).