* [PATCH] media: dvb: remove spaces before '['
[not found] <20230714080514.14297-1-xujianghui@cdjrlc.com>
@ 2023-07-14 8:06 ` sunran001
2023-07-19 6:05 ` Hans Verkuil
0 siblings, 1 reply; 2+ messages in thread
From: sunran001 @ 2023-07-14 8:06 UTC (permalink / raw)
To: mchehab; +Cc: linux-media, linux-kernel
Remove spaces to clear checkpatch errors.
ERROR: space prohibited before open square bracket '['
Signed-off-by: Ran Sun <sunran001@208suo.com>
---
drivers/media/dvb-frontends/tda826x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/dvb-frontends/tda826x.c
b/drivers/media/dvb-frontends/tda826x.c
index f9703a1dd758..7f17efe17d11 100644
--- a/drivers/media/dvb-frontends/tda826x.c
+++ b/drivers/media/dvb-frontends/tda826x.c
@@ -38,7 +38,7 @@ static int tda826x_sleep(struct dvb_frontend *fe)
{
struct tda826x_priv *priv = fe->tuner_priv;
int ret;
- u8 buf [] = { 0x00, 0x8d };
+ u8 buf[] = { 0x00, 0x8d };
struct i2c_msg msg = { .addr = priv->i2c_address, .flags = 0, .buf
= buf, .len = 2 };
dprintk("%s:\n", __func__);
@@ -65,7 +65,7 @@ static int tda826x_set_params(struct dvb_frontend *fe)
u32 div;
u32 ksyms;
u32 bandwidth;
- u8 buf [11];
+ u8 buf[11];
struct i2c_msg msg = { .addr = priv->i2c_address, .flags = 0, .buf
= buf, .len = 11 };
dprintk("%s:\n", __func__);
@@ -130,7 +130,7 @@ static const struct dvb_tuner_ops tda826x_tuner_ops
= {
struct dvb_frontend *tda826x_attach(struct dvb_frontend *fe, int addr,
struct i2c_adapter *i2c, int has_loopthrough)
{
struct tda826x_priv *priv = NULL;
- u8 b1 [] = { 0, 0 };
+ u8 b1[] = { 0, 0 };
struct i2c_msg msg[2] = {
{ .addr = addr, .flags = 0, .buf = NULL, .len = 0 },
{ .addr = addr, .flags = I2C_M_RD, .buf = b1, .len = 2 }
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: dvb: remove spaces before '['
2023-07-14 8:06 ` [PATCH] media: dvb: remove spaces before '[' sunran001
@ 2023-07-19 6:05 ` Hans Verkuil
0 siblings, 0 replies; 2+ messages in thread
From: Hans Verkuil @ 2023-07-19 6:05 UTC (permalink / raw)
To: sunran001, mchehab; +Cc: linux-media, linux-kernel
Hi Ran Sun,
On 14/07/2023 10:06, sunran001@208suo.com wrote:
> Remove spaces to clear checkpatch errors.
>
> ERROR: space prohibited before open square bracket '['
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
> drivers/media/dvb-frontends/tda826x.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/dvb-frontends/tda826x.c b/drivers/media/dvb-frontends/tda826x.c
> index f9703a1dd758..7f17efe17d11 100644
> --- a/drivers/media/dvb-frontends/tda826x.c
> +++ b/drivers/media/dvb-frontends/tda826x.c
> @@ -38,7 +38,7 @@ static int tda826x_sleep(struct dvb_frontend *fe)
> {
> struct tda826x_priv *priv = fe->tuner_priv;
> int ret;
> - u8 buf [] = { 0x00, 0x8d };
> + u8 buf[] = { 0x00, 0x8d };
This patch is corrupt: TABs have been replaced by spaces.
It's not just this patch, but all 7 patches you posted to linux-media.
Also, please mention the name of the driver you fixed in the subject.
So: "media: dvb: tda826x: remove space before '['".
Regards,
Hans
> struct i2c_msg msg = { .addr = priv->i2c_address, .flags = 0, .buf = buf, .len = 2 };
>
> dprintk("%s:\n", __func__);
> @@ -65,7 +65,7 @@ static int tda826x_set_params(struct dvb_frontend *fe)
> u32 div;
> u32 ksyms;
> u32 bandwidth;
> - u8 buf [11];
> + u8 buf[11];
> struct i2c_msg msg = { .addr = priv->i2c_address, .flags = 0, .buf = buf, .len = 11 };
>
> dprintk("%s:\n", __func__);
> @@ -130,7 +130,7 @@ static const struct dvb_tuner_ops tda826x_tuner_ops = {
> struct dvb_frontend *tda826x_attach(struct dvb_frontend *fe, int addr, struct i2c_adapter *i2c, int has_loopthrough)
> {
> struct tda826x_priv *priv = NULL;
> - u8 b1 [] = { 0, 0 };
> + u8 b1[] = { 0, 0 };
> struct i2c_msg msg[2] = {
> { .addr = addr, .flags = 0, .buf = NULL, .len = 0 },
> { .addr = addr, .flags = I2C_M_RD, .buf = b1, .len = 2 }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-19 6:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230714080514.14297-1-xujianghui@cdjrlc.com>
2023-07-14 8:06 ` [PATCH] media: dvb: remove spaces before '[' sunran001
2023-07-19 6:05 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).