* [PATCH] [media] stk1160: warrant a NUL terminated string
@ 2014-04-07 13:42 Mauro Carvalho Chehab
2014-04-07 13:45 ` Hans Verkuil
2014-04-07 15:08 ` Ezequiel Garcia
0 siblings, 2 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2014-04-07 13:42 UTC (permalink / raw)
Cc: Mauro Carvalho Chehab, Linux Media Mailing List, Mauro Carvalho Chehab
strncpy() doesn't warrant a NUL terminated string. Use
strlcpy() instead.
Fixes Coverity bug CID#1195195.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
---
drivers/media/usb/stk1160/stk1160-ac97.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/stk1160/stk1160-ac97.c b/drivers/media/usb/stk1160/stk1160-ac97.c
index c46c8be89602..2dd308f9541f 100644
--- a/drivers/media/usb/stk1160/stk1160-ac97.c
+++ b/drivers/media/usb/stk1160/stk1160-ac97.c
@@ -108,7 +108,7 @@ int stk1160_ac97_register(struct stk1160 *dev)
"stk1160-mixer");
snprintf(card->longname, sizeof(card->longname),
"stk1160 ac97 codec mixer control");
- strncpy(card->driver, dev->dev->driver->name, sizeof(card->driver));
+ strlcpy(card->driver, dev->dev->driver->name, sizeof(card->driver));
rc = snd_ac97_bus(card, 0, &stk1160_ac97_ops, NULL, &ac97_bus);
if (rc)
--
1.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [media] stk1160: warrant a NUL terminated string
2014-04-07 13:42 [PATCH] [media] stk1160: warrant a NUL terminated string Mauro Carvalho Chehab
@ 2014-04-07 13:45 ` Hans Verkuil
2014-04-07 15:08 ` Ezequiel Garcia
1 sibling, 0 replies; 3+ messages in thread
From: Hans Verkuil @ 2014-04-07 13:45 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Linux Media Mailing List, Mauro Carvalho Chehab
On 04/07/2014 03:42 PM, Mauro Carvalho Chehab wrote:
> strncpy() doesn't warrant a NUL terminated string. Use
> strlcpy() instead.
>
> Fixes Coverity bug CID#1195195.
>
> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
My good deed for the day:
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Regards,
Hans
> ---
> drivers/media/usb/stk1160/stk1160-ac97.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/stk1160/stk1160-ac97.c b/drivers/media/usb/stk1160/stk1160-ac97.c
> index c46c8be89602..2dd308f9541f 100644
> --- a/drivers/media/usb/stk1160/stk1160-ac97.c
> +++ b/drivers/media/usb/stk1160/stk1160-ac97.c
> @@ -108,7 +108,7 @@ int stk1160_ac97_register(struct stk1160 *dev)
> "stk1160-mixer");
> snprintf(card->longname, sizeof(card->longname),
> "stk1160 ac97 codec mixer control");
> - strncpy(card->driver, dev->dev->driver->name, sizeof(card->driver));
> + strlcpy(card->driver, dev->dev->driver->name, sizeof(card->driver));
>
> rc = snd_ac97_bus(card, 0, &stk1160_ac97_ops, NULL, &ac97_bus);
> if (rc)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [media] stk1160: warrant a NUL terminated string
2014-04-07 13:42 [PATCH] [media] stk1160: warrant a NUL terminated string Mauro Carvalho Chehab
2014-04-07 13:45 ` Hans Verkuil
@ 2014-04-07 15:08 ` Ezequiel Garcia
1 sibling, 0 replies; 3+ messages in thread
From: Ezequiel Garcia @ 2014-04-07 15:08 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Linux Media Mailing List, Mauro Carvalho Chehab
Cc: Hans Verkuil
On Apr 07, Mauro Carvalho Chehab wrote:
> strncpy() doesn't warrant a NUL terminated string. Use
> strlcpy() instead.
>
> Fixes Coverity bug CID#1195195.
>
> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
> ---
> drivers/media/usb/stk1160/stk1160-ac97.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/stk1160/stk1160-ac97.c b/drivers/media/usb/stk1160/stk1160-ac97.c
> index c46c8be89602..2dd308f9541f 100644
> --- a/drivers/media/usb/stk1160/stk1160-ac97.c
> +++ b/drivers/media/usb/stk1160/stk1160-ac97.c
> @@ -108,7 +108,7 @@ int stk1160_ac97_register(struct stk1160 *dev)
> "stk1160-mixer");
> snprintf(card->longname, sizeof(card->longname),
> "stk1160 ac97 codec mixer control");
> - strncpy(card->driver, dev->dev->driver->name, sizeof(card->driver));
> + strlcpy(card->driver, dev->dev->driver->name, sizeof(card->driver));
>
> rc = snd_ac97_bus(card, 0, &stk1160_ac97_ops, NULL, &ac97_bus);
> if (rc)
Shame on me.
Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-07 15:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-07 13:42 [PATCH] [media] stk1160: warrant a NUL terminated string Mauro Carvalho Chehab
2014-04-07 13:45 ` Hans Verkuil
2014-04-07 15:08 ` Ezequiel Garcia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).