* [GIT PULL] soc-camera: 1st set for 3.19
@ 2014-11-28 22:15 Guennadi Liakhovetski
2014-12-01 17:03 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 6+ messages in thread
From: Guennadi Liakhovetski @ 2014-11-28 22:15 UTC (permalink / raw)
To: Linux Media Mailing List
Hi Mauro,
IIUC, this coming Sunday might be the last -rc, so, postponing pull
requests to subsystem maintainers even further isn't a good idea, so, here
goes an soc-camera request. I know it isn't complete, there are a few more
patches waiting to be pushed upstream, but I won't have time this coming
weekend and next two weeks I'm traveling, which won't simplify things
either. Some more patches are being reworked, if they arrive soon and we
do get another -rc, I might try to push them too, but I don't want to
postpone these ones, while waiting. One of these patches has also been
modified by me and hasn't been tested yet. But changes weren't too
complex. If however I did break something, we'll have to fix it in an
incremental patch.
The following changes since commit d298a59791fad3a707c1dadbef0935ee2664a10e:
Merge branch 'patchwork' into to_next (2014-11-21 17:01:46 -0200)
are available in the git repository at:
git://linuxtv.org/gliakhovetski/v4l-dvb.git for-3.19-1
for you to fetch changes up to d8f5c144e57d99d2a7325bf8877812bf560e22dd:
rcar_vin: Fix interrupt enable in progressive (2014-11-23 12:08:19 +0100)
----------------------------------------------------------------
Koji Matsuoka (4):
rcar_vin: Add YUYV capture format support
rcar_vin: Add scaling support
rcar_vin: Enable VSYNC field toggle mode
rcar_vin: Fix interrupt enable in progressive
Yoshihiro Kaneko (1):
rcar_vin: Add DT support for r8a7793 and r8a7794 SoCs
.../devicetree/bindings/media/rcar_vin.txt | 2 +
drivers/media/platform/soc_camera/rcar_vin.c | 466 ++++++++++++++++++++-
2 files changed, 457 insertions(+), 11 deletions(-)
Thanks
Guennadi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [GIT PULL] soc-camera: 1st set for 3.19
2014-11-28 22:15 [GIT PULL] soc-camera: 1st set for 3.19 Guennadi Liakhovetski
@ 2014-12-01 17:03 ` Mauro Carvalho Chehab
2014-12-05 7:07 ` Guennadi Liakhovetski
0 siblings, 1 reply; 6+ messages in thread
From: Mauro Carvalho Chehab @ 2014-12-01 17:03 UTC (permalink / raw)
To: Guennadi Liakhovetski; +Cc: Linux Media Mailing List
Em Fri, 28 Nov 2014 23:15:32 +0100 (CET)
Guennadi Liakhovetski <g.liakhovetski@gmx.de> escreveu:
> Hi Mauro,
>
> IIUC, this coming Sunday might be the last -rc, so, postponing pull
> requests to subsystem maintainers even further isn't a good idea, so, here
> goes an soc-camera request. I know it isn't complete, there are a few more
> patches waiting to be pushed upstream, but I won't have time this coming
> weekend and next two weeks I'm traveling, which won't simplify things
> either. Some more patches are being reworked, if they arrive soon and we
> do get another -rc, I might try to push them too, but I don't want to
> postpone these ones, while waiting. One of these patches has also been
> modified by me and hasn't been tested yet. But changes weren't too
> complex. If however I did break something, we'll have to fix it in an
> incremental patch.
>
> The following changes since commit d298a59791fad3a707c1dadbef0935ee2664a10e:
>
> Merge branch 'patchwork' into to_next (2014-11-21 17:01:46 -0200)
>
> are available in the git repository at:
>
>
> git://linuxtv.org/gliakhovetski/v4l-dvb.git for-3.19-1
>
> for you to fetch changes up to d8f5c144e57d99d2a7325bf8877812bf560e22dd:
>
> rcar_vin: Fix interrupt enable in progressive (2014-11-23 12:08:19 +0100)
>
> ----------------------------------------------------------------
> Koji Matsuoka (4):
> rcar_vin: Add YUYV capture format support
> rcar_vin: Add scaling support
Hmm...
WARNING: DT compatible string "renesas,vin-r8a7794" appears un-documented -- check ./Documentation/devicetree/bindings/
#38: FILE: drivers/media/platform/soc_camera/rcar_vin.c:1406:
+ { .compatible = "renesas,vin-r8a7794", .data = (void *)RCAR_GEN2 },
WARNING: DT compatible string "renesas,vin-r8a7793" appears un-documented -- check ./Documentation/devicetree/bindings/
#39: FILE: drivers/media/platform/soc_camera/rcar_vin.c:1407:
+ { .compatible = "renesas,vin-r8a7793", .data = (void *)RCAR_GEN2 },
Where are the DT binding documentation for this?
You should be adding a patch to:
Documentation/devicetree/bindings/media/rcar_vin.txt
before this one.
> rcar_vin: Enable VSYNC field toggle mode
> rcar_vin: Fix interrupt enable in progressive
>
> Yoshihiro Kaneko (1):
> rcar_vin: Add DT support for r8a7793 and r8a7794 SoCs
>
> .../devicetree/bindings/media/rcar_vin.txt | 2 +
> drivers/media/platform/soc_camera/rcar_vin.c | 466 ++++++++++++++++++++-
> 2 files changed, 457 insertions(+), 11 deletions(-)
>
> Thanks
> Guennadi
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [GIT PULL] soc-camera: 1st set for 3.19
2014-12-01 17:03 ` Mauro Carvalho Chehab
@ 2014-12-05 7:07 ` Guennadi Liakhovetski
2014-12-05 8:42 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 6+ messages in thread
From: Guennadi Liakhovetski @ 2014-12-05 7:07 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Linux Media Mailing List
Hi Mauro,
On Mon, 1 Dec 2014, Mauro Carvalho Chehab wrote:
> Em Fri, 28 Nov 2014 23:15:32 +0100 (CET)
> Guennadi Liakhovetski <g.liakhovetski@gmx.de> escreveu:
>
> > Hi Mauro,
> >
> > IIUC, this coming Sunday might be the last -rc, so, postponing pull
> > requests to subsystem maintainers even further isn't a good idea, so, here
> > goes an soc-camera request. I know it isn't complete, there are a few more
> > patches waiting to be pushed upstream, but I won't have time this coming
> > weekend and next two weeks I'm traveling, which won't simplify things
> > either. Some more patches are being reworked, if they arrive soon and we
> > do get another -rc, I might try to push them too, but I don't want to
> > postpone these ones, while waiting. One of these patches has also been
> > modified by me and hasn't been tested yet. But changes weren't too
> > complex. If however I did break something, we'll have to fix it in an
> > incremental patch.
> >
> > The following changes since commit d298a59791fad3a707c1dadbef0935ee2664a10e:
> >
> > Merge branch 'patchwork' into to_next (2014-11-21 17:01:46 -0200)
> >
> > are available in the git repository at:
> >
> >
> > git://linuxtv.org/gliakhovetski/v4l-dvb.git for-3.19-1
> >
> > for you to fetch changes up to d8f5c144e57d99d2a7325bf8877812bf560e22dd:
> >
> > rcar_vin: Fix interrupt enable in progressive (2014-11-23 12:08:19 +0100)
> >
> > ----------------------------------------------------------------
> > Koji Matsuoka (4):
> > rcar_vin: Add YUYV capture format support
> > rcar_vin: Add scaling support
>
> Hmm...
>
> WARNING: DT compatible string "renesas,vin-r8a7794" appears un-documented -- check ./Documentation/devicetree/bindings/
> #38: FILE: drivers/media/platform/soc_camera/rcar_vin.c:1406:
> + { .compatible = "renesas,vin-r8a7794", .data = (void *)RCAR_GEN2 },
>
> WARNING: DT compatible string "renesas,vin-r8a7793" appears un-documented -- check ./Documentation/devicetree/bindings/
> #39: FILE: drivers/media/platform/soc_camera/rcar_vin.c:1407:
> + { .compatible = "renesas,vin-r8a7793", .data = (void *)RCAR_GEN2 },
>
> Where are the DT binding documentation for this?
>
> You should be adding a patch to:
> Documentation/devicetree/bindings/media/rcar_vin.txt
> before this one.
Sure, documentation is in the same patch
http://git.linuxtv.org/cgit.cgi/gliakhovetski/v4l-dvb.git/commit/?h=for-3.19-1&id=aa1f7651acbe222948f43e239eda15362c9e274c
Is it because you cannot push it via your tree or what's happened, why
this warning?
Thanks
Guennadi
>
>
>
> > rcar_vin: Enable VSYNC field toggle mode
> > rcar_vin: Fix interrupt enable in progressive
> >
> > Yoshihiro Kaneko (1):
> > rcar_vin: Add DT support for r8a7793 and r8a7794 SoCs
> >
> > .../devicetree/bindings/media/rcar_vin.txt | 2 +
> > drivers/media/platform/soc_camera/rcar_vin.c | 466 ++++++++++++++++++++-
> > 2 files changed, 457 insertions(+), 11 deletions(-)
> >
> > Thanks
> > Guennadi
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-media" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [GIT PULL] soc-camera: 1st set for 3.19
2014-12-05 7:07 ` Guennadi Liakhovetski
@ 2014-12-05 8:42 ` Mauro Carvalho Chehab
2014-12-05 14:53 ` Guennadi Liakhovetski
0 siblings, 1 reply; 6+ messages in thread
From: Mauro Carvalho Chehab @ 2014-12-05 8:42 UTC (permalink / raw)
To: Guennadi Liakhovetski; +Cc: Linux Media Mailing List
Em Fri, 05 Dec 2014 08:07:07 +0100
Guennadi Liakhovetski <g.liakhovetski@gmx.de> escreveu:
> Hi Mauro,
>
> On Mon, 1 Dec 2014, Mauro Carvalho Chehab wrote:
>
> > Em Fri, 28 Nov 2014 23:15:32 +0100 (CET)
> > Guennadi Liakhovetski <g.liakhovetski@gmx.de> escreveu:
> >
> > > Hi Mauro,
> > >
> > > IIUC, this coming Sunday might be the last -rc, so, postponing pull
> > > requests to subsystem maintainers even further isn't a good idea, so, here
> > > goes an soc-camera request. I know it isn't complete, there are a few more
> > > patches waiting to be pushed upstream, but I won't have time this coming
> > > weekend and next two weeks I'm traveling, which won't simplify things
> > > either. Some more patches are being reworked, if they arrive soon and we
> > > do get another -rc, I might try to push them too, but I don't want to
> > > postpone these ones, while waiting. One of these patches has also been
> > > modified by me and hasn't been tested yet. But changes weren't too
> > > complex. If however I did break something, we'll have to fix it in an
> > > incremental patch.
> > >
> > > The following changes since commit d298a59791fad3a707c1dadbef0935ee2664a10e:
> > >
> > > Merge branch 'patchwork' into to_next (2014-11-21 17:01:46 -0200)
> > >
> > > are available in the git repository at:
> > >
> > >
> > > git://linuxtv.org/gliakhovetski/v4l-dvb.git for-3.19-1
> > >
> > > for you to fetch changes up to d8f5c144e57d99d2a7325bf8877812bf560e22dd:
> > >
> > > rcar_vin: Fix interrupt enable in progressive (2014-11-23 12:08:19 +0100)
> > >
> > > ----------------------------------------------------------------
> > > Koji Matsuoka (4):
> > > rcar_vin: Add YUYV capture format support
> > > rcar_vin: Add scaling support
> >
> > Hmm...
> >
> > WARNING: DT compatible string "renesas,vin-r8a7794" appears un-documented -- check ./Documentation/devicetree/bindings/
> > #38: FILE: drivers/media/platform/soc_camera/rcar_vin.c:1406:
> > + { .compatible = "renesas,vin-r8a7794", .data = (void *)RCAR_GEN2 },
> >
> > WARNING: DT compatible string "renesas,vin-r8a7793" appears un-documented -- check ./Documentation/devicetree/bindings/
> > #39: FILE: drivers/media/platform/soc_camera/rcar_vin.c:1407:
> > + { .compatible = "renesas,vin-r8a7793", .data = (void *)RCAR_GEN2 },
> >
> > Where are the DT binding documentation for this?
> >
> > You should be adding a patch to:
> > Documentation/devicetree/bindings/media/rcar_vin.txt
> > before this one.
>
> Sure, documentation is in the same patch
>
> http://git.linuxtv.org/cgit.cgi/gliakhovetski/v4l-dvb.git/commit/?h=for-3.19-1&id=aa1f7651acbe222948f43e239eda15362c9e274c
>
> Is it because you cannot push it via your tree or what's happened, why
> this warning?
I see. It seems that you've added the documentation changes after the
patch using it. As I run checkpatch patch by patch, at the same order
as they're found at the tree, checkpatch complained.
Unofortunately, you answered too late. I closed the final set of patches
to 3.19 yesterday. I won't be able to handle it today, and I'll be traveling
all weekend, without access to my build server.
Cheers,
Mauro
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [GIT PULL] soc-camera: 1st set for 3.19
2014-12-05 8:42 ` Mauro Carvalho Chehab
@ 2014-12-05 14:53 ` Guennadi Liakhovetski
2014-12-12 12:33 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 6+ messages in thread
From: Guennadi Liakhovetski @ 2014-12-05 14:53 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Linux Media Mailing List
Hi Mauro,
On Fri, 5 Dec 2014, Mauro Carvalho Chehab wrote:
> Em Fri, 05 Dec 2014 08:07:07 +0100
> Guennadi Liakhovetski <g.liakhovetski@gmx.de> escreveu:
>
> > Hi Mauro,
> >
> > On Mon, 1 Dec 2014, Mauro Carvalho Chehab wrote:
> >
> > > Em Fri, 28 Nov 2014 23:15:32 +0100 (CET)
> > > Guennadi Liakhovetski <g.liakhovetski@gmx.de> escreveu:
> > >
> > > > Hi Mauro,
> > > >
> > > > IIUC, this coming Sunday might be the last -rc, so, postponing pull
> > > > requests to subsystem maintainers even further isn't a good idea, so, here
> > > > goes an soc-camera request. I know it isn't complete, there are a few more
> > > > patches waiting to be pushed upstream, but I won't have time this coming
> > > > weekend and next two weeks I'm traveling, which won't simplify things
> > > > either. Some more patches are being reworked, if they arrive soon and we
> > > > do get another -rc, I might try to push them too, but I don't want to
> > > > postpone these ones, while waiting. One of these patches has also been
> > > > modified by me and hasn't been tested yet. But changes weren't too
> > > > complex. If however I did break something, we'll have to fix it in an
> > > > incremental patch.
> > > >
> > > > The following changes since commit d298a59791fad3a707c1dadbef0935ee2664a10e:
> > > >
> > > > Merge branch 'patchwork' into to_next (2014-11-21 17:01:46 -0200)
> > > >
> > > > are available in the git repository at:
> > > >
> > > >
> > > > git://linuxtv.org/gliakhovetski/v4l-dvb.git for-3.19-1
> > > >
> > > > for you to fetch changes up to d8f5c144e57d99d2a7325bf8877812bf560e22dd:
> > > >
> > > > rcar_vin: Fix interrupt enable in progressive (2014-11-23 12:08:19 +0100)
> > > >
> > > > ----------------------------------------------------------------
> > > > Koji Matsuoka (4):
> > > > rcar_vin: Add YUYV capture format support
> > > > rcar_vin: Add scaling support
> > >
> > > Hmm...
> > >
> > > WARNING: DT compatible string "renesas,vin-r8a7794" appears un-documented -- check ./Documentation/devicetree/bindings/
> > > #38: FILE: drivers/media/platform/soc_camera/rcar_vin.c:1406:
> > > + { .compatible = "renesas,vin-r8a7794", .data = (void *)RCAR_GEN2 },
> > >
> > > WARNING: DT compatible string "renesas,vin-r8a7793" appears un-documented -- check ./Documentation/devicetree/bindings/
> > > #39: FILE: drivers/media/platform/soc_camera/rcar_vin.c:1407:
> > > + { .compatible = "renesas,vin-r8a7793", .data = (void *)RCAR_GEN2 },
> > >
> > > Where are the DT binding documentation for this?
> > >
> > > You should be adding a patch to:
> > > Documentation/devicetree/bindings/media/rcar_vin.txt
> > > before this one.
> >
> > Sure, documentation is in the same patch
> >
> > http://git.linuxtv.org/cgit.cgi/gliakhovetski/v4l-dvb.git/commit/?h=for-3.19-1&id=aa1f7651acbe222948f43e239eda15362c9e274c
> >
> > Is it because you cannot push it via your tree or what's happened, why
> > this warning?
>
> I see. It seems that you've added the documentation changes after the
> patch using it. As I run checkpatch patch by patch, at the same order
> as they're found at the tree, checkpatch complained.
It's not after, it is added in that very same patch. And I do remember a
discussion, where I was told, that it's up to specific maintainers,
whether to accept patches, adding DT properties and documentation together
or only separately. Now once again checkpatch has singlehandedly decided
this for us... It's really becoming kernel's blind police.
> Unofortunately, you answered too late. I closed the final set of patches
> to 3.19 yesterday. I won't be able to handle it today, and I'll be traveling
> all weekend, without access to my build server.
IC, it's a pity, yes.
Thanks
Guennadi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [GIT PULL] soc-camera: 1st set for 3.19
2014-12-05 14:53 ` Guennadi Liakhovetski
@ 2014-12-12 12:33 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 6+ messages in thread
From: Mauro Carvalho Chehab @ 2014-12-12 12:33 UTC (permalink / raw)
To: Guennadi Liakhovetski; +Cc: Linux Media Mailing List
Em Fri, 05 Dec 2014 15:53:11 +0100
Guennadi Liakhovetski <g.liakhovetski@gmx.de> escreveu:
> Hi Mauro,
>
> On Fri, 5 Dec 2014, Mauro Carvalho Chehab wrote:
>
> > Em Fri, 05 Dec 2014 08:07:07 +0100
> > Guennadi Liakhovetski <g.liakhovetski@gmx.de> escreveu:
> >
> > > Hi Mauro,
> > >
> > > On Mon, 1 Dec 2014, Mauro Carvalho Chehab wrote:
> > >
> > > > Em Fri, 28 Nov 2014 23:15:32 +0100 (CET)
> > > > Guennadi Liakhovetski <g.liakhovetski@gmx.de> escreveu:
> > > >
> > > > > Hi Mauro,
> > > > >
> > > > > IIUC, this coming Sunday might be the last -rc, so, postponing pull
> > > > > requests to subsystem maintainers even further isn't a good idea, so, here
> > > > > goes an soc-camera request. I know it isn't complete, there are a few more
> > > > > patches waiting to be pushed upstream, but I won't have time this coming
> > > > > weekend and next two weeks I'm traveling, which won't simplify things
> > > > > either. Some more patches are being reworked, if they arrive soon and we
> > > > > do get another -rc, I might try to push them too, but I don't want to
> > > > > postpone these ones, while waiting. One of these patches has also been
> > > > > modified by me and hasn't been tested yet. But changes weren't too
> > > > > complex. If however I did break something, we'll have to fix it in an
> > > > > incremental patch.
> > > > >
> > > > > The following changes since commit d298a59791fad3a707c1dadbef0935ee2664a10e:
> > > > >
> > > > > Merge branch 'patchwork' into to_next (2014-11-21 17:01:46 -0200)
> > > > >
> > > > > are available in the git repository at:
> > > > >
> > > > >
> > > > > git://linuxtv.org/gliakhovetski/v4l-dvb.git for-3.19-1
> > > > >
> > > > > for you to fetch changes up to d8f5c144e57d99d2a7325bf8877812bf560e22dd:
> > > > >
> > > > > rcar_vin: Fix interrupt enable in progressive (2014-11-23 12:08:19 +0100)
> > > > >
> > > > > ----------------------------------------------------------------
> > > > > Koji Matsuoka (4):
> > > > > rcar_vin: Add YUYV capture format support
> > > > > rcar_vin: Add scaling support
> > > >
> > > > Hmm...
> > > >
> > > > WARNING: DT compatible string "renesas,vin-r8a7794" appears un-documented -- check ./Documentation/devicetree/bindings/
> > > > #38: FILE: drivers/media/platform/soc_camera/rcar_vin.c:1406:
> > > > + { .compatible = "renesas,vin-r8a7794", .data = (void *)RCAR_GEN2 },
> > > >
> > > > WARNING: DT compatible string "renesas,vin-r8a7793" appears un-documented -- check ./Documentation/devicetree/bindings/
> > > > #39: FILE: drivers/media/platform/soc_camera/rcar_vin.c:1407:
> > > > + { .compatible = "renesas,vin-r8a7793", .data = (void *)RCAR_GEN2 },
> > > >
> > > > Where are the DT binding documentation for this?
> > > >
> > > > You should be adding a patch to:
> > > > Documentation/devicetree/bindings/media/rcar_vin.txt
> > > > before this one.
> > >
> > > Sure, documentation is in the same patch
> > >
> > > http://git.linuxtv.org/cgit.cgi/gliakhovetski/v4l-dvb.git/commit/?h=for-3.19-1&id=aa1f7651acbe222948f43e239eda15362c9e274c
> > >
> > > Is it because you cannot push it via your tree or what's happened, why
> > > this warning?
> >
> > I see. It seems that you've added the documentation changes after the
> > patch using it. As I run checkpatch patch by patch, at the same order
> > as they're found at the tree, checkpatch complained.
>
> It's not after, it is added in that very same patch.
Yeah, right. It seems to be a checkpatch bug. You should be reporting it
to checkpatch maintainers.
> And I do remember a
> discussion, where I was told, that it's up to specific maintainers,
> whether to accept patches, adding DT properties and documentation together
> or only separately. Now once again checkpatch has singlehandedly decided
> this for us... It's really becoming kernel's blind police.
It is not a kernel's blind police, but a bug at the tool. As I told
you, if you replied earlier, I would be able to send this together
with the pull request.
Anyway, I'm planning to send a late pull request moving some really old
drivers to staging. If I end by doing that, I'll add your patches at
the late pull request.
I reviewed the series already, and it looks good.
>
> > Unofortunately, you answered too late. I closed the final set of patches
> > to 3.19 yesterday. I won't be able to handle it today, and I'll be traveling
> > all weekend, without access to my build server.
>
> IC, it's a pity, yes.
>
> Thanks
> Guennadi
Regards,
Mauro
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-12-12 12:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-28 22:15 [GIT PULL] soc-camera: 1st set for 3.19 Guennadi Liakhovetski
2014-12-01 17:03 ` Mauro Carvalho Chehab
2014-12-05 7:07 ` Guennadi Liakhovetski
2014-12-05 8:42 ` Mauro Carvalho Chehab
2014-12-05 14:53 ` Guennadi Liakhovetski
2014-12-12 12:33 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).