From: Rob Herring <robh@kernel.org>
To: Todor Tomov <todor.tomov@linaro.org>
Cc: pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
devicetree@vger.kernel.org, mchehab@osg.samsung.com,
hverkuil@xs4all.nl, geert@linux-m68k.org, matrandg@cisco.com,
linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH v2 1/2] [media] media: i2c/ov5645: add the device tree binding document
Date: Wed, 18 May 2016 18:16:37 -0500 [thread overview]
Message-ID: <20160518231637.GA31413@rob-hp-laptop> (raw)
In-Reply-To: <1463572208-8826-2-git-send-email-todor.tomov@linaro.org>
On Wed, May 18, 2016 at 02:50:07PM +0300, Todor Tomov wrote:
> Add the document for ov5645 device tree binding.
>
> Signed-off-by: Todor Tomov <todor.tomov@linaro.org>
> ---
> .../devicetree/bindings/media/i2c/ov5645.txt | 56 ++++++++++++++++++++++
> 1 file changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5645.txt
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov5645.txt b/Documentation/devicetree/bindings/media/i2c/ov5645.txt
> new file mode 100644
> index 0000000..8799000
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ov5645.txt
> @@ -0,0 +1,56 @@
> +* Omnivision 1/4-Inch 5Mp CMOS Digital Image Sensor
> +
> +The Omnivision OV5645 is a 1/4-Inch CMOS active pixel digital image sensor with
> +an active array size of 2592H x 1944V. It is programmable through a serial SCCB
s/SCCB/I2C/ because that is the more common name.
> +interface.
> +
> +Required Properties:
> +- compatible: value should be "ovti,ov5645"
> +- clocks: reference to the xclk clock
> +- clock-names: should be "xclk"
> +- assigned-clocks: reference to the xclk clock
This should be optional as it only makes sense if there is more than one
option.
> +- assigned-clock-rates: should be "23880000"
Doesn't this depend on the board? Most parts take a range of
frequencies. The driver should know what the range is and request a rate
within this range.
> +
> +Optional Properties:
> +- reset-gpios: Chip reset GPIO
> +- pwdn-gpios: Chip power down GPIO
Use enable-gpios as it is more common and would just be the inverse of
this.
Both need to specify the polarity.
> +- dovdd-supply: Chip IO regulator
> +- dvdd-supply: Chip core regulator
> +- avdd-supply: Chip analog regulator
> +
> +The device node must contain one 'port' child node for its digital output
> +video port, in accordance with the video interface bindings defined in
> +Documentation/devicetree/bindings/media/video-interfaces.txt.
next prev parent reply other threads:[~2016-05-18 23:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 11:50 [PATCH v2 0/2] OV5645 camera sensor driver Todor Tomov
2016-05-18 11:50 ` [PATCH v2 1/2] [media] media: i2c/ov5645: add the device tree binding document Todor Tomov
2016-05-18 23:16 ` Rob Herring [this message]
2016-05-19 8:14 ` Todor Tomov
2016-05-20 0:16 ` Rob Herring
2016-05-20 8:20 ` Todor Tomov
2016-05-18 11:50 ` [PATCH v2 2/2] media: Add a driver for the ov5645 camera sensor Todor Tomov
2016-05-20 15:20 ` Stanimir Varbanov
2016-05-27 11:59 ` Todor Tomov
2016-05-23 10:36 ` Hans Verkuil
2016-05-26 8:55 ` Todor Tomov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160518231637.GA31413@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=geert@linux-m68k.org \
--cc=hverkuil@xs4all.nl \
--cc=ijc+devicetree@hellion.org.uk \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matrandg@cisco.com \
--cc=mchehab@osg.samsung.com \
--cc=pawel.moll@arm.com \
--cc=todor.tomov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).