From: Todor Tomov <todor.tomov@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Geert Uytterhoeven <geert@linux-m68k.org>,
matrandg@cisco.com,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v2 1/2] [media] media: i2c/ov5645: add the device tree binding document
Date: Fri, 20 May 2016 11:20:59 +0300 [thread overview]
Message-ID: <573EC8EB.2010102@linaro.org> (raw)
In-Reply-To: <CAL_JsqJX_t9WD0gq=5A1UFQiweKi8fwjBwTdpxbV=ECTsHWOvw@mail.gmail.com>
On 05/20/2016 03:16 AM, Rob Herring wrote:
> On Thu, May 19, 2016 at 3:14 AM, Todor Tomov <todor.tomov@linaro.org> wrote:
>> Hi Rob,
>>
>> Thank you for your time to review. My responses are below:
>>
>> On 05/19/2016 02:16 AM, Rob Herring wrote:
>>> On Wed, May 18, 2016 at 02:50:07PM +0300, Todor Tomov wrote:
>>>> Add the document for ov5645 device tree binding.
>>>>
>>>> Signed-off-by: Todor Tomov <todor.tomov@linaro.org>
>>>> ---
>>>> .../devicetree/bindings/media/i2c/ov5645.txt | 56 ++++++++++++++++++++++
>>>> 1 file changed, 56 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5645.txt
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/media/i2c/ov5645.txt b/Documentation/devicetree/bindings/media/i2c/ov5645.txt
>>>> new file mode 100644
>>>> index 0000000..8799000
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/media/i2c/ov5645.txt
>>>> @@ -0,0 +1,56 @@
>>>> +* Omnivision 1/4-Inch 5Mp CMOS Digital Image Sensor
>>>> +
>>>> +The Omnivision OV5645 is a 1/4-Inch CMOS active pixel digital image sensor with
>>>> +an active array size of 2592H x 1944V. It is programmable through a serial SCCB
>>>
>>> s/SCCB/I2C/ because that is the more common name.
>> Ok.
>>
>>>
>>>> +interface.
>>>> +
>>>> +Required Properties:
>>>> +- compatible: value should be "ovti,ov5645"
>>>> +- clocks: reference to the xclk clock
>>>> +- clock-names: should be "xclk"
>>>> +- assigned-clocks: reference to the xclk clock
>>>
>>> This should be optional as it only makes sense if there is more than one
>>> option.
>> I have only used assigned-clocks to specify for which clock the
>> assigned-clock-rates property is. This is the way I understood it.
>> Isn't this correct? (Also please see below.)
>
> AIUI, assigned-clocks is which parent you want to assign for the clock
> specified in "clocks". Whether you have a parent option or not is
> board/chip dependent.
>
>>>> +- assigned-clock-rates: should be "23880000"
>>>
>>> Doesn't this depend on the board? Most parts take a range of
>>> frequencies. The driver should know what the range is and request a rate
>>> within this range.
>> This is the sensor external clock. Actually the driver depends on this value -
>> the sensor mode settings which the driver configures are calculated based on
>> this value. If you change this clock rate you need to change the sensor mode
>> settings. However they usually come from the vendor of the sensor so they
>> usually never change. So this clock rate for this driver is fixed to 23.88MHz
>> and is not expected to change.
>
> If fixed in the driver, then it doesn't need to be in DT.
Ok, I'll remove these two and leave the external clock value in the driver.
>
>>>> +
>>>> +Optional Properties:
>>>> +- reset-gpios: Chip reset GPIO
>>>> +- pwdn-gpios: Chip power down GPIO
>>>
>>> Use enable-gpios as it is more common and would just be the inverse of
>>> this.
>> pwdn is the notation which OV use for this gpio, so I'd personally prefer
>> to keep the name. Do you think it is still better to change it?
>
> Yes.
Ok, I'll change it to enable-gpios. Thanks.
>
> Rob
>
--
Best regards,
Todor Tomov
next prev parent reply other threads:[~2016-05-20 8:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 11:50 [PATCH v2 0/2] OV5645 camera sensor driver Todor Tomov
2016-05-18 11:50 ` [PATCH v2 1/2] [media] media: i2c/ov5645: add the device tree binding document Todor Tomov
2016-05-18 23:16 ` Rob Herring
2016-05-19 8:14 ` Todor Tomov
2016-05-20 0:16 ` Rob Herring
2016-05-20 8:20 ` Todor Tomov [this message]
2016-05-18 11:50 ` [PATCH v2 2/2] media: Add a driver for the ov5645 camera sensor Todor Tomov
2016-05-20 15:20 ` Stanimir Varbanov
2016-05-27 11:59 ` Todor Tomov
2016-05-23 10:36 ` Hans Verkuil
2016-05-26 8:55 ` Todor Tomov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573EC8EB.2010102@linaro.org \
--to=todor.tomov@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=geert@linux-m68k.org \
--cc=hverkuil@xs4all.nl \
--cc=ijc+devicetree@hellion.org.uk \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matrandg@cisco.com \
--cc=mchehab@osg.samsung.com \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).