linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] [v4l-utils] libdvb5: Fix multiple definition of dvb_dev_remote_init linking error
@ 2016-09-07  9:53 Laurent Pinchart
  2016-09-09 10:37 ` Sakari Ailus
  0 siblings, 1 reply; 2+ messages in thread
From: Laurent Pinchart @ 2016-09-07  9:53 UTC (permalink / raw)
  To: linux-media; +Cc: Mauro Carvalho Chehab

The function is defined in a header file when HAVE_DVBV5_REMOTE is not
set. It needs to be marked as static inline.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 lib/include/libdvbv5/dvb-dev.h | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lib/include/libdvbv5/dvb-dev.h b/lib/include/libdvbv5/dvb-dev.h
index da42671143a5..02b87016a3d3 100644
--- a/lib/include/libdvbv5/dvb-dev.h
+++ b/lib/include/libdvbv5/dvb-dev.h
@@ -449,8 +449,11 @@ int dvb_dev_remote_init(struct dvb_device *d, char *server, int port);
 
 #else
 
-int dvb_dev_remote_init(struct dvb_device *d, char *server, int port)
-{ return -1; };
+static inline int dvb_dev_remote_init(struct dvb_device *d, char *server,
+				      int port)
+{
+	return -1;
+};
 
 #endif
 
-- 
Regards,

Laurent Pinchart


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] [v4l-utils] libdvb5: Fix multiple definition of dvb_dev_remote_init linking error
  2016-09-07  9:53 [PATCH] [v4l-utils] libdvb5: Fix multiple definition of dvb_dev_remote_init linking error Laurent Pinchart
@ 2016-09-09 10:37 ` Sakari Ailus
  0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2016-09-09 10:37 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: linux-media, Mauro Carvalho Chehab

On Wed, Sep 07, 2016 at 12:53:26PM +0300, Laurent Pinchart wrote:
> The function is defined in a header file when HAVE_DVBV5_REMOTE is not
> set. It needs to be marked as static inline.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Applied. Thank you.

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-09 10:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-07  9:53 [PATCH] [v4l-utils] libdvb5: Fix multiple definition of dvb_dev_remote_init linking error Laurent Pinchart
2016-09-09 10:37 ` Sakari Ailus

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).