* [PATCH] Staging: media: lirc: style fix, using octal file permissions
@ 2017-01-07 3:02 Derek Robson
2017-01-30 17:10 ` Sean Young
0 siblings, 1 reply; 2+ messages in thread
From: Derek Robson @ 2017-01-07 3:02 UTC (permalink / raw)
To: mchehab; +Cc: gregkh, linux-media, devel, linux-kernel, Derek Robson
Change file permissions to octal style.
Found using checkpatch
Signed-off-by: Derek Robson <robsonde@gmail.com>
---
drivers/staging/media/lirc/lirc_imon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c
index 1e650fba4a92..6c8a4a15278e 100644
--- a/drivers/staging/media/lirc/lirc_imon.c
+++ b/drivers/staging/media/lirc/lirc_imon.c
@@ -182,7 +182,7 @@ MODULE_DESCRIPTION(MOD_DESC);
MODULE_VERSION(MOD_VERSION);
MODULE_LICENSE("GPL");
MODULE_DEVICE_TABLE(usb, imon_usb_id_table);
-module_param(debug, int, S_IRUGO | S_IWUSR);
+module_param(debug, int, 0644);
MODULE_PARM_DESC(debug, "Debug messages: 0=no, 1=yes(default: no)");
static void free_imon_context(struct imon_context *context)
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: media: lirc: style fix, using octal file permissions
2017-01-07 3:02 [PATCH] Staging: media: lirc: style fix, using octal file permissions Derek Robson
@ 2017-01-30 17:10 ` Sean Young
0 siblings, 0 replies; 2+ messages in thread
From: Sean Young @ 2017-01-30 17:10 UTC (permalink / raw)
To: Derek Robson; +Cc: mchehab, gregkh, linux-media, devel, linux-kernel
On Sat, Jan 07, 2017 at 04:02:55PM +1300, Derek Robson wrote:
> Change file permissions to octal style.
> Found using checkpatch
>
> Signed-off-by: Derek Robson <robsonde@gmail.com>
> ---
> drivers/staging/media/lirc/lirc_imon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c
> index 1e650fba4a92..6c8a4a15278e 100644
> --- a/drivers/staging/media/lirc/lirc_imon.c
> +++ b/drivers/staging/media/lirc/lirc_imon.c
> @@ -182,7 +182,7 @@ MODULE_DESCRIPTION(MOD_DESC);
> MODULE_VERSION(MOD_VERSION);
> MODULE_LICENSE("GPL");
> MODULE_DEVICE_TABLE(usb, imon_usb_id_table);
> -module_param(debug, int, S_IRUGO | S_IWUSR);
> +module_param(debug, int, 0644);
> MODULE_PARM_DESC(debug, "Debug messages: 0=no, 1=yes(default: no)");
>
> static void free_imon_context(struct imon_context *context)
In the current media tree, drivers/staging/media/lirc/lirc_imon.c has
been merged with drivers/media/rc/imon.c already, I'm afraid. This
patch no longer applies.
Sean
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-30 17:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-07 3:02 [PATCH] Staging: media: lirc: style fix, using octal file permissions Derek Robson
2017-01-30 17:10 ` Sean Young
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).