* [PATCH 1/3] [media] soc-camera: ov5642: Add OF device ID table
@ 2017-02-22 16:11 Javier Martinez Canillas
2017-02-22 16:11 ` [PATCH 2/3] [media] tc358743: " Javier Martinez Canillas
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2017-02-22 16:11 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Mauro Carvalho Chehab,
Guennadi Liakhovetski, linux-media
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.
But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/media/i2c/soc_camera/ov5642.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/media/i2c/soc_camera/ov5642.c b/drivers/media/i2c/soc_camera/ov5642.c
index 3d185bd622a3..1926f382dfce 100644
--- a/drivers/media/i2c/soc_camera/ov5642.c
+++ b/drivers/media/i2c/soc_camera/ov5642.c
@@ -1063,9 +1063,18 @@ static const struct i2c_device_id ov5642_id[] = {
};
MODULE_DEVICE_TABLE(i2c, ov5642_id);
+#if IS_ENABLED(CONFIG_OF)
+static const struct of_device_id ov5642_of_match[] = {
+ { .compatible = "ovti,ov5642" },
+ { },
+};
+MODULE_DEVICE_TABLE(of, ov5642_of_match);
+#endif
+
static struct i2c_driver ov5642_i2c_driver = {
.driver = {
.name = "ov5642",
+ .of_match_table = of_match_ptr(ov5642_of_match),
},
.probe = ov5642_probe,
.remove = ov5642_remove,
--
2.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/3] [media] tc358743: Add OF device ID table
2017-02-22 16:11 [PATCH 1/3] [media] soc-camera: ov5642: Add OF device ID table Javier Martinez Canillas
@ 2017-02-22 16:11 ` Javier Martinez Canillas
2017-02-22 20:11 ` Mats Randgaard (matrandg)
2017-02-22 16:11 ` [PATCH 3/3] [media] si4713: " Javier Martinez Canillas
2017-02-26 19:56 ` [PATCH 1/3] [media] soc-camera: ov5642: " Guennadi Liakhovetski
2 siblings, 1 reply; 5+ messages in thread
From: Javier Martinez Canillas @ 2017-02-22 16:11 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Mats Randgaard, Mauro Carvalho Chehab,
linux-media
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.
But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/media/i2c/tc358743.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index f569a05fe105..76baf7a7bd57 100644
--- a/drivers/media/i2c/tc358743.c
+++ b/drivers/media/i2c/tc358743.c
@@ -1951,9 +1951,18 @@ static struct i2c_device_id tc358743_id[] = {
MODULE_DEVICE_TABLE(i2c, tc358743_id);
+#if IS_ENABLED(CONFIG_OF)
+static const struct of_device_id tc358743_of_match[] = {
+ { .compatible = "toshiba,tc358743" },
+ {},
+};
+MODULE_DEVICE_TABLE(of, tc358743_of_match);
+#endif
+
static struct i2c_driver tc358743_driver = {
.driver = {
.name = "tc358743",
+ .of_match_table = of_match_ptr(tc358743_of_match),
},
.probe = tc358743_probe,
.remove = tc358743_remove,
--
2.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/3] [media] si4713: Add OF device ID table
2017-02-22 16:11 [PATCH 1/3] [media] soc-camera: ov5642: Add OF device ID table Javier Martinez Canillas
2017-02-22 16:11 ` [PATCH 2/3] [media] tc358743: " Javier Martinez Canillas
@ 2017-02-22 16:11 ` Javier Martinez Canillas
2017-02-26 19:56 ` [PATCH 1/3] [media] soc-camera: ov5642: " Guennadi Liakhovetski
2 siblings, 0 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2017-02-22 16:11 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Mauro Carvalho Chehab, Sakari Ailus,
Eduardo Valentin, linux-media
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.
But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/media/radio/si4713/si4713.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/media/radio/si4713/si4713.c b/drivers/media/radio/si4713/si4713.c
index 60f026a58076..f4a53f1e856e 100644
--- a/drivers/media/radio/si4713/si4713.c
+++ b/drivers/media/radio/si4713/si4713.c
@@ -1656,9 +1656,18 @@ static const struct i2c_device_id si4713_id[] = {
};
MODULE_DEVICE_TABLE(i2c, si4713_id);
+#if IS_ENABLED(CONFIG_OF)
+static const struct of_device_id si4713_of_match[] = {
+ { .compatible = "silabs,si4713" },
+ { },
+};
+MODULE_DEVICE_TABLE(of, si4713_of_match);
+#endif
+
static struct i2c_driver si4713_i2c_driver = {
.driver = {
.name = "si4713",
+ .of_match_table = of_match_ptr(si4713_of_match),
},
.probe = si4713_probe,
.remove = si4713_remove,
--
2.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3] [media] tc358743: Add OF device ID table
2017-02-22 16:11 ` [PATCH 2/3] [media] tc358743: " Javier Martinez Canillas
@ 2017-02-22 20:11 ` Mats Randgaard (matrandg)
0 siblings, 0 replies; 5+ messages in thread
From: Mats Randgaard (matrandg) @ 2017-02-22 20:11 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, Mauro Carvalho Chehab, linux-media, Philipp Zabel
CC: Philipp Zabel who added device tree support to this driver
Regards,
Mats Randgaard
On 02/22/2017 05:11 PM, Javier Martinez Canillas wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
>
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> drivers/media/i2c/tc358743.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
> index f569a05fe105..76baf7a7bd57 100644
> --- a/drivers/media/i2c/tc358743.c
> +++ b/drivers/media/i2c/tc358743.c
> @@ -1951,9 +1951,18 @@ static struct i2c_device_id tc358743_id[] = {
>
> MODULE_DEVICE_TABLE(i2c, tc358743_id);
>
> +#if IS_ENABLED(CONFIG_OF)
> +static const struct of_device_id tc358743_of_match[] = {
> + { .compatible = "toshiba,tc358743" },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, tc358743_of_match);
> +#endif
> +
> static struct i2c_driver tc358743_driver = {
> .driver = {
> .name = "tc358743",
> + .of_match_table = of_match_ptr(tc358743_of_match),
> },
> .probe = tc358743_probe,
> .remove = tc358743_remove,
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3] [media] soc-camera: ov5642: Add OF device ID table
2017-02-22 16:11 [PATCH 1/3] [media] soc-camera: ov5642: Add OF device ID table Javier Martinez Canillas
2017-02-22 16:11 ` [PATCH 2/3] [media] tc358743: " Javier Martinez Canillas
2017-02-22 16:11 ` [PATCH 3/3] [media] si4713: " Javier Martinez Canillas
@ 2017-02-26 19:56 ` Guennadi Liakhovetski
2 siblings, 0 replies; 5+ messages in thread
From: Guennadi Liakhovetski @ 2017-02-26 19:56 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: linux-kernel, Mauro Carvalho Chehab, linux-media
On Wed, 22 Feb 2017, Javier Martinez Canillas wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
>
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
>
> drivers/media/i2c/soc_camera/ov5642.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/media/i2c/soc_camera/ov5642.c b/drivers/media/i2c/soc_camera/ov5642.c
> index 3d185bd622a3..1926f382dfce 100644
> --- a/drivers/media/i2c/soc_camera/ov5642.c
> +++ b/drivers/media/i2c/soc_camera/ov5642.c
> @@ -1063,9 +1063,18 @@ static const struct i2c_device_id ov5642_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, ov5642_id);
>
> +#if IS_ENABLED(CONFIG_OF)
> +static const struct of_device_id ov5642_of_match[] = {
> + { .compatible = "ovti,ov5642" },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, ov5642_of_match);
> +#endif
> +
> static struct i2c_driver ov5642_i2c_driver = {
> .driver = {
> .name = "ov5642",
> + .of_match_table = of_match_ptr(ov5642_of_match),
> },
> .probe = ov5642_probe,
> .remove = ov5642_remove,
> --
> 2.9.3
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-26 19:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-22 16:11 [PATCH 1/3] [media] soc-camera: ov5642: Add OF device ID table Javier Martinez Canillas
2017-02-22 16:11 ` [PATCH 2/3] [media] tc358743: " Javier Martinez Canillas
2017-02-22 20:11 ` Mats Randgaard (matrandg)
2017-02-22 16:11 ` [PATCH 3/3] [media] si4713: " Javier Martinez Canillas
2017-02-26 19:56 ` [PATCH 1/3] [media] soc-camera: ov5642: " Guennadi Liakhovetski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).