* [PATCH 0/2] stv{0910,6111} cosmetics
@ 2017-08-20 12:59 Daniel Scheller
2017-08-20 12:59 ` [PATCH 1/2] [media] dvb-frontends/stv0910: declare global list_head stvlist static Daniel Scheller
2017-08-20 12:59 ` [PATCH 2/2] [media] dvb-frontends/stv6111.c: return NULL instead of plain integer Daniel Scheller
0 siblings, 2 replies; 3+ messages in thread
From: Daniel Scheller @ 2017-08-20 12:59 UTC (permalink / raw)
To: linux-media, mchehab, mchehab; +Cc: jasmin
From: Daniel Scheller <d.scheller@gmx.net>
Two cosmetics for the two new demod/tuner drivers. The stv0910 patch is
a remainder/leftover from the cleanup and cosmetic series, originally
submitted by Colin King. The second one fixes a warning I noticed in
Hans' daily build log.
@Mauro: Together with [1] and [2], everything that cumulated over time
is done now, with the only thing remaining being the IOCTL stuff which
we need to discuss and finalise.
[1] https://patchwork.linuxtv.org/patch/43202/
[2] https://patchwork.linuxtv.org/patch/43350/
Daniel Scheller (2):
[media] dvb-frontends/stv0910: declare global list_head stvlist static
[media] dvb-frontends/stv6111.c: return NULL instead of plain integer
drivers/media/dvb-frontends/stv0910.c | 2 +-
drivers/media/dvb-frontends/stv6111.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.13.0
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 1/2] [media] dvb-frontends/stv0910: declare global list_head stvlist static
2017-08-20 12:59 [PATCH 0/2] stv{0910,6111} cosmetics Daniel Scheller
@ 2017-08-20 12:59 ` Daniel Scheller
2017-08-20 12:59 ` [PATCH 2/2] [media] dvb-frontends/stv6111.c: return NULL instead of plain integer Daniel Scheller
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Scheller @ 2017-08-20 12:59 UTC (permalink / raw)
To: linux-media, mchehab, mchehab; +Cc: jasmin, Colin Ian King
From: Daniel Scheller <d.scheller@gmx.net>
Cleans up smatch warning:
symbol 'stvlist' was not declared. Should it be static?
Patch originally submitted by Colin Ian King <colin.king@canonical.com>,
remainder after the merge of all other stv0910 fixes.
Cc: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
---
drivers/media/dvb-frontends/stv0910.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/stv0910.c b/drivers/media/dvb-frontends/stv0910.c
index d0a8ed36b899..d1ae9553f74c 100644
--- a/drivers/media/dvb-frontends/stv0910.c
+++ b/drivers/media/dvb-frontends/stv0910.c
@@ -34,7 +34,7 @@
#define BER_SRC_S 0x20
#define BER_SRC_S2 0x20
-LIST_HEAD(stvlist);
+static LIST_HEAD(stvlist);
enum receive_mode { RCVMODE_NONE, RCVMODE_DVBS, RCVMODE_DVBS2, RCVMODE_AUTO };
--
2.13.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 2/2] [media] dvb-frontends/stv6111.c: return NULL instead of plain integer
2017-08-20 12:59 [PATCH 0/2] stv{0910,6111} cosmetics Daniel Scheller
2017-08-20 12:59 ` [PATCH 1/2] [media] dvb-frontends/stv0910: declare global list_head stvlist static Daniel Scheller
@ 2017-08-20 12:59 ` Daniel Scheller
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Scheller @ 2017-08-20 12:59 UTC (permalink / raw)
To: linux-media, mchehab, mchehab; +Cc: jasmin
From: Daniel Scheller <d.scheller@gmx.net>
Fixes:
stv6111.c:665:24: warning: Using plain integer as NULL pointer
Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
---
drivers/media/dvb-frontends/stv6111.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/stv6111.c b/drivers/media/dvb-frontends/stv6111.c
index 9a59fa318207..e3e90070e293 100644
--- a/drivers/media/dvb-frontends/stv6111.c
+++ b/drivers/media/dvb-frontends/stv6111.c
@@ -669,7 +669,7 @@ struct dvb_frontend *stv6111_attach(struct dvb_frontend *fe,
fe->ops.i2c_gate_ctrl(fe, 0);
if (stat < 0) {
kfree(state);
- return 0;
+ return NULL;
}
fe->tuner_priv = state;
return fe;
--
2.13.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-20 12:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-20 12:59 [PATCH 0/2] stv{0910,6111} cosmetics Daniel Scheller
2017-08-20 12:59 ` [PATCH 1/2] [media] dvb-frontends/stv0910: declare global list_head stvlist static Daniel Scheller
2017-08-20 12:59 ` [PATCH 2/2] [media] dvb-frontends/stv6111.c: return NULL instead of plain integer Daniel Scheller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).