Re: [linux-sunxi] Cedrus driver

[Maxime Ripard <maxime.ripard@free-electrons.com>]

[-- Attachment #1: Type: text/plain, Size: 3766 bytes --]

Hi Thomas,

On Wed, Nov 29, 2017 at 04:36:01PM +0100, Thomas van Kleef wrote:
> > C) I'm not sure what you tried to do with the application of the
> >    request API patches (such as e1ca861c168f) but we want to have the
> >    whole commits in there, and not a patch adding all of them. This
> >    will make the work so much easier to rebase to a later version when
> >    some patches wouldn't have been merged and some would have.
> > 
> > D) Rebase :)
>
> Thank you. Giulio asked before if I could add a repo and commit the 
> patches so that is what I did. I will push a different code where the
> full history is present in commits.
> 
> So, I got it setup. As I did test it before on the slightly newer branch,
> I did not verify, again, if the video-decoder worked on this specific 
> state of the linux kernel, 4.14. But it should x:
> If you rather wait for me to tell if it work let me know, but we could do
> a pull request then again anyway.

Yeah, I'd rather wait for at least small test that the general case is
working.

> So here is the new pull-request
> The following changes since commit bebc6082da0a9f5d47a1ea2edc099bf671058bd4:
> 
>   Linux 4.14 (2017-11-12 10:46:13 -0800)
> 
> are available in the git repository at:
> 
>   https://github.com/thomas-vitsch/linux-a20-cedrus.git linux-sunxi-cedrus
> 
> for you to fetch changes up to 26701eca67a07ab002c7fd18038fa299b9589939:
> 
>   Fix the sun5i and sun8i dts files (2017-11-29 15:18:05 +0100)
> 
> ----------------------------------------------------------------
> Bob Ham (1):
>       sunxi-cedrus: Fix compilation errors from bad types under GCC 6.2
> 
> Florent Revest (8):
>       Both mainline and cedrus had added their own formats with both are added.
>       v4l: Add MPEG2 low-level decoder API control
>       v4l: Add MPEG4 low-level decoder API control
>       media: platform: Add Sunxi Cedrus decoder driver
>       sunxi-cedrus: Add a MPEG 2 codec
>       sunxi-cedrus: Add a MPEG 4 codec
>       sunxi-cedrus: Add device tree binding document
>       ARM: dts: sun5i: Use video-engine node
> 
> Hans Verkuil (15):
>       videodev2.h: add max_reqs to struct v4l2_query_ext_ctrl
>       videodev2.h: add request to v4l2_ext_controls
>       videodev2.h: add request field to v4l2_buffer.
>       vb2: add allow_requests flag
>       v4l2-ctrls: add request support
>       v4l2-ctrls: add function to apply a request.
>       v4l2-ctrls: implement delete request(s)
>       v4l2-ctrls: add VIDIOC_REQUEST_CMD
>       v4l2: add initial V4L2_REQ_CMD_QUEUE support
>       vb2: add helper function to queue request-specific buffer.
>       v4l2-device: keep track of registered video_devices
>       v4l2-device: add v4l2_device_req_queue
>       vivid: add request support for video capture.
>       v4l2-ctrls: add REQ_KEEP flag
>       Documentation: add v4l2-requests.txt
> 
> Icenowy Zheng (2):
>       sunxi-cedrus: add syscon support
>       ARM: dts: sun8i: add video engine support for A33
> 
> Thomas van Kleef (4):
>       Merged requests2 into linux 4.14
>       Fix merge error
>       Remove reject file from merge
>       Fix the sun5i and sun8i dts files

There's still two minor issues with your patches here.

Your SoB should contain your name only, so you should drop the Vitsch
Electronics part. And the patches that are fixing compilation issues
should be squashed in the patches that introduced the breakage in the
first place. So a01b8665802145f1180680b67e5e1d04f2050fe3 should be
merged with 1c735c83c68d54616503481b2796005f02930b85 for example.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]