From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Hugues Fruchet <hugues.fruchet@st.com>,
Steve Longerbeam <slongerbeam@gmail.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media <linux-media@vger.kernel.org>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Maxime Ripard <maxime.ripard@bootlin.com>
Subject: Re: [PATCH] media: dvbdev: fix building on ia64
Date: Wed, 7 Mar 2018 07:16:40 -0300 [thread overview]
Message-ID: <20180307071640.03b5ec00@vento.lan> (raw)
In-Reply-To: <CAOMZO5C5jSxwKMV0hZpA1emFW9ha8GN4XsTsdTfgPU4eJ44Ctw@mail.gmail.com>
Em Wed, 7 Mar 2018 06:47:14 -0300
Fabio Estevam <festevam@gmail.com> escreveu:
> Hi Mauro,
>
> On Wed, Mar 7, 2018 at 6:14 AM, Mauro Carvalho Chehab
> <mchehab@s-opensource.com> wrote:
> > Not sure why, but, on ia64, with Linaro's gcc 7.3 compiler,
> > using #ifdef (CONFIG_I2C) is not OK.
>
> Looking at the kbuild report the failure happens when CONFIG_I2C=m.
>
> IS_ENABLED() macro takes care of both built-in and module as it will expand to:
>
> #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
Ah, true! Yeah, I forgot that for tri-state vars, it should test for
_MODULE variant.
>
> and that's the reason why IS_ENABLE() fixes the build problem.
Thanks for reminding me.
Regards,
Mauro
next prev parent reply other threads:[~2018-03-07 10:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 9:14 [PATCH] media: dvbdev: fix building on ia64 Mauro Carvalho Chehab
2018-03-07 9:47 ` Fabio Estevam
2018-03-07 10:16 ` Mauro Carvalho Chehab [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-03-06 17:04 [PATCH] media: ov5640: fix get_/set_fmt colorspace related fields Hugues Fruchet
2018-03-07 8:13 ` Sakari Ailus
2018-03-07 9:51 ` Fabio Estevam
2018-03-07 11:28 ` Sakari Ailus
2018-03-08 8:48 ` Hugues FRUCHET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307071640.03b5ec00@vento.lan \
--to=mchehab@s-opensource.com \
--cc=benjamin.gaignard@linaro.org \
--cc=festevam@gmail.com \
--cc=hugues.fruchet@st.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=mchehab@kernel.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).