From: Sakari Ailus <sakari.ailus@iki.fi>
To: Fabio Estevam <festevam@gmail.com>
Cc: Hugues Fruchet <hugues.fruchet@st.com>,
Steve Longerbeam <slongerbeam@gmail.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media <linux-media@vger.kernel.org>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Maxime Ripard <maxime.ripard@bootlin.com>
Subject: Re: [PATCH] media: ov5640: fix get_/set_fmt colorspace related fields
Date: Wed, 7 Mar 2018 13:28:01 +0200 [thread overview]
Message-ID: <20180307112800.o3yhldl2xx75punp@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <CAOMZO5BEi_dWmerMx5i3UoWU_3G7m3kgUWyGu4LfNMdvWNF+pw@mail.gmail.com>
Hi Fabio,
On Wed, Mar 07, 2018 at 06:51:26AM -0300, Fabio Estevam wrote:
> Hi Sakari,
>
> On Wed, Mar 7, 2018 at 5:13 AM, Sakari Ailus <sakari.ailus@iki.fi> wrote:
>
> >> @@ -2497,16 +2504,22 @@ static int ov5640_probe(struct i2c_client *client,
> >> struct fwnode_handle *endpoint;
> >> struct ov5640_dev *sensor;
> >> int ret;
> >> + struct v4l2_mbus_framefmt *fmt;
> >
> > This one I'd arrange before ret. The local variable declarations should
> > generally look like a Christmas tree but upside down.
>
> It seems Mauro is not happy with reverse Christmas tree ordering:
> https://www.mail-archive.com/linux-media@vger.kernel.org/msg127221.html
There are other arguments supporting the change such as:
- alignment with the rest of the driver and
- putting similar definitions together (return value vs. pointers somewhere
else).
--
Regards,
Sakari Ailus
e-mail: sakari.ailus@iki.fi
next prev parent reply other threads:[~2018-03-07 11:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 17:04 [PATCH] media: ov5640: fix get_/set_fmt colorspace related fields Hugues Fruchet
2018-03-07 8:13 ` Sakari Ailus
2018-03-07 9:51 ` Fabio Estevam
2018-03-07 11:28 ` Sakari Ailus [this message]
2018-03-08 8:48 ` Hugues FRUCHET
2018-03-07 9:14 [PATCH] media: dvbdev: fix building on ia64 Mauro Carvalho Chehab
2018-03-07 9:47 ` Fabio Estevam
2018-03-07 10:16 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307112800.o3yhldl2xx75punp@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=benjamin.gaignard@linaro.org \
--cc=festevam@gmail.com \
--cc=hugues.fruchet@st.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=mchehab@kernel.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).