[PATCH 1/1] dw9807: Use the dongwoon,dw9807-vcm compatible string

[PATCH 1/1] dw9807: Use the dongwoon,dw9807-vcm compatible string

[Sakari Ailus]

The original dw9807 DT bindings patch proposed the dongwoon,dw9807
compatible string. However, the device also includes an EEPROM on a
different I²C address. Indicate that this is just the VCM part of the
entire device.

The EEPROM part is compatible with the at24c64 for read-only access, with
1 kiB page size.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
Hi Rob, others,

The original bindings were missing the EEPROM bit. This change recognises
it's there, and allows adding more elaborate support for it later on if
needed.

If this change is fine, I'll squash it to the original patches that are
not yet merged:

<URL:https://patchwork.linuxtv.org/patch/49613/>
<URL:https://patchwork.linuxtv.org/patch/49614/>

Thanks.

 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt | 2 +-
 drivers/media/i2c/dw9807.c                                      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt
index 0a1a860beaff..c4701f1eaaf6 100644
--- a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt
+++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt
@@ -5,5 +5,5 @@ controlling voice coil lenses.
 
 Mandatory properties:
 
-- compatible: "dongwoon,dw9807"
+- compatible: "dongwoon,dw9807-vcm"
 - reg: I2C slave address
diff --git a/drivers/media/i2c/dw9807.c b/drivers/media/i2c/dw9807.c
index 6ebb98717fb1..8ba3920b6e2f 100644
--- a/drivers/media/i2c/dw9807.c
+++ b/drivers/media/i2c/dw9807.c
@@ -302,7 +302,7 @@ static int  __maybe_unused dw9807_vcm_resume(struct device *dev)
 }
 
 static const struct of_device_id dw9807_of_table[] = {
-	{ .compatible = "dongwoon,dw9807" },
+	{ .compatible = "dongwoon,dw9807-vcm" },
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, dw9807_of_table);
-- 
2.11.0

Re: [PATCH 1/1] dw9807: Use the dongwoon,dw9807-vcm compatible string

[Rob Herring]

On Tue, May 29, 2018 at 03:25:54PM +0300, Sakari Ailus wrote:
> The original dw9807 DT bindings patch proposed the dongwoon,dw9807
> compatible string. However, the device also includes an EEPROM on a
> different I²C address. Indicate that this is just the VCM part of the
> entire device.
> 
> The EEPROM part is compatible with the at24c64 for read-only access, with
> 1 kiB page size.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> Hi Rob, others,
> 
> The original bindings were missing the EEPROM bit. This change recognises
> it's there, and allows adding more elaborate support for it later on if
> needed.
> 
> If this change is fine, I'll squash it to the original patches that are
> not yet merged:

Looks fine to me.

> 
> <URL:https://patchwork.linuxtv.org/patch/49613/>
> <URL:https://patchwork.linuxtv.org/patch/49614/>
> 
> Thanks.
> 
>  Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt | 2 +-
>  drivers/media/i2c/dw9807.c                                      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)