* [PATCH -next] regmap: sccb: fix typo and sort headers alphabetically
@ 2018-07-22 15:45 Akinobu Mita
2018-07-22 17:37 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Akinobu Mita @ 2018-07-22 15:45 UTC (permalink / raw)
To: linux-media, linux-i2c, linux-kernel
Cc: Akinobu Mita, Wolfram Sang, Mark Brown
Fix typos 's/wit/with/' in the comments and sort headers alphabetically
in order to avoid duplicate includes in future.
Fixes: bcf7eac3d97f ("regmap: add SCCB support")
Reported-by: Wolfram Sang <wsa@the-dreams.de>
Cc: Wolfram Sang <wsa@the-dreams.de>
Cc: Mark Brown <broonie@kernel.org>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
drivers/base/regmap/regmap-sccb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/base/regmap/regmap-sccb.c b/drivers/base/regmap/regmap-sccb.c
index b6eb876..597042e2 100644
--- a/drivers/base/regmap/regmap-sccb.c
+++ b/drivers/base/regmap/regmap-sccb.c
@@ -1,9 +1,9 @@
// SPDX-License-Identifier: GPL-2.0
// Register map access API - SCCB support
-#include <linux/regmap.h>
#include <linux/i2c.h>
#include <linux/module.h>
+#include <linux/regmap.h>
#include "internal.h"
@@ -29,7 +29,7 @@ static bool sccb_is_available(struct i2c_adapter *adap)
/**
* regmap_sccb_read - Read data from SCCB slave device
- * @context: Device that will be interacted wit
+ * @context: Device that will be interacted with
* @reg: Register to be read from
* @val: Pointer to store read value
*
@@ -65,7 +65,7 @@ static int regmap_sccb_read(void *context, unsigned int reg, unsigned int *val)
/**
* regmap_sccb_write - Write data to SCCB slave device
- * @context: Device that will be interacted wit
+ * @context: Device that will be interacted with
* @reg: Register to write to
* @val: Value to be written
*
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] regmap: sccb: fix typo and sort headers alphabetically
2018-07-22 15:45 [PATCH -next] regmap: sccb: fix typo and sort headers alphabetically Akinobu Mita
@ 2018-07-22 17:37 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2018-07-22 17:37 UTC (permalink / raw)
To: Akinobu Mita; +Cc: linux-media, linux-i2c, linux-kernel, Mark Brown
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
On Mon, Jul 23, 2018 at 12:45:46AM +0900, Akinobu Mita wrote:
> Fix typos 's/wit/with/' in the comments and sort headers alphabetically
> in order to avoid duplicate includes in future.
>
> Fixes: bcf7eac3d97f ("regmap: add SCCB support")
> Reported-by: Wolfram Sang <wsa@the-dreams.de>
Could this be replaced with (as I did this in my work time):
Reported-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
?
> Cc: Wolfram Sang <wsa@the-dreams.de>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Looks good, thanks!
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-22 18:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-22 15:45 [PATCH -next] regmap: sccb: fix typo and sort headers alphabetically Akinobu Mita
2018-07-22 17:37 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).