* [PATCH 1/2] media: imx319: fix wrong order in test pattern menus @ 2018-11-26 7:43 bingbu.cao 2018-11-26 7:43 ` [PATCH 2/2] media: imx355: " bingbu.cao 0 siblings, 1 reply; 6+ messages in thread From: bingbu.cao @ 2018-11-26 7:43 UTC (permalink / raw) To: linux-media Cc: sakari.ailus, tfiga, rajmohan.mani, bingbu.cao, mchehab+samsung, hverkuil From: Bingbu Cao <bingbu.cao@intel.com> current imx319 test pattern order in ctrl menu is not correct, this patch fixes it. Signed-off-by: Bingbu Cao <bingbu.cao@intel.com> --- drivers/media/i2c/imx319.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx319.c b/drivers/media/i2c/imx319.c index 0d3e27812b93..acd988d2d7f1 100644 --- a/drivers/media/i2c/imx319.c +++ b/drivers/media/i2c/imx319.c @@ -1648,8 +1648,8 @@ struct imx319 { static const char * const imx319_test_pattern_menu[] = { "Disabled", - "100% color bars", "Solid color", + "100% color bars", "Fade to gray color bars", "PN9" }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] media: imx355: fix wrong order in test pattern menus 2018-11-26 7:43 [PATCH 1/2] media: imx319: fix wrong order in test pattern menus bingbu.cao @ 2018-11-26 7:43 ` bingbu.cao 2018-11-26 8:57 ` Sakari Ailus 0 siblings, 1 reply; 6+ messages in thread From: bingbu.cao @ 2018-11-26 7:43 UTC (permalink / raw) To: linux-media Cc: sakari.ailus, tfiga, rajmohan.mani, bingbu.cao, mchehab+samsung, hverkuil From: Bingbu Cao <bingbu.cao@intel.com> current imx355 test pattern order in ctrl menu is not correct, this patch fixes it. Signed-off-by: Bingbu Cao <bingbu.cao@intel.com> --- drivers/media/i2c/imx355.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c index 20c8eea5db4b..9c9559dfd3dd 100644 --- a/drivers/media/i2c/imx355.c +++ b/drivers/media/i2c/imx355.c @@ -876,8 +876,8 @@ struct imx355 { static const char * const imx355_test_pattern_menu[] = { "Disabled", - "100% color bars", "Solid color", + "100% color bars", "Fade to gray color bars", "PN9" }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] media: imx355: fix wrong order in test pattern menus 2018-11-26 7:43 ` [PATCH 2/2] media: imx355: " bingbu.cao @ 2018-11-26 8:57 ` Sakari Ailus 2018-11-26 9:43 ` Bingbu Cao 2018-11-27 2:45 ` Bingbu Cao 0 siblings, 2 replies; 6+ messages in thread From: Sakari Ailus @ 2018-11-26 8:57 UTC (permalink / raw) To: bingbu.cao Cc: linux-media, tfiga, rajmohan.mani, bingbu.cao, mchehab+samsung, hverkuil Hi Bing Bu, On Mon, Nov 26, 2018 at 03:43:34PM +0800, bingbu.cao@intel.com wrote: > From: Bingbu Cao <bingbu.cao@intel.com> > > current imx355 test pattern order in ctrl menu > is not correct, this patch fixes it. > > Signed-off-by: Bingbu Cao <bingbu.cao@intel.com> > --- > drivers/media/i2c/imx355.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c > index 20c8eea5db4b..9c9559dfd3dd 100644 > --- a/drivers/media/i2c/imx355.c > +++ b/drivers/media/i2c/imx355.c > @@ -876,8 +876,8 @@ struct imx355 { > > static const char * const imx355_test_pattern_menu[] = { > "Disabled", > - "100% color bars", > "Solid color", > + "100% color bars", > "Fade to gray color bars", > "PN9" > }; While at it, could you use the existing test pattern naming as well for the drivers? That could be a separate patch. >From drivers/media/i2c/smiapp/smiapp-core.c : static const char * const smiapp_test_patterns[] = { "Disabled", "Solid Colour", "Eight Vertical Colour Bars", "Colour Bars With Fade to Grey", "Pseudorandom Sequence (PN9)", }; It's not strictly necessary from interface point of view, but for the user space it'd be good to align the naming. -- Regards, Sakari Ailus sakari.ailus@linux.intel.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] media: imx355: fix wrong order in test pattern menus 2018-11-26 8:57 ` Sakari Ailus @ 2018-11-26 9:43 ` Bingbu Cao 2018-11-27 2:45 ` Bingbu Cao 1 sibling, 0 replies; 6+ messages in thread From: Bingbu Cao @ 2018-11-26 9:43 UTC (permalink / raw) To: Sakari Ailus, bingbu.cao Cc: linux-media, tfiga, rajmohan.mani, mchehab+samsung, hverkuil On 11/26/2018 04:57 PM, Sakari Ailus wrote: > Hi Bing Bu, > > On Mon, Nov 26, 2018 at 03:43:34PM +0800, bingbu.cao@intel.com wrote: >> From: Bingbu Cao <bingbu.cao@intel.com> >> >> current imx355 test pattern order in ctrl menu >> is not correct, this patch fixes it. >> >> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com> >> --- >> drivers/media/i2c/imx355.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c >> index 20c8eea5db4b..9c9559dfd3dd 100644 >> --- a/drivers/media/i2c/imx355.c >> +++ b/drivers/media/i2c/imx355.c >> @@ -876,8 +876,8 @@ struct imx355 { >> >> static const char * const imx355_test_pattern_menu[] = { >> "Disabled", >> - "100% color bars", >> "Solid color", >> + "100% color bars", >> "Fade to gray color bars", >> "PN9" >> }; > While at it, could you use the existing test pattern naming as well for the > drivers? That could be a separate patch. Good point, thanks. I am trying to check whether all the existing Sony camera sensors use same test pattern definition, I can put them together. > > >From drivers/media/i2c/smiapp/smiapp-core.c : > > static const char * const smiapp_test_patterns[] = { > "Disabled", > "Solid Colour", > "Eight Vertical Colour Bars", > "Colour Bars With Fade to Grey", > "Pseudorandom Sequence (PN9)", > }; > > It's not strictly necessary from interface point of view, but for the user > space it'd be good to align the naming. > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] media: imx355: fix wrong order in test pattern menus 2018-11-26 8:57 ` Sakari Ailus 2018-11-26 9:43 ` Bingbu Cao @ 2018-11-27 2:45 ` Bingbu Cao 2018-11-27 9:22 ` Sakari Ailus 1 sibling, 1 reply; 6+ messages in thread From: Bingbu Cao @ 2018-11-27 2:45 UTC (permalink / raw) To: Sakari Ailus, bingbu.cao Cc: linux-media, tfiga, rajmohan.mani, mchehab+samsung, hverkuil On 11/26/2018 04:57 PM, Sakari Ailus wrote: > Hi Bing Bu, > > On Mon, Nov 26, 2018 at 03:43:34PM +0800, bingbu.cao@intel.com wrote: >> From: Bingbu Cao <bingbu.cao@intel.com> >> >> current imx355 test pattern order in ctrl menu >> is not correct, this patch fixes it. >> >> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com> >> --- >> drivers/media/i2c/imx355.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c >> index 20c8eea5db4b..9c9559dfd3dd 100644 >> --- a/drivers/media/i2c/imx355.c >> +++ b/drivers/media/i2c/imx355.c >> @@ -876,8 +876,8 @@ struct imx355 { >> >> static const char * const imx355_test_pattern_menu[] = { >> "Disabled", >> - "100% color bars", >> "Solid color", >> + "100% color bars", >> "Fade to gray color bars", >> "PN9" >> }; > While at it, could you use the existing test pattern naming as well for the > drivers? That could be a separate patch. > > >From drivers/media/i2c/smiapp/smiapp-core.c : > > static const char * const smiapp_test_patterns[] = { > "Disabled", > "Solid Colour", > "Eight Vertical Colour Bars", > "Colour Bars With Fade to Grey", > "Pseudorandom Sequence (PN9)", > }; > > It's not strictly necessary from interface point of view, but for the user > space it'd be good to align the naming. Sakari, ask a question that not really related to this patch. I am wondering whether there are some standardization for the camera sensor pattern generator. Currently there are varied patterns and every vendor has its own pattern types. > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] media: imx355: fix wrong order in test pattern menus 2018-11-27 2:45 ` Bingbu Cao @ 2018-11-27 9:22 ` Sakari Ailus 0 siblings, 0 replies; 6+ messages in thread From: Sakari Ailus @ 2018-11-27 9:22 UTC (permalink / raw) To: Bingbu Cao Cc: Sakari Ailus, bingbu.cao, linux-media, tfiga, rajmohan.mani, mchehab+samsung, hverkuil On Tue, Nov 27, 2018 at 10:45:02AM +0800, Bingbu Cao wrote: > > > On 11/26/2018 04:57 PM, Sakari Ailus wrote: > > Hi Bing Bu, > > > > On Mon, Nov 26, 2018 at 03:43:34PM +0800, bingbu.cao@intel.com wrote: > > > From: Bingbu Cao <bingbu.cao@intel.com> > > > > > > current imx355 test pattern order in ctrl menu > > > is not correct, this patch fixes it. > > > > > > Signed-off-by: Bingbu Cao <bingbu.cao@intel.com> > > > --- > > > drivers/media/i2c/imx355.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c > > > index 20c8eea5db4b..9c9559dfd3dd 100644 > > > --- a/drivers/media/i2c/imx355.c > > > +++ b/drivers/media/i2c/imx355.c > > > @@ -876,8 +876,8 @@ struct imx355 { > > > static const char * const imx355_test_pattern_menu[] = { > > > "Disabled", > > > - "100% color bars", > > > "Solid color", > > > + "100% color bars", > > > "Fade to gray color bars", > > > "PN9" > > > }; > > While at it, could you use the existing test pattern naming as well for the > > drivers? That could be a separate patch. > > > > >From drivers/media/i2c/smiapp/smiapp-core.c : > > > > static const char * const smiapp_test_patterns[] = { > > "Disabled", > > "Solid Colour", > > "Eight Vertical Colour Bars", > > "Colour Bars With Fade to Grey", > > "Pseudorandom Sequence (PN9)", > > }; > > > > It's not strictly necessary from interface point of view, but for the user > > space it'd be good to align the naming. > Sakari, ask a question that not really related to this patch. > I am wondering whether there are some standardization for the camera sensor > pattern generator. > Currently there are varied patterns and every vendor has its own pattern types. Some vendors (and some models) do have their specific patterns, but if you look at a bunch of drivers, these ones repeat over and over. That's why I think it'd make sense to have the menu entries aligned. -- Sakari Ailus e-mail: sakari.ailus@iki.fi ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-27 20:20 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-11-26 7:43 [PATCH 1/2] media: imx319: fix wrong order in test pattern menus bingbu.cao 2018-11-26 7:43 ` [PATCH 2/2] media: imx355: " bingbu.cao 2018-11-26 8:57 ` Sakari Ailus 2018-11-26 9:43 ` Bingbu Cao 2018-11-27 2:45 ` Bingbu Cao 2018-11-27 9:22 ` Sakari Ailus
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).