Re: next-20181211 build: 1 failures 32 warnings (next-20181211)

Re: next-20181211 build: 1 failures 32 warnings (next-20181211)

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]

On Tue, Dec 11, 2018 at 07:38:33PM +0000, Build bot for Mark Brown wrote:

Today's -next fails to build an arm allmodconfig due to:

> 	arm-allmodconfig
> ../arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t'
> ../arch/arm/include/asm/irq.h:36:9: error: unknown type name 'bool'
> ../arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t'
> ../arch/arm/include/asm/irq.h:36:9: error: unknown type name 'bool'
> ../arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t'
> ../arch/arm/include/asm/irq.h:36:9: error: unknown type name 'bool'
> ../arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t'
> ../arch/arm/include/asm/irq.h:36:9: error: unknown type name 'bool'

in ddbridge-ci.c and some other media files.  This is because
ddbridge.h includes asm/irq.h but that does not directly include headers
which define the above types and it appears some header changes have
removed an implicit inclusion of those.  Moving the asm includes after
the linux ones in ddbridge.h fixes this though this appears to be
against the coding style for media.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: next-20181211 build: 1 failures 32 warnings (next-20181211)

[Nathan Chancellor]

On Tue, Dec 11, 2018 at 10:06:20PM +0000, Mark Brown wrote:
> On Tue, Dec 11, 2018 at 07:38:33PM +0000, Build bot for Mark Brown wrote:
> 
> Today's -next fails to build an arm allmodconfig due to:
> 
> > 	arm-allmodconfig
> > ../arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t'
> > ../arch/arm/include/asm/irq.h:36:9: error: unknown type name 'bool'
> > ../arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t'
> > ../arch/arm/include/asm/irq.h:36:9: error: unknown type name 'bool'
> > ../arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t'
> > ../arch/arm/include/asm/irq.h:36:9: error: unknown type name 'bool'
> > ../arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t'
> > ../arch/arm/include/asm/irq.h:36:9: error: unknown type name 'bool'
> 
> in ddbridge-ci.c and some other media files.  This is because
> ddbridge.h includes asm/irq.h but that does not directly include headers
> which define the above types and it appears some header changes have
> removed an implicit inclusion of those.  Moving the asm includes after
> the linux ones in ddbridge.h fixes this though this appears to be
> against the coding style for media.

Hi Mark,

I sent a patch for this yesterday, I think moving the asm includes after
the linux ones is the correct fix according to the rest of the kernel:
https://lore.kernel.org/linux-media/20181210233514.3069-1-natechancellor@gmail.com/

Hopefully it can be picked up quickly.

Thanks,
Nathan

Re: next-20181211 build: 1 failures 32 warnings (next-20181211)

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 958 bytes --]

On Tue, Dec 11, 2018 at 03:15:35PM -0700, Nathan Chancellor wrote:
> On Tue, Dec 11, 2018 at 10:06:20PM +0000, Mark Brown wrote:

> > in ddbridge-ci.c and some other media files.  This is because
> > ddbridge.h includes asm/irq.h but that does not directly include headers
> > which define the above types and it appears some header changes have
> > removed an implicit inclusion of those.  Moving the asm includes after
> > the linux ones in ddbridge.h fixes this though this appears to be
> > against the coding style for media.

> I sent a patch for this yesterday, I think moving the asm includes after
> the linux ones is the correct fix according to the rest of the kernel:
> https://lore.kernel.org/linux-media/20181210233514.3069-1-natechancellor@gmail.com/

> Hopefully it can be picked up quickly.

Ah, great - thanks.  I agree this is probably the best fix, I just
wasn't sure if the media people had some other idea given the coding
style there.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]