From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: linux-media@vger.kernel.org
Cc: Dafna Hirschfeld <dafna3@gmail.com>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Ezequiel Garcia <ezequiel@collabora.com>
Subject: [PATCHv2 0/6] vb2/v4l2-ctrls: check if requests are required
Date: Mon, 11 Feb 2019 11:13:51 +0100 [thread overview]
Message-ID: <20190211101357.48754-1-hverkuil-cisco@xs4all.nl> (raw)
Currently the vb2 supports_requests bitfield only indicates if the
Request API is supported by the vb2_queue. But for stateless
codecs the use of the Request API is actually a requirement.
So add a requires_requests bitfield and corresponding capability
to indicate that userspace has to use requests. And of course
reject direct VIDIOC_QBUF calls (i.e. V4L2_BUF_FLAG_REQUEST_FD
isn't set) if requires_requests is set.
Finally set this bitfield in the cedrus driver.
Do the same for controls: it makes no sense to set state controls
for stateless codecs directly without going through a request.
Add a new flag to indicate this and check it.
Regards,
Hans
Hans Verkuil (6):
vb2: add requires_requests bit for stateless codecs
videodev2.h: add V4L2_BUF_CAP_REQUIRES_REQUESTS
cedrus: set requires_requests
videodev2.h: add V4L2_CTRL_FLAG_REQUIRES_REQUESTS
v4l2-ctrls: check for REQUIRES_REQUESTS flag
v4l2-ctrls: mark MPEG2 stateless controls as REQUIRES_REQUESTS
.../media/uapi/v4l/vidioc-queryctrl.rst | 4 ++++
.../media/uapi/v4l/vidioc-reqbufs.rst | 4 ++++
.../media/videodev2.h.rst.exceptions | 1 +
.../media/common/videobuf2/videobuf2-core.c | 5 +++-
.../media/common/videobuf2/videobuf2-v4l2.c | 6 +++++
drivers/media/v4l2-core/v4l2-ctrls.c | 5 ++++
.../staging/media/sunxi/cedrus/cedrus_video.c | 1 +
include/media/videobuf2-core.h | 3 +++
include/uapi/linux/videodev2.h | 24 ++++++++++---------
9 files changed, 41 insertions(+), 12 deletions(-)
--
2.20.1
next reply other threads:[~2019-02-11 10:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 10:13 Hans Verkuil [this message]
2019-02-11 10:13 ` [PATCHv2 1/6] vb2: add requires_requests bit for stateless codecs Hans Verkuil
2019-02-11 10:13 ` [PATCHv2 2/6] videodev2.h: add V4L2_BUF_CAP_REQUIRES_REQUESTS Hans Verkuil
2019-02-11 10:13 ` [PATCHv2 3/6] cedrus: set requires_requests Hans Verkuil
2019-02-11 10:13 ` [PATCHv2 4/6] videodev2.h: add V4L2_CTRL_FLAG_REQUIRES_REQUESTS Hans Verkuil
2019-02-11 13:04 ` Hans Verkuil
2019-02-13 10:38 ` Paul Kocialkowski
2019-02-13 11:59 ` Hans Verkuil
2019-02-11 10:13 ` [PATCHv2 5/6] v4l2-ctrls: check for REQUIRES_REQUESTS flag Hans Verkuil
2019-02-11 10:13 ` [PATCHv2 6/6] v4l2-ctrls: mark MPEG2 stateless controls as REQUIRES_REQUESTS Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211101357.48754-1-hverkuil-cisco@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=dafna3@gmail.com \
--cc=ezequiel@collabora.com \
--cc=linux-media@vger.kernel.org \
--cc=paul.kocialkowski@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).