[PATCH 1/2] media: ipu3: shut up warnings produced with W=1

[PATCH 1/2] media: ipu3: shut up warnings produced with W=1

[Mauro Carvalho Chehab]

There are lots of warnings produced by this driver. It is not
as much as atomisp, but it is still a lot.

So, use the same solution to hide most of them.
Those need to be fixed before promoting it out of staging,
so add it at the TODO list.

Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
---
 drivers/staging/media/ipu3/Makefile | 6 ++++++
 drivers/staging/media/ipu3/TODO     | 2 ++
 2 files changed, 8 insertions(+)

diff --git a/drivers/staging/media/ipu3/Makefile b/drivers/staging/media/ipu3/Makefile
index fb146d178bd4..fa7fa3372bcb 100644
--- a/drivers/staging/media/ipu3/Makefile
+++ b/drivers/staging/media/ipu3/Makefile
@@ -9,3 +9,9 @@ ipu3-imgu-objs += \
 		ipu3-css.o ipu3-v4l2.o ipu3.o
 
 obj-$(CONFIG_VIDEO_IPU3_IMGU) += ipu3-imgu.o
+
+# HACK! While this driver is in bad shape, don't enable several warnings
+#       that would be otherwise enabled with W=1
+ccflags-y += $(call cc-disable-warning, packed-not-aligned)
+ccflags-y += $(call cc-disable-warning, type-limits)
+ccflags-y += $(call cc-disable-warning, unused-const-variable)
diff --git a/drivers/staging/media/ipu3/TODO b/drivers/staging/media/ipu3/TODO
index 8b95e74e43a0..5e55baeaea1a 100644
--- a/drivers/staging/media/ipu3/TODO
+++ b/drivers/staging/media/ipu3/TODO
@@ -27,3 +27,5 @@ staging directory.
 - Document different operation modes, and which buffer queues are relevant
   in each mode. To process an image, which queues require a buffer an in
   which ones is it optional?
+
+- Make sure it builds fine with no warnings with W=1
-- 
2.20.1

[PATCH 2/2] ipu3-mmu: fix some kernel-doc macros

[Mauro Carvalho Chehab]

Some kernel-doc markups are wrong. fix them.

Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
---
 drivers/staging/media/ipu3/ipu3-mmu.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/ipu3/ipu3-mmu.c b/drivers/staging/media/ipu3/ipu3-mmu.c
index cd2038b22b55..cfc2bdfb14b3 100644
--- a/drivers/staging/media/ipu3/ipu3-mmu.c
+++ b/drivers/staging/media/ipu3/ipu3-mmu.c
@@ -238,7 +238,7 @@ static int __imgu_mmu_map(struct imgu_mmu *mmu, unsigned long iova,
 	return 0;
 }
 
-/**
+/*
  * The following four functions are implemented based on iommu.c
  * drivers/iommu/iommu.c/iommu_pgsize().
  */
@@ -444,6 +444,7 @@ size_t imgu_mmu_unmap(struct imgu_mmu_info *info, unsigned long iova,
 
 /**
  * imgu_mmu_init() - initialize IPU3 MMU block
+ * @parent:	struct device parent
  * @base:	IOMEM base of hardware registers.
  *
  * Return: Pointer to IPU3 MMU private data pointer or ERR_PTR() on error.
@@ -522,7 +523,7 @@ struct imgu_mmu_info *imgu_mmu_init(struct device *parent, void __iomem *base)
 
 /**
  * imgu_mmu_exit() - clean up IPU3 MMU block
- * @mmu: IPU3 MMU private data
+ * @info: IPU3 MMU private data
  */
 void imgu_mmu_exit(struct imgu_mmu_info *info)
 {
-- 
2.20.1

Re: [PATCH 1/2] media: ipu3: shut up warnings produced with W=1

[Sakari Ailus]

Hi Mauro,

On Tue, Feb 19, 2019 at 09:00:29AM -0500, Mauro Carvalho Chehab wrote:
> There are lots of warnings produced by this driver. It is not
> as much as atomisp, but it is still a lot.
> 
> So, use the same solution to hide most of them.
> Those need to be fixed before promoting it out of staging,
> so add it at the TODO list.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> ---
>  drivers/staging/media/ipu3/Makefile | 6 ++++++
>  drivers/staging/media/ipu3/TODO     | 2 ++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/drivers/staging/media/ipu3/Makefile b/drivers/staging/media/ipu3/Makefile
> index fb146d178bd4..fa7fa3372bcb 100644
> --- a/drivers/staging/media/ipu3/Makefile
> +++ b/drivers/staging/media/ipu3/Makefile
> @@ -9,3 +9,9 @@ ipu3-imgu-objs += \
>  		ipu3-css.o ipu3-v4l2.o ipu3.o
>  
>  obj-$(CONFIG_VIDEO_IPU3_IMGU) += ipu3-imgu.o
> +
> +# HACK! While this driver is in bad shape, don't enable several warnings
> +#       that would be otherwise enabled with W=1
> +ccflags-y += $(call cc-disable-warning, packed-not-aligned)
> +ccflags-y += $(call cc-disable-warning, type-limits)
> +ccflags-y += $(call cc-disable-warning, unused-const-variable)

I'm preparing patches to address these. Could you wait a little bit more,
please?

Thanks.

-- 
Kind regards,

Sakari Ailus
sakari.ailus@linux.intel.com

Re: [PATCH 2/2] ipu3-mmu: fix some kernel-doc macros

[Sakari Ailus]

On Tue, Feb 19, 2019 at 09:00:30AM -0500, Mauro Carvalho Chehab wrote:
> Some kernel-doc markups are wrong. fix them.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

-- 
Sakari Ailus
sakari.ailus@linux.intel.com

Re: [PATCH 1/2] media: ipu3: shut up warnings produced with W=1

[Mauro Carvalho Chehab]

Em Tue, 19 Feb 2019 16:03:17 +0200
Sakari Ailus <sakari.ailus@linux.intel.com> escreveu:

> Hi Mauro,
> 
> On Tue, Feb 19, 2019 at 09:00:29AM -0500, Mauro Carvalho Chehab wrote:
> > There are lots of warnings produced by this driver. It is not
> > as much as atomisp, but it is still a lot.
> > 
> > So, use the same solution to hide most of them.
> > Those need to be fixed before promoting it out of staging,
> > so add it at the TODO list.
> > 
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> > ---
> >  drivers/staging/media/ipu3/Makefile | 6 ++++++
> >  drivers/staging/media/ipu3/TODO     | 2 ++
> >  2 files changed, 8 insertions(+)
> > 
> > diff --git a/drivers/staging/media/ipu3/Makefile b/drivers/staging/media/ipu3/Makefile
> > index fb146d178bd4..fa7fa3372bcb 100644
> > --- a/drivers/staging/media/ipu3/Makefile
> > +++ b/drivers/staging/media/ipu3/Makefile
> > @@ -9,3 +9,9 @@ ipu3-imgu-objs += \
> >  		ipu3-css.o ipu3-v4l2.o ipu3.o
> >  
> >  obj-$(CONFIG_VIDEO_IPU3_IMGU) += ipu3-imgu.o
> > +
> > +# HACK! While this driver is in bad shape, don't enable several warnings
> > +#       that would be otherwise enabled with W=1
> > +ccflags-y += $(call cc-disable-warning, packed-not-aligned)
> > +ccflags-y += $(call cc-disable-warning, type-limits)
> > +ccflags-y += $(call cc-disable-warning, unused-const-variable)  
> 
> I'm preparing patches to address these. Could you wait a little bit more,
> please?

Those warnings are there for a while...

It has been really painful for my workflow all those ipu3
warnings, as they're preventing seeing troubles on other places.

Anyway, as soon as you address the issues, we can (partially
or fully) revert those changes.

Thanks,
Mauro