* [PATCH] media: i2c: adv748x: select V4L2_FWNODE
@ 2019-03-05 13:23 Arnd Bergmann
2019-03-05 13:40 ` Laurent Pinchart
2019-03-05 17:05 ` Niklas Söderlund
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2019-03-05 13:23 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Hans Verkuil
Cc: Niklas Söderlund, Laurent Pinchart, Arnd Bergmann,
Sakari Ailus, Jacopo Mondi, linux-media, linux-kernel
Building adv748x fails now unless V4L2_FWNODE is selected:
drivers/media/i2c/adv748x/adv748x-core.o: In function `adv748x_probe':
adv748x-core.c:(.text+0x1b2c): undefined reference to `v4l2_fwnode_endpoint_parse'
Fixes: 6a18865da8e3 ("media: i2c: adv748x: store number of CSI-2 lanes described in device tree")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/media/i2c/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 6d32f8dcf83b..3f5dd80e14f8 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -221,6 +221,7 @@ config VIDEO_ADV748X
depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API
depends on OF
select REGMAP_I2C
+ select V4L2_FWNODE
---help---
V4L2 subdevice driver for the Analog Devices
ADV7481 and ADV7482 HDMI/Analog video decoders.
--
2.20.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: i2c: adv748x: select V4L2_FWNODE
2019-03-05 13:23 [PATCH] media: i2c: adv748x: select V4L2_FWNODE Arnd Bergmann
@ 2019-03-05 13:40 ` Laurent Pinchart
2019-03-05 17:05 ` Niklas Söderlund
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2019-03-05 13:40 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Mauro Carvalho Chehab, Hans Verkuil, Niklas Söderlund,
Sakari Ailus, Jacopo Mondi, linux-media, linux-kernel
Hi Arnd,
Thank you for the patch.
On Tue, Mar 05, 2019 at 02:23:13PM +0100, Arnd Bergmann wrote:
> Building adv748x fails now unless V4L2_FWNODE is selected:
>
> drivers/media/i2c/adv748x/adv748x-core.o: In function `adv748x_probe':
> adv748x-core.c:(.text+0x1b2c): undefined reference to `v4l2_fwnode_endpoint_parse'
>
> Fixes: 6a18865da8e3 ("media: i2c: adv748x: store number of CSI-2 lanes described in device tree")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index 6d32f8dcf83b..3f5dd80e14f8 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -221,6 +221,7 @@ config VIDEO_ADV748X
> depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API
> depends on OF
> select REGMAP_I2C
> + select V4L2_FWNODE
> ---help---
> V4L2 subdevice driver for the Analog Devices
> ADV7481 and ADV7482 HDMI/Analog video decoders.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: i2c: adv748x: select V4L2_FWNODE
2019-03-05 13:23 [PATCH] media: i2c: adv748x: select V4L2_FWNODE Arnd Bergmann
2019-03-05 13:40 ` Laurent Pinchart
@ 2019-03-05 17:05 ` Niklas Söderlund
1 sibling, 0 replies; 3+ messages in thread
From: Niklas Söderlund @ 2019-03-05 17:05 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Mauro Carvalho Chehab, Hans Verkuil, Laurent Pinchart,
Sakari Ailus, Jacopo Mondi, linux-media, linux-kernel
Hi Arnd,
Thanks for your work.
On 2019-03-05 14:23:13 +0100, Arnd Bergmann wrote:
> Building adv748x fails now unless V4L2_FWNODE is selected:
>
> drivers/media/i2c/adv748x/adv748x-core.o: In function `adv748x_probe':
> adv748x-core.c:(.text+0x1b2c): undefined reference to `v4l2_fwnode_endpoint_parse'
>
> Fixes: 6a18865da8e3 ("media: i2c: adv748x: store number of CSI-2 lanes described in device tree")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/media/i2c/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index 6d32f8dcf83b..3f5dd80e14f8 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -221,6 +221,7 @@ config VIDEO_ADV748X
> depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API
> depends on OF
> select REGMAP_I2C
> + select V4L2_FWNODE
> ---help---
> V4L2 subdevice driver for the Analog Devices
> ADV7481 and ADV7482 HDMI/Analog video decoders.
> --
> 2.20.0
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-05 17:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-05 13:23 [PATCH] media: i2c: adv748x: select V4L2_FWNODE Arnd Bergmann
2019-03-05 13:40 ` Laurent Pinchart
2019-03-05 17:05 ` Niklas Söderlund
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).