From: Sakari Ailus <sakari.ailus@iki.fi>
To: Mickael Guene <mickael.guene@st.com>
Cc: linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v1 1/3] dt-bindings: Document MIPID02 bindings
Date: Sat, 16 Mar 2019 23:46:49 +0200 [thread overview]
Message-ID: <20190316214649.co63p5arhiwbuv3g@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <1552373045-134493-2-git-send-email-mickael.guene@st.com>
Hi Mickael,
Thanks for the patchset.
On Tue, Mar 12, 2019 at 07:44:03AM +0100, Mickael Guene wrote:
> This adds documentation of device tree for MIPID02 CSI-2 to PARALLEL
> bridge.
>
> Signed-off-by: Mickael Guene <mickael.guene@st.com>
> ---
>
> .../bindings/media/i2c/st,st-mipid02.txt | 69 ++++++++++++++++++++++
> 1 file changed, 69 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/st,st-mipid02.txt
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/st,st-mipid02.txt b/Documentation/devicetree/bindings/media/i2c/st,st-mipid02.txt
> new file mode 100644
> index 0000000..a1855da
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/st,st-mipid02.txt
> @@ -0,0 +1,69 @@
> +STMicroelectronics MIPID02 CSI-2 to PARALLEL bridge
> +
> +MIPID02 has two CSI-2 input ports, only one of those ports can be active at a
> +time. Active port input stream will be de-serialized and its content outputted
> +through PARALLEL output port.
> +CSI-2 first input port is a dual lane 800Mbps whereas CSI-2 second input port is
800 Mbps per lane (or total)?
> +a single lane 800Mbps. Both ports support clock and data lane polarity swap.
> +First port also supports data lane swap.
> +PARALLEL output port has a maximum width of 12 bits.
> +Supported formats are RAW6, RAW7, RAW8, RAW10, RAW12, RGB565, RGB888, RGB444,
> +YUV420 8-bit, YUV422 8-bit and YUV420 10-bit.
> +
> +Required Properties:
> +- compatible: should be "st,st-mipid02"
> +- clocks: reference to the xclk input clock.
> +- clock-names: should be "xclk".
> +- VDDE-supply: sensor digital IO supply. Must be 1.8 volts.
> +- VDDIN-supply: sensor internal regulator supply. Must be 1.8 volts.
Perhaps Rob can confirm, but AFAIR the custom is to use lower case letters.
> +
> +Optional Properties:
> +- reset-gpios: reference to the GPIO connected to the xsdn pin, if any.
> + This is an active low signal to the mipid02.
> +
> +Required subnodes:
> + - ports: A ports node with one port child node per device input and output
> + port, in accordance with the video interface bindings defined in
> + Documentation/devicetree/bindings/media/video-interfaces.txt. The
> + port nodes are numbered as follows:
> +
> + Port Description
> + -----------------------------
> + 0 CSI-2 first input port
> + 1 CSI-2 second input port
> + 2 PARALLEL output
Please document which endpoint properties are relevant. From the above
description I'd presume this to be at least clock-lanes (1st input),
data-lanes, lane-polarities (for CSI-2) as well as bus-width for the
parallel bus.
> +
> +Example:
> +
> +mipid02: mipid02@14 {
The node should be a generic name. "csi2rx" is used by a few devices now.
> + compatible = "st,st-mipid02";
> + reg = <0x14>;
> + status = "okay";
> + clocks = <&clk_ext_camera_12>;
> + clock-names = "xclk";
> + VDDE-supply = <&vdd>;
> + VDDIN-supply = <&vdd>;
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> +
> + ep0: endpoint {
> + clock-lanes = <0>;
> + data-lanes = <1 2>;
> + remote-endpoint = <&mipi_csi2_in>;
> + };
> + };
> + port@2 {
> + reg = <2>;
> +
> + ep2: endpoint {
> + bus-width = <8>;
> + hsync-active = <0>;
> + vsync-active = <0>;
> + remote-endpoint = <¶llel_out>;
> + };
> + };
> + };
> +};
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2019-03-16 21:48 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 6:44 [PATCH v1 0/3] Add support for MIPID02 CSI-2 to PARALLEL bridge I2C device Mickael Guene
2019-03-12 6:44 ` [PATCH v1 1/3] dt-bindings: Document MIPID02 bindings Mickael Guene
2019-03-16 21:46 ` Sakari Ailus [this message]
2019-03-18 8:28 ` Mickael GUENE
2019-03-18 8:48 ` Sakari Ailus
2019-03-18 9:08 ` Mickael GUENE
2019-03-12 6:44 ` [PATCH v1 2/3] media:st-mipid02: MIPID02 CSI-2 to PARALLEL bridge driver Mickael Guene
2019-03-16 22:14 ` Sakari Ailus
2019-03-18 9:57 ` Mickael GUENE
2019-03-25 11:17 ` Sakari Ailus
2019-03-25 12:14 ` Mickael GUENE
2019-03-26 11:37 ` Sakari Ailus
2019-03-26 12:07 ` Mickael GUENE
2019-03-12 6:44 ` [PATCH v1 3/3] media: MAINTAINERS: add entry for STMicroelectronics MIPID02 media driver Mickael Guene
2019-03-16 21:47 ` Sakari Ailus
2019-03-18 10:01 ` Mickael GUENE
2019-03-25 7:55 ` [PATCH v2 0/2] Add support for MIPID02 CSI-2 to PARALLEL bridge I2C device Mickael Guene
2019-03-25 7:55 ` [PATCH v2 1/2] dt-bindings: Document MIPID02 bindings Mickael Guene
2019-03-25 7:55 ` [PATCH v2 2/2] media:st-mipid02: MIPID02 CSI-2 to PARALLEL bridge driver Mickael Guene
2019-03-25 11:44 ` Sakari Ailus
2019-03-25 12:22 ` Mickael GUENE
2019-03-26 11:34 ` Sakari Ailus
2019-03-26 12:32 ` Mickael GUENE
2019-03-26 10:03 ` [PATCH v3 0/2] Add support for MIPID02 CSI-2 to PARALLEL bridge I2C device Mickael Guene
2019-03-26 10:03 ` [PATCH v3 1/2] dt-bindings: Document MIPID02 bindings Mickael Guene
2019-03-26 12:17 ` Sakari Ailus
2019-03-26 13:40 ` Mickael GUENE
2019-03-26 13:44 ` Sakari Ailus
2019-03-26 10:03 ` [PATCH v3 2/2] media:st-mipid02: MIPID02 CSI-2 to PARALLEL bridge driver Mickael Guene
2019-03-26 11:33 ` Sakari Ailus
2019-03-26 12:57 ` Mickael GUENE
2019-03-26 13:54 ` Sakari Ailus
2019-03-26 14:12 ` Mickael GUENE
2019-03-26 14:14 ` Sakari Ailus
2019-03-26 14:36 ` Mickael GUENE
2019-04-06 11:01 ` Sakari Ailus
2019-04-08 6:17 ` Mickael GUENE
2019-04-08 9:21 ` Sakari Ailus
2019-03-27 9:55 ` [PATCH v4 0/2] Add support for MIPID02 CSI-2 to PARALLEL bridge I2C device Mickael Guene
2019-03-27 9:55 ` [PATCH v4 1/2] dt-bindings: Document MIPID02 bindings Mickael Guene
2019-03-28 17:43 ` Rob Herring
2019-04-06 10:35 ` Sakari Ailus
2019-04-06 10:38 ` Sakari Ailus
2019-04-08 6:20 ` Mickael GUENE
2019-03-27 9:55 ` [PATCH v4 2/2] media:st-mipid02: MIPID02 CSI-2 to PARALLEL bridge driver Mickael Guene
[not found] ` <20190406105606.rciacao5d4hljbbu@kekkonen.localdomain>
2019-04-08 8:20 ` Mickael GUENE
2019-04-08 9:17 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190316214649.co63p5arhiwbuv3g@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=mickael.guene@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).