From: Mickael GUENE <mickael.guene@st.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"Hugues FRUCHET" <hugues.fruchet@st.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Matt Ranostay <matt.ranostay@konsulko.com>,
Akinobu Mita <akinobu.mita@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Ben Kao" <ben.kao@intel.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
"Todor Tomov" <todor.tomov@linaro.org>,
Rui Miguel Silva <rui.silva@linaro.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Ricardo Ribalda Delgado <ricardo@ribalda.com>,
"Jacopo Mondi" <jacopo+renesas@jmondi.org>,
Tianshu Qiu <tian.shu.qiu@intel.com>,
Bingbu Cao <bingbu.cao@intel.com>
Subject: Re: [PATCH v2 2/2] media:st-mipid02: MIPID02 CSI-2 to PARALLEL bridge driver
Date: Tue, 26 Mar 2019 12:32:11 +0000 [thread overview]
Message-ID: <231c710f-5a16-29bb-020c-644d88063f53@st.com> (raw)
In-Reply-To: <20190326113437.bpebmfs7mipsg24y@paasikivi.fi.intel.com>
Hi Sakari,
On 3/26/19 12:34, Sakari Ailus wrote:
> Hi Mickael,
>
> On Mon, Mar 25, 2019 at 12:22:17PM +0000, Mickael GUENE wrote:
> ...
>>>> + /* register it for later use */
>>>> + bridge->rx = ep;
>>>> + bridge->rx.link_frequencies = ep.nr_of_link_frequencies == 1 ?
>>>> + &bridge->link_frequency : NULL;
>>>
>>> I think you need to simply ignore the link frequencies here. The
>>> transmitting device can tell the frequency based on its configuration
>>> (based on the link frequencies). You seem to have implemented that already.
>>>
>> Idea of this was to allow some support for sensor that doesn't implement
>> V4L2_CID_PIXEL_RATE. Do you think it's useless ?
>
> Sensor drivers need to be amended with support for that control.
>
Ok. I will drop mipid02_get_link_freq_from_rx_ep and mipid02_get_link_freq_from_cid_link_freq
and only use V4L2_CID_PIXEL_RATE to compute link speed.
next prev parent reply other threads:[~2019-03-26 12:32 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 6:44 [PATCH v1 0/3] Add support for MIPID02 CSI-2 to PARALLEL bridge I2C device Mickael Guene
2019-03-12 6:44 ` [PATCH v1 1/3] dt-bindings: Document MIPID02 bindings Mickael Guene
2019-03-16 21:46 ` Sakari Ailus
2019-03-18 8:28 ` Mickael GUENE
2019-03-18 8:48 ` Sakari Ailus
2019-03-18 9:08 ` Mickael GUENE
2019-03-12 6:44 ` [PATCH v1 2/3] media:st-mipid02: MIPID02 CSI-2 to PARALLEL bridge driver Mickael Guene
2019-03-16 22:14 ` Sakari Ailus
2019-03-18 9:57 ` Mickael GUENE
2019-03-25 11:17 ` Sakari Ailus
2019-03-25 12:14 ` Mickael GUENE
2019-03-26 11:37 ` Sakari Ailus
2019-03-26 12:07 ` Mickael GUENE
2019-03-12 6:44 ` [PATCH v1 3/3] media: MAINTAINERS: add entry for STMicroelectronics MIPID02 media driver Mickael Guene
2019-03-16 21:47 ` Sakari Ailus
2019-03-18 10:01 ` Mickael GUENE
2019-03-25 7:55 ` [PATCH v2 0/2] Add support for MIPID02 CSI-2 to PARALLEL bridge I2C device Mickael Guene
2019-03-25 7:55 ` [PATCH v2 1/2] dt-bindings: Document MIPID02 bindings Mickael Guene
2019-03-25 7:55 ` [PATCH v2 2/2] media:st-mipid02: MIPID02 CSI-2 to PARALLEL bridge driver Mickael Guene
2019-03-25 11:44 ` Sakari Ailus
2019-03-25 12:22 ` Mickael GUENE
2019-03-26 11:34 ` Sakari Ailus
2019-03-26 12:32 ` Mickael GUENE [this message]
2019-03-26 10:03 ` [PATCH v3 0/2] Add support for MIPID02 CSI-2 to PARALLEL bridge I2C device Mickael Guene
2019-03-26 10:03 ` [PATCH v3 1/2] dt-bindings: Document MIPID02 bindings Mickael Guene
2019-03-26 12:17 ` Sakari Ailus
2019-03-26 13:40 ` Mickael GUENE
2019-03-26 13:44 ` Sakari Ailus
2019-03-26 10:03 ` [PATCH v3 2/2] media:st-mipid02: MIPID02 CSI-2 to PARALLEL bridge driver Mickael Guene
2019-03-26 11:33 ` Sakari Ailus
2019-03-26 12:57 ` Mickael GUENE
2019-03-26 13:54 ` Sakari Ailus
2019-03-26 14:12 ` Mickael GUENE
2019-03-26 14:14 ` Sakari Ailus
2019-03-26 14:36 ` Mickael GUENE
2019-04-06 11:01 ` Sakari Ailus
2019-04-08 6:17 ` Mickael GUENE
2019-04-08 9:21 ` Sakari Ailus
2019-03-27 9:55 ` [PATCH v4 0/2] Add support for MIPID02 CSI-2 to PARALLEL bridge I2C device Mickael Guene
2019-03-27 9:55 ` [PATCH v4 1/2] dt-bindings: Document MIPID02 bindings Mickael Guene
2019-03-28 17:43 ` Rob Herring
2019-04-06 10:35 ` Sakari Ailus
2019-04-06 10:38 ` Sakari Ailus
2019-04-08 6:20 ` Mickael GUENE
2019-03-27 9:55 ` [PATCH v4 2/2] media:st-mipid02: MIPID02 CSI-2 to PARALLEL bridge driver Mickael Guene
[not found] ` <20190406105606.rciacao5d4hljbbu@kekkonen.localdomain>
2019-04-08 8:20 ` Mickael GUENE
2019-04-08 9:17 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=231c710f-5a16-29bb-020c-644d88063f53@st.com \
--to=mickael.guene@st.com \
--cc=akinobu.mita@gmail.com \
--cc=arnd@arndb.de \
--cc=ben.kao@intel.com \
--cc=bingbu.cao@intel.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=hugues.fruchet@st.com \
--cc=hverkuil@xs4all.nl \
--cc=jacopo+renesas@jmondi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
--cc=mchehab@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=ricardo@ribalda.com \
--cc=rui.silva@linaro.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
--cc=todor.tomov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).