* [PATCH] staging: media: zoran: fix trailing whitespaces
@ 2019-04-08 4:55 Arthur Moraes do Lago
0 siblings, 0 replies; 4+ messages in thread
From: Arthur Moraes do Lago @ 2019-04-08 4:55 UTC (permalink / raw)
To: mchehab, gregkh, mjpeg-users, linux-media, devel, linux-kernel, lkcamp
There were several form feeds(^L) in the file, this patch removes them
to conform with the coding style.
Signed-off-by: Arthur Moraes do Lago <arthurmoraeslago@gmail.com>
---
Made a mistake while typing recipients on the last e-mail and it was not
sent to the kernel list. Re-sending now with correct address, sorry for
the hassle.
drivers/staging/media/zoran/videocodec.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/media/zoran/videocodec.h b/drivers/staging/media/zoran/videocodec.h
index 4946791fce0d..c37c0e4fb624 100644
--- a/drivers/staging/media/zoran/videocodec.h
+++ b/drivers/staging/media/zoran/videocodec.h
@@ -49,7 +49,7 @@
device dependent and vary between MJPEG/MPEG/WAVELET/... devices. (!!!!)
----------------------------------------------------------------------------
*/
-\f
+
/* ========================================== */
/* description of the videocodec_io structure */
@@ -96,7 +96,7 @@
the calls include frame numbers and flags (even/odd/...)
if needed and a flag which allows blocking until its ready
*/
-\f
+
/* ============== */
/* user interface */
/* ============== */
@@ -116,7 +116,7 @@ M zr36055[0] 0001 0000c001 00000000 (zr36050[0])
M zr36055[1] 0001 0000c001 00000000 (zr36050[1])
*/
-\f
+
/* =============================================== */
/* special defines for the videocodec_io structure */
@@ -195,7 +195,7 @@ M zr36055[1] 0001 0000c001 00000000 (zr36050[1])
/* -> used in get_image, put_image */
#define CODEC_TRANSFER_KERNEL 0 /* use "memcopy" */
#define CODEC_TRANSFER_USER 1 /* use "to/from_user" */
-\f
+
/* ========================= */
/* the structures itself ... */
@@ -309,7 +309,7 @@ struct videocodec_master {
__u16 reg,
__u32 value);
};
-\f
+
/* ================================================= */
/* function prototypes of the master/slave interface */
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: media: zoran: fix trailing whitespaces
2019-04-08 6:51 ` Dan Carpenter
@ 2019-04-10 10:44 ` Hans Verkuil
0 siblings, 0 replies; 4+ messages in thread
From: Hans Verkuil @ 2019-04-10 10:44 UTC (permalink / raw)
To: Dan Carpenter, Arthur Moraes do Lago
Cc: mchehab, gregkh, mjpeg-users, linux-media, devel, linux-kernel, lkcamp
On 4/8/19 8:51 AM, Dan Carpenter wrote:
> On Mon, Apr 08, 2019 at 01:35:30AM -0300, Arthur Moraes do Lago wrote:
>> There were several form feeds(^L) in the file, this patch removes them
>> to conform with the coding style.
>>
>> Signed-off-by: Arthur Moraes do Lago <arthurmoraeslago@gmail.com>
>> ---
>> drivers/staging/media/zoran/videocodec.h | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/staging/media/zoran/videocodec.h b/drivers/staging/media/zoran/videocodec.h
>> index 4946791fce0d..c37c0e4fb624 100644
>> --- a/drivers/staging/media/zoran/videocodec.h
>> +++ b/drivers/staging/media/zoran/videocodec.h
>> @@ -49,7 +49,7 @@
>> device dependent and vary between MJPEG/MPEG/WAVELET/... devices. (!!!!)
>> ----------------------------------------------------------------------------
>> */
>> -\f
>> +
>>
>
> Checkpatch also complains if you have two consecutive blank lines so
> really we should just delete the lines entirely... But this driver is
> scheduled for deletion in May. Let's not bother with cleaning it up.
>
> regards,
> dan carpenter
>
I will in fact post a pull request to remove this driver today.
Regards,
Hans
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: media: zoran: fix trailing whitespaces
2019-04-08 4:35 Arthur Moraes do Lago
@ 2019-04-08 6:51 ` Dan Carpenter
2019-04-10 10:44 ` Hans Verkuil
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2019-04-08 6:51 UTC (permalink / raw)
To: Arthur Moraes do Lago
Cc: mchehab, gregkh, mjpeg-users, linux-media, devel, linux-kernel, lkcamp
On Mon, Apr 08, 2019 at 01:35:30AM -0300, Arthur Moraes do Lago wrote:
> There were several form feeds(^L) in the file, this patch removes them
> to conform with the coding style.
>
> Signed-off-by: Arthur Moraes do Lago <arthurmoraeslago@gmail.com>
> ---
> drivers/staging/media/zoran/videocodec.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/media/zoran/videocodec.h b/drivers/staging/media/zoran/videocodec.h
> index 4946791fce0d..c37c0e4fb624 100644
> --- a/drivers/staging/media/zoran/videocodec.h
> +++ b/drivers/staging/media/zoran/videocodec.h
> @@ -49,7 +49,7 @@
> device dependent and vary between MJPEG/MPEG/WAVELET/... devices. (!!!!)
> ----------------------------------------------------------------------------
> */
> -\f
> +
>
Checkpatch also complains if you have two consecutive blank lines so
really we should just delete the lines entirely... But this driver is
scheduled for deletion in May. Let's not bother with cleaning it up.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] staging: media: zoran: fix trailing whitespaces
@ 2019-04-08 4:35 Arthur Moraes do Lago
2019-04-08 6:51 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Arthur Moraes do Lago @ 2019-04-08 4:35 UTC (permalink / raw)
To: mchehab, gregkh, mjpeg-users, linux-media, devel, linux-kernel, lkcamp
There were several form feeds(^L) in the file, this patch removes them
to conform with the coding style.
Signed-off-by: Arthur Moraes do Lago <arthurmoraeslago@gmail.com>
---
drivers/staging/media/zoran/videocodec.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/media/zoran/videocodec.h b/drivers/staging/media/zoran/videocodec.h
index 4946791fce0d..c37c0e4fb624 100644
--- a/drivers/staging/media/zoran/videocodec.h
+++ b/drivers/staging/media/zoran/videocodec.h
@@ -49,7 +49,7 @@
device dependent and vary between MJPEG/MPEG/WAVELET/... devices. (!!!!)
----------------------------------------------------------------------------
*/
-\f
+
/* ========================================== */
/* description of the videocodec_io structure */
@@ -96,7 +96,7 @@
the calls include frame numbers and flags (even/odd/...)
if needed and a flag which allows blocking until its ready
*/
-\f
+
/* ============== */
/* user interface */
/* ============== */
@@ -116,7 +116,7 @@ M zr36055[0] 0001 0000c001 00000000 (zr36050[0])
M zr36055[1] 0001 0000c001 00000000 (zr36050[1])
*/
-\f
+
/* =============================================== */
/* special defines for the videocodec_io structure */
@@ -195,7 +195,7 @@ M zr36055[1] 0001 0000c001 00000000 (zr36050[1])
/* -> used in get_image, put_image */
#define CODEC_TRANSFER_KERNEL 0 /* use "memcopy" */
#define CODEC_TRANSFER_USER 1 /* use "to/from_user" */
-\f
+
/* ========================= */
/* the structures itself ... */
@@ -309,7 +309,7 @@ struct videocodec_master {
__u16 reg,
__u32 value);
};
-\f
+
/* ================================================= */
/* function prototypes of the master/slave interface */
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-10 10:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-08 4:55 [PATCH] staging: media: zoran: fix trailing whitespaces Arthur Moraes do Lago
-- strict thread matches above, loose matches on Subject: below --
2019-04-08 4:35 Arthur Moraes do Lago
2019-04-08 6:51 ` Dan Carpenter
2019-04-10 10:44 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).