From: Boris Brezillon <boris.brezillon@collabora.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sakari Ailus <sakari.ailus@iki.fi>,
linux-media@vger.kernel.org
Cc: Tomasz Figa <tfiga@chromium.org>,
Nicolas Dufresne <nicolas@ndufresne.ca>,
kernel@collabora.com,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Alexandre Courbot <acourbot@chromium.org>,
Thierry Reding <thierry.reding@gmail.com>,
Boris Brezillon <boris.brezillon@collabora.com>
Subject: [PATCH RFC 6/6] media: cedrus: Add the H264_DECODING_MODE control
Date: Mon, 3 Jun 2019 13:09:46 +0200 [thread overview]
Message-ID: <20190603110946.4952-7-boris.brezillon@collabora.com> (raw)
In-Reply-To: <20190603110946.4952-1-boris.brezillon@collabora.com>
The H264 uAPI has been modified to expose 2 operation modes: per slice
and per frame decoding.
The cedrus driver only supports per-slice decoding for now.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
---
drivers/staging/media/sunxi/cedrus/cedrus.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/media/sunxi/cedrus/cedrus.c
index 3661c6a04864..fe6e6a12409b 100644
--- a/drivers/staging/media/sunxi/cedrus/cedrus.c
+++ b/drivers/staging/media/sunxi/cedrus/cedrus.c
@@ -76,6 +76,19 @@ static const struct cedrus_control cedrus_controls[] = {
.codec = CEDRUS_CODEC_H264,
.required = true,
},
+ {
+ .cfg.id = V4L2_CID_MPEG_VIDEO_H264_DECODING_MODE,
+ .cfg.type = V4L2_CTRL_TYPE_MENU,
+ /*
+ * Only per-slice decoding is supported for now. Note that we
+ * don't need to extract this control value since only one
+ * value is allowed: V4L2_MPEG_VIDEO_H264_DECODING_PER_SLICE.
+ */
+ .cfg.max = V4L2_MPEG_VIDEO_H264_DECODING_PER_SLICE,
+ .cfg.def = V4L2_MPEG_VIDEO_H264_DECODING_PER_SLICE,
+ .codec = CEDRUS_CODEC_H264,
+ .required = true,
+ },
};
#define CEDRUS_CONTROLS_COUNT ARRAY_SIZE(cedrus_controls)
--
2.20.1
prev parent reply other threads:[~2019-06-03 11:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 11:09 [PATCH RFC 0/6] media: uapi: h264: First batch of adjusments Boris Brezillon
2019-06-03 11:09 ` [PATCH RFC 1/6] media: uapi: h264: Clarify our expectations regarding NAL header format Boris Brezillon
2019-06-03 11:09 ` [PATCH RFC 2/6] media: uapi: h264: Add the concept of decoding mode Boris Brezillon
2019-06-03 12:30 ` Thierry Reding
2019-06-03 12:51 ` Boris Brezillon
2019-06-03 14:05 ` Thierry Reding
2019-06-03 15:37 ` Boris Brezillon
2019-06-04 8:16 ` Thierry Reding
2019-06-05 20:48 ` Paul Kocialkowski
2019-06-06 6:55 ` Boris Brezillon
2019-06-05 20:55 ` Paul Kocialkowski
2019-06-03 11:09 ` [PATCH RFC 3/6] media: uapi: h264: Get rid of the p0/b0/b1 ref-lists Boris Brezillon
2019-06-03 11:09 ` [PATCH RFC 4/6] media: cedrus: Prepare things to support !compound controls Boris Brezillon
2019-06-05 20:57 ` Paul Kocialkowski
2019-06-06 6:58 ` Boris Brezillon
2019-06-03 11:09 ` [PATCH RFC 5/6] media: cedrus: Make the slice_params array size limitation more explicit Boris Brezillon
2019-06-03 21:48 ` Jernej Škrabec
2019-06-03 23:55 ` Nicolas Dufresne
2019-06-04 8:12 ` Thierry Reding
2019-06-04 8:28 ` Boris Brezillon
2019-06-04 14:31 ` Nicolas Dufresne
2019-06-05 21:01 ` Paul Kocialkowski
2019-06-06 6:59 ` Boris Brezillon
2019-06-03 11:09 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603110946.4952-7-boris.brezillon@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=acourbot@chromium.org \
--cc=ezequiel@collabora.com \
--cc=hans.verkuil@cisco.com \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=paul.kocialkowski@bootlin.com \
--cc=sakari.ailus@iki.fi \
--cc=tfiga@chromium.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).