From: Thierry Reding <thierry.reding@gmail.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sakari Ailus <sakari.ailus@iki.fi>,
linux-media@vger.kernel.org, Tomasz Figa <tfiga@chromium.org>,
Nicolas Dufresne <nicolas@ndufresne.ca>,
kernel@collabora.com,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Alexandre Courbot <acourbot@chromium.org>,
Maxime Ripard <maxime.ripard@bootlin.com>
Subject: Re: [PATCH RFC 2/6] media: uapi: h264: Add the concept of decoding mode
Date: Mon, 3 Jun 2019 16:05:26 +0200 [thread overview]
Message-ID: <20190603140526.GF30132@ulmo> (raw)
In-Reply-To: <20190603145058.0c46febd@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 5393 bytes --]
On Mon, Jun 03, 2019 at 02:51:13PM +0200, Boris Brezillon wrote:
> +Maxime
>
> Oops, just realized Maxime was not Cc-ed on this series.
>
> On Mon, 3 Jun 2019 14:30:20 +0200
> Thierry Reding <thierry.reding@gmail.com> wrote:
>
> > On Mon, Jun 03, 2019 at 01:09:42PM +0200, Boris Brezillon wrote:
> > > Some stateless decoders don't support per-slice decoding (or at least
> > > not in a way that would make them efficient or easy to use).
> > > Let's expose a menu to control and expose the supported decoding modes.
> > > Drivers are allowed to support only one decoding but they can support
> > > both too.
> > >
> > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> > > ---
> > > .../media/uapi/v4l/ext-ctrls-codec.rst | 42 ++++++++++++++++++-
> > > drivers/media/v4l2-core/v4l2-ctrls.c | 9 ++++
> > > include/media/h264-ctrls.h | 13 ++++++
> > > 3 files changed, 63 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst b/Documentation/media/uapi/v4l/ext-ctrls-codec.rst
> > > index 82547d5de250..188f625acb7c 100644
> > > --- a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst
> > > +++ b/Documentation/media/uapi/v4l/ext-ctrls-codec.rst
> > > @@ -1748,6 +1748,14 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type -
> > > * - __u32
> > > - ``size``
> > > -
> > > + * - __u32
> > > + - ``start_byte_offset``
> > > + - Where the slice payload starts in the output buffer. Useful when
> > > + operating in per frame decoding mode and decoding multi-slice content.
> > > + In this case, the output buffer will contain more than one slice and
> > > + some codecs need to know where each slice starts. Note that this
> > > + offsets points to the beginning of the slice which is supposed to
> > > + contain an ANNEX B start code
> > > * - __u32
> > > - ``header_bit_size``
> > > -
> > > @@ -1931,7 +1939,10 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type -
> > > -
> > > * - __u16
> > > - ``num_slices``
> > > - - Number of slices needed to decode the current frame
> > > + - Number of slices needed to decode the current frame/field. When
> > > + operating in per-slice decoding mode (see
> > > + :c:type:`v4l2_mpeg_video_h264_decoding_mode`), this field
> > > + should always be set to one
> > > * - __u16
> > > - ``nal_ref_idc``
> > > - NAL reference ID value coming from the NAL Unit header
> > > @@ -2022,6 +2033,35 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type -
> > > - 0x00000004
> > > - The DPB entry is a long term reference frame
> > >
> > > +``V4L2_CID_MPEG_VIDEO_H264_DECODING_MODE (enum)``
> > > + Specifies the decoding mode to use. Currently exposes per slice and per
> > > + frame decoding but new modes might be added later on.
> > > +
> > > + .. note::
> > > +
> > > + This menu control is not yet part of the public kernel API and
> > > + it is expected to change.
> > > +
> > > +.. c:type:: v4l2_mpeg_video_h264_decoding_mode
> > > +
> > > +.. cssclass:: longtable
> > > +
> > > +.. flat-table::
> > > + :header-rows: 0
> > > + :stub-columns: 0
> > > + :widths: 1 1 2
> > > +
> > > + * - ``V4L2_MPEG_VIDEO_H264_DECODING_PER_SLICE``
> > > + - 0
> > > + - The decoding is done per slice. v4l2_ctrl_h264_decode_params->num_slices
> > > + must be set to 1 and the output buffer should contain only one slice.
> >
> > I wonder if we need to be that strict. Wouldn't it be possible for
> > drivers to just iterate over a number of slices and decode each in turn
> > if userspace passed more than one?
> >
> > Or perhaps a decoder can batch queue a couple of slices. I'm not sure
> > how frequent this is, but consider something like a spike in activity on
> > your system, causing some slices to get delayed so you actually get a
> > few buffered up before you get a chance to hand them to the V4L2 device.
> > Processing them all at once may help conceal the lag.
>
> Hm, so we'd be in some kind of slice-batch mode, which means we could
> trigger a decode operation with more than one slice, but not
> necessarily all the slices needed to decode a frame. TBH, supporting
> per-frame (or the batch mode you suggest) on a HW that supports
> per-slice decoding should be pretty simple and has not real impact on
> perfs (as you said, it's just a matter of iterating over all the slices
> attached to a decode operation), so I'm fine relaxing the rule here and
> patching the cedrus driver accordingly (I can't really test the
> changes though). Paul, Maxime, what's your opinion?
We could perhaps have a test program to orchestrate such a scenario. I
think the assumption should obviously still be that we don't cross the
frame boundary using slices in one batch. Just that if a frame was made
up of, say, 4 slices and you first pass 3 slices, then 1, that it'd be
nice if the driver would be able to cope with that. It's something that
could probably even be implemented in the framework as a helper, though
I suspect it'd be just a couple of lines of extra code to wrap a loop
around everything.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-06-03 14:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 11:09 [PATCH RFC 0/6] media: uapi: h264: First batch of adjusments Boris Brezillon
2019-06-03 11:09 ` [PATCH RFC 1/6] media: uapi: h264: Clarify our expectations regarding NAL header format Boris Brezillon
2019-06-03 11:09 ` [PATCH RFC 2/6] media: uapi: h264: Add the concept of decoding mode Boris Brezillon
2019-06-03 12:30 ` Thierry Reding
2019-06-03 12:51 ` Boris Brezillon
2019-06-03 14:05 ` Thierry Reding [this message]
2019-06-03 15:37 ` Boris Brezillon
2019-06-04 8:16 ` Thierry Reding
2019-06-05 20:48 ` Paul Kocialkowski
2019-06-06 6:55 ` Boris Brezillon
2019-06-05 20:55 ` Paul Kocialkowski
2019-06-03 11:09 ` [PATCH RFC 3/6] media: uapi: h264: Get rid of the p0/b0/b1 ref-lists Boris Brezillon
2019-06-03 11:09 ` [PATCH RFC 4/6] media: cedrus: Prepare things to support !compound controls Boris Brezillon
2019-06-05 20:57 ` Paul Kocialkowski
2019-06-06 6:58 ` Boris Brezillon
2019-06-03 11:09 ` [PATCH RFC 5/6] media: cedrus: Make the slice_params array size limitation more explicit Boris Brezillon
2019-06-03 21:48 ` Jernej Škrabec
2019-06-03 23:55 ` Nicolas Dufresne
2019-06-04 8:12 ` Thierry Reding
2019-06-04 8:28 ` Boris Brezillon
2019-06-04 14:31 ` Nicolas Dufresne
2019-06-05 21:01 ` Paul Kocialkowski
2019-06-06 6:59 ` Boris Brezillon
2019-06-03 11:09 ` [PATCH RFC 6/6] media: cedrus: Add the H264_DECODING_MODE control Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603140526.GF30132@ulmo \
--to=thierry.reding@gmail.com \
--cc=acourbot@chromium.org \
--cc=boris.brezillon@collabora.com \
--cc=ezequiel@collabora.com \
--cc=hans.verkuil@cisco.com \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=paul.kocialkowski@bootlin.com \
--cc=sakari.ailus@iki.fi \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).