* [PATCH 0/8] fix warnings for same module names
@ 2019-06-06 9:46 Anders Roxell
2019-06-06 10:10 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 3+ messages in thread
From: Anders Roxell @ 2019-06-06 9:46 UTC (permalink / raw)
To: andrew, vivien.didelot, f.fainelli, marex, stefan, airlied,
daniel, shawnguo, s.hauer, b.zolnierkie, a.hajda, mchehab,
p.zabel, hkallweit1, lee.jones, lgirdwood, broonie, davem
Cc: netdev, linux-kernel, dri-devel, linux-arm-kernel, linux-fbdev,
linux-media, Anders Roxell
Hi,
This patch set addresses warnings that module names are named the
same, this may lead to a problem that wrong module gets loaded or if one
of the two same-name modules exports a symbol, this can confuse the
dependency resolution. and the build may fail.
Patch "drivers: net: dsa: realtek: fix warning same module names" and
"drivers: net: phy: realtek: fix warning same module names" resolves the
name clatch realtek.ko.
warning: same module names found:
drivers/net/phy/realtek.ko
drivers/net/dsa/realtek.ko
Patch "drivers: (video|gpu): fix warning same module names" resolves
the name clatch mxsfb.ko.
warning: same module names found:
drivers/video/fbdev/mxsfb.ko
drivers/gpu/drm/mxsfb/mxsfb.ko
Patch "drivers: media: i2c: fix warning same module names" resolves the
name clatch adv7511.ko however, it seams to refer to the same device
name in i2c_device_id, does anyone have any guidance how that should be
solved?
warning: same module names found:
drivers/gpu/drm/bridge/adv7511/adv7511.ko
drivers/media/i2c/adv7511.ko
Patch "drivers: media: coda: fix warning same module names" resolves the
name clatch coda.ko.
warning: same module names found:
fs/coda/coda.ko
drivers/media/platform/coda/coda.ko
Patch "drivers: net: phy: fix warning same module names" resolves the
name clatch asix.ko.
warning: same module names found:
drivers/net/phy/asix.ko
drivers/net/usb/asix.ko
Patch "drivers: mfd: 88pm800: fix warning same module names" and
"drivers: regulator: 88pm800: fix warning same module names" resolves
the name clatch 88pm800.ko.
warning: same module names found:
drivers/regulator/88pm800.ko
drivers/mfd/88pm800.ko
Cheers,
Anders
Anders Roxell (8):
drivers: net: dsa: realtek: fix warning same module names
drivers: net: phy: realtek: fix warning same module names
drivers: (video|gpu): fix warning same module names
drivers: media: i2c: fix warning same module names
drivers: media: coda: fix warning same module names
drivers: net: phy: fix warning same module names
drivers: mfd: 88pm800: fix warning same module names
drivers: regulator: 88pm800: fix warning same module names
drivers/gpu/drm/bridge/adv7511/Makefile | 10 +++++-----
drivers/gpu/drm/mxsfb/Makefile | 4 ++--
drivers/media/i2c/Makefile | 3 ++-
drivers/media/platform/coda/Makefile | 4 ++--
drivers/mfd/Makefile | 7 +++++--
drivers/net/dsa/Makefile | 4 ++--
drivers/net/phy/Makefile | 6 ++++--
drivers/regulator/Makefile | 3 ++-
drivers/video/fbdev/Makefile | 3 ++-
9 files changed, 26 insertions(+), 18 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 0/8] fix warnings for same module names
2019-06-06 9:46 [PATCH 0/8] fix warnings for same module names Anders Roxell
@ 2019-06-06 10:10 ` Mauro Carvalho Chehab
2019-06-10 12:58 ` Anders Roxell
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2019-06-06 10:10 UTC (permalink / raw)
To: Anders Roxell
Cc: andrew, vivien.didelot, f.fainelli, marex, stefan, airlied,
daniel, shawnguo, s.hauer, b.zolnierkie, a.hajda, p.zabel,
hkallweit1, lee.jones, lgirdwood, broonie, davem, netdev,
linux-kernel, dri-devel, linux-arm-kernel, linux-fbdev,
linux-media
Em Thu, 6 Jun 2019 11:46:57 +0200
Anders Roxell <anders.roxell@linaro.org> escreveu:
> Hi,
>
> This patch set addresses warnings that module names are named the
> same, this may lead to a problem that wrong module gets loaded or if one
> of the two same-name modules exports a symbol, this can confuse the
> dependency resolution. and the build may fail.
>
>
> Patch "drivers: net: dsa: realtek: fix warning same module names" and
> "drivers: net: phy: realtek: fix warning same module names" resolves the
> name clatch realtek.ko.
>
> warning: same module names found:
> drivers/net/phy/realtek.ko
> drivers/net/dsa/realtek.ko
>
>
> Patch "drivers: (video|gpu): fix warning same module names" resolves
> the name clatch mxsfb.ko.
>
> warning: same module names found:
> drivers/video/fbdev/mxsfb.ko
> drivers/gpu/drm/mxsfb/mxsfb.ko
>
> Patch "drivers: media: i2c: fix warning same module names" resolves the
> name clatch adv7511.ko however, it seams to refer to the same device
> name in i2c_device_id, does anyone have any guidance how that should be
> solved?
>
> warning: same module names found:
> drivers/gpu/drm/bridge/adv7511/adv7511.ko
> drivers/media/i2c/adv7511.ko
>
>
> Patch "drivers: media: coda: fix warning same module names" resolves the
> name clatch coda.ko.
>
> warning: same module names found:
> fs/coda/coda.ko
> drivers/media/platform/coda/coda.ko
Media change look ok, and probably the other patches too, but the
problem here is: who will apply it and when.
The way you grouped the changes makes harder for subsystem maintainers
to pick, as the same patch touches multiple subsystems.
On the other hand, if this gets picked by someone else, it has the
potential to cause conflicts between linux-next and the maintainer's
tree.
So, the best would be if you re-arrange this series to submit one
patch per subsystem.
>
>
> Patch "drivers: net: phy: fix warning same module names" resolves the
> name clatch asix.ko.
>
> warning: same module names found:
> drivers/net/phy/asix.ko
> drivers/net/usb/asix.ko
>
> Patch "drivers: mfd: 88pm800: fix warning same module names" and
> "drivers: regulator: 88pm800: fix warning same module names" resolves
> the name clatch 88pm800.ko.
>
> warning: same module names found:
> drivers/regulator/88pm800.ko
> drivers/mfd/88pm800.ko
>
>
> Cheers,
> Anders
>
> Anders Roxell (8):
> drivers: net: dsa: realtek: fix warning same module names
> drivers: net: phy: realtek: fix warning same module names
> drivers: (video|gpu): fix warning same module names
> drivers: media: i2c: fix warning same module names
> drivers: media: coda: fix warning same module names
> drivers: net: phy: fix warning same module names
> drivers: mfd: 88pm800: fix warning same module names
> drivers: regulator: 88pm800: fix warning same module names
>
> drivers/gpu/drm/bridge/adv7511/Makefile | 10 +++++-----
> drivers/gpu/drm/mxsfb/Makefile | 4 ++--
> drivers/media/i2c/Makefile | 3 ++-
> drivers/media/platform/coda/Makefile | 4 ++--
> drivers/mfd/Makefile | 7 +++++--
> drivers/net/dsa/Makefile | 4 ++--
> drivers/net/phy/Makefile | 6 ++++--
> drivers/regulator/Makefile | 3 ++-
> drivers/video/fbdev/Makefile | 3 ++-
> 9 files changed, 26 insertions(+), 18 deletions(-)
>
Thanks,
Mauro
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 0/8] fix warnings for same module names
2019-06-06 10:10 ` Mauro Carvalho Chehab
@ 2019-06-10 12:58 ` Anders Roxell
0 siblings, 0 replies; 3+ messages in thread
From: Anders Roxell @ 2019-06-10 12:58 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: andrew, vivien.didelot, f.fainelli, marex, stefan, David Airlie,
Daniel Vetter, shawnguo, s.hauer, b.zolnierkie, a.hajda, p.zabel,
hkallweit1, Lee Jones, Liam Girdwood, Mark Brown, David Miller,
Networking, Linux Kernel Mailing List, dri-devel, Linux ARM,
linux-fbdev, linux-media
On Thu, 6 Jun 2019 at 12:11, Mauro Carvalho Chehab <mchehab@kernel.org> wrote:
>
> Em Thu, 6 Jun 2019 11:46:57 +0200
> Anders Roxell <anders.roxell@linaro.org> escreveu:
>
> > Hi,
> >
> > This patch set addresses warnings that module names are named the
> > same, this may lead to a problem that wrong module gets loaded or if one
> > of the two same-name modules exports a symbol, this can confuse the
> > dependency resolution. and the build may fail.
> >
> >
> > Patch "drivers: net: dsa: realtek: fix warning same module names" and
> > "drivers: net: phy: realtek: fix warning same module names" resolves the
> > name clatch realtek.ko.
> >
> > warning: same module names found:
> > drivers/net/phy/realtek.ko
> > drivers/net/dsa/realtek.ko
> >
> >
> > Patch "drivers: (video|gpu): fix warning same module names" resolves
> > the name clatch mxsfb.ko.
> >
> > warning: same module names found:
> > drivers/video/fbdev/mxsfb.ko
> > drivers/gpu/drm/mxsfb/mxsfb.ko
> >
> > Patch "drivers: media: i2c: fix warning same module names" resolves the
> > name clatch adv7511.ko however, it seams to refer to the same device
> > name in i2c_device_id, does anyone have any guidance how that should be
> > solved?
> >
> > warning: same module names found:
> > drivers/gpu/drm/bridge/adv7511/adv7511.ko
> > drivers/media/i2c/adv7511.ko
> >
> >
> > Patch "drivers: media: coda: fix warning same module names" resolves the
> > name clatch coda.ko.
> >
> > warning: same module names found:
> > fs/coda/coda.ko
> > drivers/media/platform/coda/coda.ko
>
> Media change look ok, and probably the other patches too, but the
> problem here is: who will apply it and when.
>
> The way you grouped the changes makes harder for subsystem maintainers
> to pick, as the same patch touches multiple subsystems.
>
> On the other hand, if this gets picked by someone else, it has the
> potential to cause conflicts between linux-next and the maintainer's
> tree.
>
> So, the best would be if you re-arrange this series to submit one
> patch per subsystem.
I will send it per subsystem.
Cheers,
Anders
>
>
> >
> >
> > Patch "drivers: net: phy: fix warning same module names" resolves the
> > name clatch asix.ko.
> >
> > warning: same module names found:
> > drivers/net/phy/asix.ko
> > drivers/net/usb/asix.ko
> >
> > Patch "drivers: mfd: 88pm800: fix warning same module names" and
> > "drivers: regulator: 88pm800: fix warning same module names" resolves
> > the name clatch 88pm800.ko.
> >
> > warning: same module names found:
> > drivers/regulator/88pm800.ko
> > drivers/mfd/88pm800.ko
> >
> >
> > Cheers,
> > Anders
> >
> > Anders Roxell (8):
> > drivers: net: dsa: realtek: fix warning same module names
> > drivers: net: phy: realtek: fix warning same module names
> > drivers: (video|gpu): fix warning same module names
> > drivers: media: i2c: fix warning same module names
> > drivers: media: coda: fix warning same module names
> > drivers: net: phy: fix warning same module names
> > drivers: mfd: 88pm800: fix warning same module names
> > drivers: regulator: 88pm800: fix warning same module names
> >
> > drivers/gpu/drm/bridge/adv7511/Makefile | 10 +++++-----
> > drivers/gpu/drm/mxsfb/Makefile | 4 ++--
> > drivers/media/i2c/Makefile | 3 ++-
> > drivers/media/platform/coda/Makefile | 4 ++--
> > drivers/mfd/Makefile | 7 +++++--
> > drivers/net/dsa/Makefile | 4 ++--
> > drivers/net/phy/Makefile | 6 ++++--
> > drivers/regulator/Makefile | 3 ++-
> > drivers/video/fbdev/Makefile | 3 ++-
> > 9 files changed, 26 insertions(+), 18 deletions(-)
> >
>
>
>
> Thanks,
> Mauro
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-10 12:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-06 9:46 [PATCH 0/8] fix warnings for same module names Anders Roxell
2019-06-06 10:10 ` Mauro Carvalho Chehab
2019-06-10 12:58 ` Anders Roxell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).