From: Sean Young <sean@mess.org>
To: JP <jp@jpvw.nl>
Cc: linux-media@vger.kernel.org,
Michael Ira Krufky <mkrufky@linuxtv.org>,
Antti Palosaari <crope@iki.fi>,
Frantisek Rysanek <Frantisek.Rysanek@post.cz>
Subject: Re: [PATCH 1/2] dvbsky: add support for "Mygica T230C v2"
Date: Mon, 8 Jul 2019 11:04:55 +0100 [thread overview]
Message-ID: <20190708100454.xwa4f64umoccwvca@gofer.mess.org> (raw)
In-Reply-To: <e87ac093-6466-4cd4-3346-1db17ae85495@jpvw.nl>
Hallo Jan-Pieter,
> On 6/25/19 1:16 PM, Sean Young wrote:
> > On Sun, Jun 16, 2019 at 02:39:29AM +0200, Jan Pieter van Woerkom wrote:
> > > From: Jan Pieter van Woerkom <jp@jpvw.nl>
> > >
> > > Adds support for the "Mygica T230C v2" into the "dvbsky" driver.
> > > A small enhancement is also needed in the si2168 demodulator
> > > driver, and a USB device ID in dvb-usb-ids.h .
> > >
> > > This is v3.3 of the proposed patch, based on feedback from Sean
> > > Young and Antti Palosaari.
> > > Tested by patch author on a T230C v2.
> > > Tested by Frank Rysanek on a T230C v2: can tune into locally
> > > available DVB-T and DVB-T2 muxes, video and audio playback works.
> > > Applies cleanly against Linux 5.1.10 .
> > >
> > > The T230C v2 hardware needs a mode of the si2168 chip to be
> > > set for which the si2168 driver previously had no support.
> > > This patch uses a specific measure to configure this on the
> > > T230C v2 hardware only - see the flag passed via the ts_mode
> > > attribute and its dependency on USB_PID_MYGICA_T230C2. Other
> > > devices using the si2168 demodulator driver are not affected
> > > in any way.
> > >
> > > Signed-off-by: Jan Pieter van Woerkom <jp@jpvw.nl>
> > > Tested-by: Frank Rysanek <Frantisek.Rysanek@post.cz>
> > > ---
> > > diff -ru a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
> > > --- a/drivers/media/dvb-frontends/si2168.c 2019-06-04 07:59:45.000000000 +0200
> > > +++ b/drivers/media/dvb-frontends/si2168.c 2019-06-08 19:47:32.385526558 +0200
> > > @@ -91,8 +91,18 @@
> > > dev_dbg(&client->dev, "%s acquire: %d\n", __func__, acquire);
> > > + /* set manual value */
> > > + if (dev->ts_mode | SI2168_TS_CLK_MANUAL) {
> > This looks wrong. Should it not be "dev->ts_mode & SI2168_TS_CLK_MANUAL"?
> > Now the expression is always true.
> You're absolutely right. Silly me.
>
> What now? Correct and repost?
Yes, please. I don't have the hardware to test so it would be great if
you could repost a tested version, so we can merged that.
Thanks,
Sean
next prev parent reply other threads:[~2019-07-08 10:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-16 0:39 [PATCH 1/2] dvbsky: add support for "Mygica T230C v2" Jan Pieter van Woerkom
2019-06-16 0:44 ` [PATCH 2/2] " Jan Pieter van Woerkom
2019-06-25 11:16 ` [PATCH 1/2] " Sean Young
2019-06-25 15:41 ` JP
2019-06-25 15:54 ` Antti Palosaari
2019-07-08 10:04 ` Sean Young [this message]
2019-07-08 23:08 ` JP
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708100454.xwa4f64umoccwvca@gofer.mess.org \
--to=sean@mess.org \
--cc=Frantisek.Rysanek@post.cz \
--cc=crope@iki.fi \
--cc=jp@jpvw.nl \
--cc=linux-media@vger.kernel.org \
--cc=mkrufky@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).