* [PATCH] am437x: remove unused struct vpfe_pixel_format
@ 2019-07-23 12:59 Hans Verkuil
2019-07-24 13:39 ` Lad, Prabhakar
2019-08-01 12:35 ` Benoit Parrot
0 siblings, 2 replies; 3+ messages in thread
From: Hans Verkuil @ 2019-07-23 12:59 UTC (permalink / raw)
To: Linux Media Mailing List, Benoit Parrot; +Cc: Prabhakar Lad
struct vpfe_pixel_format was defined, but never used. Remove it.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
diff --git a/drivers/media/platform/am437x/am437x-vpfe.h b/drivers/media/platform/am437x/am437x-vpfe.h
index 17d7aa426788..4678285f34c6 100644
--- a/drivers/media/platform/am437x/am437x-vpfe.h
+++ b/drivers/media/platform/am437x/am437x-vpfe.h
@@ -65,12 +65,6 @@ struct vpfe_hw_if_param {
#define VPFE_MAX_SUBDEV 1
#define VPFE_MAX_INPUTS 1
-struct vpfe_pixel_format {
- struct v4l2_fmtdesc fmtdesc;
- /* bytes per pixel */
- int bpp;
-};
-
struct vpfe_std_info {
int active_pixels;
int active_lines;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] am437x: remove unused struct vpfe_pixel_format
2019-07-23 12:59 [PATCH] am437x: remove unused struct vpfe_pixel_format Hans Verkuil
@ 2019-07-24 13:39 ` Lad, Prabhakar
2019-08-01 12:35 ` Benoit Parrot
1 sibling, 0 replies; 3+ messages in thread
From: Lad, Prabhakar @ 2019-07-24 13:39 UTC (permalink / raw)
To: Hans Verkuil; +Cc: Linux Media Mailing List, Benoit Parrot
Hi Hans,
Thank you for the patch.
On Tue, Jul 23, 2019 at 1:59 PM Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
> struct vpfe_pixel_format was defined, but never used. Remove it.
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> ---
> diff --git a/drivers/media/platform/am437x/am437x-vpfe.h b/drivers/media/platform/am437x/am437x-vpfe.h
> index 17d7aa426788..4678285f34c6 100644
> --- a/drivers/media/platform/am437x/am437x-vpfe.h
> +++ b/drivers/media/platform/am437x/am437x-vpfe.h
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Regards,
--Prabhakar Lad
> @@ -65,12 +65,6 @@ struct vpfe_hw_if_param {
> #define VPFE_MAX_SUBDEV 1
> #define VPFE_MAX_INPUTS 1
>
> -struct vpfe_pixel_format {
> - struct v4l2_fmtdesc fmtdesc;
> - /* bytes per pixel */
> - int bpp;
> -};
> -
> struct vpfe_std_info {
> int active_pixels;
> int active_lines;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] am437x: remove unused struct vpfe_pixel_format
2019-07-23 12:59 [PATCH] am437x: remove unused struct vpfe_pixel_format Hans Verkuil
2019-07-24 13:39 ` Lad, Prabhakar
@ 2019-08-01 12:35 ` Benoit Parrot
1 sibling, 0 replies; 3+ messages in thread
From: Benoit Parrot @ 2019-08-01 12:35 UTC (permalink / raw)
To: Hans Verkuil; +Cc: Linux Media Mailing List, Prabhakar Lad
Hans Verkuil <hverkuil@xs4all.nl> wrote on Tue [2019-Jul-23 14:59:47 +0200]:
> struct vpfe_pixel_format was defined, but never used. Remove it.
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> ---
> diff --git a/drivers/media/platform/am437x/am437x-vpfe.h b/drivers/media/platform/am437x/am437x-vpfe.h
> index 17d7aa426788..4678285f34c6 100644
> --- a/drivers/media/platform/am437x/am437x-vpfe.h
> +++ b/drivers/media/platform/am437x/am437x-vpfe.h
> @@ -65,12 +65,6 @@ struct vpfe_hw_if_param {
> #define VPFE_MAX_SUBDEV 1
> #define VPFE_MAX_INPUTS 1
>
> -struct vpfe_pixel_format {
> - struct v4l2_fmtdesc fmtdesc;
> - /* bytes per pixel */
> - int bpp;
> -};
> -
Looks fine to me.
Acked-by: Benoit Parrot <bparrot@ti.com>
> struct vpfe_std_info {
> int active_pixels;
> int active_lines;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-01 12:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-23 12:59 [PATCH] am437x: remove unused struct vpfe_pixel_format Hans Verkuil
2019-07-24 13:39 ` Lad, Prabhakar
2019-08-01 12:35 ` Benoit Parrot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).