* [PATCH] media: dvb_dummy_fe: place EXPORT_SYMBOL below corresponding function
@ 2019-11-06 18:37 Daniel W. S. Almeida
2019-11-06 18:52 ` Shuah Khan
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Daniel W. S. Almeida @ 2019-11-06 18:37 UTC (permalink / raw)
To: mchehab, rfontana, gregkh, allison, kstewart, tglx
Cc: Daniel W. S. Almeida, linux-media, linux-kernel, skhan
From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
Suggested-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
---
drivers/media/dvb-frontends/dvb_dummy_fe.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/media/dvb-frontends/dvb_dummy_fe.c b/drivers/media/dvb-frontends/dvb_dummy_fe.c
index 4db679cb70ad..909dac2345c4 100644
--- a/drivers/media/dvb-frontends/dvb_dummy_fe.c
+++ b/drivers/media/dvb-frontends/dvb_dummy_fe.c
@@ -121,6 +121,7 @@ struct dvb_frontend* dvb_dummy_fe_ofdm_attach(void)
state->frontend.demodulator_priv = state;
return &state->frontend;
}
+EXPORT_SYMBOL(dvb_dummy_fe_ofdm_attach);
static const struct dvb_frontend_ops dvb_dummy_fe_qpsk_ops;
@@ -138,6 +139,7 @@ struct dvb_frontend *dvb_dummy_fe_qpsk_attach(void)
state->frontend.demodulator_priv = state;
return &state->frontend;
}
+EXPORT_SYMBOL(dvb_dummy_fe_qpsk_attach);
static const struct dvb_frontend_ops dvb_dummy_fe_qam_ops;
@@ -155,6 +157,7 @@ struct dvb_frontend *dvb_dummy_fe_qam_attach(void)
state->frontend.demodulator_priv = state;
return &state->frontend;
}
+EXPORT_SYMBOL(dvb_dummy_fe_qam_attach);
static const struct dvb_frontend_ops dvb_dummy_fe_ofdm_ops = {
.delsys = { SYS_DVBT },
@@ -253,7 +256,3 @@ static const struct dvb_frontend_ops dvb_dummy_fe_qpsk_ops = {
MODULE_DESCRIPTION("DVB DUMMY Frontend");
MODULE_AUTHOR("Emard");
MODULE_LICENSE("GPL");
-
-EXPORT_SYMBOL(dvb_dummy_fe_ofdm_attach);
-EXPORT_SYMBOL(dvb_dummy_fe_qam_attach);
-EXPORT_SYMBOL(dvb_dummy_fe_qpsk_attach);
--
2.24.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] media: dvb_dummy_fe: place EXPORT_SYMBOL below corresponding function
2019-11-06 18:37 [PATCH] media: dvb_dummy_fe: place EXPORT_SYMBOL below corresponding function Daniel W. S. Almeida
@ 2019-11-06 18:52 ` Shuah Khan
2019-11-06 18:53 ` Fabio Estevam
2019-11-30 6:50 ` Mauro Carvalho Chehab
2 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2019-11-06 18:52 UTC (permalink / raw)
To: Daniel W. S. Almeida, mchehab, rfontana, gregkh, allison, kstewart, tglx
Cc: linux-media, linux-kernel, skh >> Shuah Khan
On 11/6/19 11:37 AM, Daniel W. S. Almeida wrote:
> From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
>
You are missing the commit message. :)
> Suggested-by: Shuah Khan <skhan@linuxfoundation.org>
> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
> ---
> drivers/media/dvb-frontends/dvb_dummy_fe.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/dvb-frontends/dvb_dummy_fe.c b/drivers/media/dvb-frontends/dvb_dummy_fe.c
> index 4db679cb70ad..909dac2345c4 100644
> --- a/drivers/media/dvb-frontends/dvb_dummy_fe.c
> +++ b/drivers/media/dvb-frontends/dvb_dummy_fe.c
> @@ -121,6 +121,7 @@ struct dvb_frontend* dvb_dummy_fe_ofdm_attach(void)
> state->frontend.demodulator_priv = state;
> return &state->frontend;
> }
> +EXPORT_SYMBOL(dvb_dummy_fe_ofdm_attach);
>
> static const struct dvb_frontend_ops dvb_dummy_fe_qpsk_ops;
>
> @@ -138,6 +139,7 @@ struct dvb_frontend *dvb_dummy_fe_qpsk_attach(void)
> state->frontend.demodulator_priv = state;
> return &state->frontend;
> }
> +EXPORT_SYMBOL(dvb_dummy_fe_qpsk_attach);
>
> static const struct dvb_frontend_ops dvb_dummy_fe_qam_ops;
>
> @@ -155,6 +157,7 @@ struct dvb_frontend *dvb_dummy_fe_qam_attach(void)
> state->frontend.demodulator_priv = state;
> return &state->frontend;
> }
> +EXPORT_SYMBOL(dvb_dummy_fe_qam_attach);
>
> static const struct dvb_frontend_ops dvb_dummy_fe_ofdm_ops = {
> .delsys = { SYS_DVBT },
> @@ -253,7 +256,3 @@ static const struct dvb_frontend_ops dvb_dummy_fe_qpsk_ops = {
> MODULE_DESCRIPTION("DVB DUMMY Frontend");
> MODULE_AUTHOR("Emard");
> MODULE_LICENSE("GPL");
> -
> -EXPORT_SYMBOL(dvb_dummy_fe_ofdm_attach);
> -EXPORT_SYMBOL(dvb_dummy_fe_qam_attach);
> -EXPORT_SYMBOL(dvb_dummy_fe_qpsk_attach);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] media: dvb_dummy_fe: place EXPORT_SYMBOL below corresponding function
2019-11-06 18:37 [PATCH] media: dvb_dummy_fe: place EXPORT_SYMBOL below corresponding function Daniel W. S. Almeida
2019-11-06 18:52 ` Shuah Khan
@ 2019-11-06 18:53 ` Fabio Estevam
2019-11-30 6:50 ` Mauro Carvalho Chehab
2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2019-11-06 18:53 UTC (permalink / raw)
To: Daniel W. S. Almeida
Cc: Mauro Carvalho Chehab, rfontana, Greg Kroah-Hartman, allison,
Kate Stewart, Thomas Gleixner, linux-media, linux-kernel, skhan
Hi Daniel,
On Wed, Nov 6, 2019 at 3:51 PM Daniel W. S. Almeida
<dwlsalmeida@gmail.com> wrote:
>
> From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
Please write a commit log.
> Suggested-by: Shuah Khan <skhan@linuxfoundation.org>
> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] media: dvb_dummy_fe: place EXPORT_SYMBOL below corresponding function
2019-11-06 18:37 [PATCH] media: dvb_dummy_fe: place EXPORT_SYMBOL below corresponding function Daniel W. S. Almeida
2019-11-06 18:52 ` Shuah Khan
2019-11-06 18:53 ` Fabio Estevam
@ 2019-11-30 6:50 ` Mauro Carvalho Chehab
2 siblings, 0 replies; 4+ messages in thread
From: Mauro Carvalho Chehab @ 2019-11-30 6:50 UTC (permalink / raw)
To: Daniel W. S. Almeida
Cc: rfontana, gregkh, allison, kstewart, tglx, linux-media,
linux-kernel, skhan
Em Wed, 6 Nov 2019 15:37:16 -0300
"Daniel W. S. Almeida" <dwlsalmeida@gmail.com> escreveu:
> From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
>
> Suggested-by: Shuah Khan <skhan@linuxfoundation.org>
> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
Looks OK on my eyes.
> ---
> drivers/media/dvb-frontends/dvb_dummy_fe.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/dvb-frontends/dvb_dummy_fe.c b/drivers/media/dvb-frontends/dvb_dummy_fe.c
> index 4db679cb70ad..909dac2345c4 100644
> --- a/drivers/media/dvb-frontends/dvb_dummy_fe.c
> +++ b/drivers/media/dvb-frontends/dvb_dummy_fe.c
> @@ -121,6 +121,7 @@ struct dvb_frontend* dvb_dummy_fe_ofdm_attach(void)
> state->frontend.demodulator_priv = state;
> return &state->frontend;
> }
> +EXPORT_SYMBOL(dvb_dummy_fe_ofdm_attach);
>
> static const struct dvb_frontend_ops dvb_dummy_fe_qpsk_ops;
>
> @@ -138,6 +139,7 @@ struct dvb_frontend *dvb_dummy_fe_qpsk_attach(void)
> state->frontend.demodulator_priv = state;
> return &state->frontend;
> }
> +EXPORT_SYMBOL(dvb_dummy_fe_qpsk_attach);
>
> static const struct dvb_frontend_ops dvb_dummy_fe_qam_ops;
>
> @@ -155,6 +157,7 @@ struct dvb_frontend *dvb_dummy_fe_qam_attach(void)
> state->frontend.demodulator_priv = state;
> return &state->frontend;
> }
> +EXPORT_SYMBOL(dvb_dummy_fe_qam_attach);
>
> static const struct dvb_frontend_ops dvb_dummy_fe_ofdm_ops = {
> .delsys = { SYS_DVBT },
> @@ -253,7 +256,3 @@ static const struct dvb_frontend_ops dvb_dummy_fe_qpsk_ops = {
> MODULE_DESCRIPTION("DVB DUMMY Frontend");
> MODULE_AUTHOR("Emard");
> MODULE_LICENSE("GPL");
> -
> -EXPORT_SYMBOL(dvb_dummy_fe_ofdm_attach);
> -EXPORT_SYMBOL(dvb_dummy_fe_qam_attach);
> -EXPORT_SYMBOL(dvb_dummy_fe_qpsk_attach);
Cheers,
Mauro
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-30 6:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06 18:37 [PATCH] media: dvb_dummy_fe: place EXPORT_SYMBOL below corresponding function Daniel W. S. Almeida
2019-11-06 18:52 ` Shuah Khan
2019-11-06 18:53 ` Fabio Estevam
2019-11-30 6:50 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).