linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V3] media: ov5640: Fix check for PLL1 exceeding max allowed rate
@ 2019-12-04 13:35 Adam Ford
  0 siblings, 0 replies; only message in thread
From: Adam Ford @ 2019-12-04 13:35 UTC (permalink / raw)
  To: linux-media
  Cc: adam.ford, maxime.ripard, Adam Ford, Jacopo Mondi,
	Steve Longerbeam, Mauro Carvalho Chehab, linux-kernel

The PLL calculation routine checks the wrong variable name 'rate'
when it should be called '_rate' when checking to see whether or
not the PLL1 output frequency exceeds 1GHz.

This patch changes it to the correct variable '_rate'

Fixes: aa2882481cad ("media: ov5640: Adjust the clock based on the expected rate")

Acked-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Adam Ford <aford173@gmail.com>
---
V3:  Add Fixes Tag.
V2:  No code change.  Only change commit description to be less confusing.

diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index 500d9bbff10b..a3c0be56ae02 100644
--- a/drivers/media/i2c/ov5640.c
+++ b/drivers/media/i2c/ov5640.c
@@ -874,7 +874,7 @@ static unsigned long ov5640_calc_sys_clk(struct ov5640_dev *sensor,
 			 * We have reached the maximum allowed PLL1 output,
 			 * increase sysdiv.
 			 */
-			if (!rate)
+			if (!_rate)
 				break;
 
 			/*
-- 
2.20.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-12-04 13:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-04 13:35 [PATCH V3] media: ov5640: Fix check for PLL1 exceeding max allowed rate Adam Ford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).