* [PATCH] dt-bindings: media: Convert Allwinner hardware codec to a schema
@ 2019-12-13 7:40 Maxime Ripard
2019-12-13 15:25 ` Rob Herring
2019-12-18 1:56 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Maxime Ripard @ 2019-12-13 7:40 UTC (permalink / raw)
To: Mark Rutland, Rob Herring, Frank Rowand
Cc: Chen-Yu Tsai, Maxime Ripard, devicetree, linux-arm-kernel,
mchehab, linux-media, Maxime Ripard
The Allwinner SoCs have a hardware video codec that is supported in Linux,
with a matching Device Tree binding.
Now that we have the DT validation in place, let's convert the device tree
bindings for that controller over to a YAML schemas.
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
.../allwinner,sun4i-a10-video-engine.yaml | 83 +++++++++++++++++++
.../devicetree/bindings/media/cedrus.txt | 57 -------------
2 files changed, 83 insertions(+), 57 deletions(-)
create mode 100644 Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
delete mode 100644 Documentation/devicetree/bindings/media/cedrus.txt
diff --git a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
new file mode 100644
index 000000000000..47c8513555b2
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
@@ -0,0 +1,83 @@
+# SPDX-License-Identifier: GPL-2.0+
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/allwinner,sun4i-a10-video-engine.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Allwinner A10 Video Engine Device Tree Bindings
+
+maintainers:
+ - Chen-Yu Tsai <wens@csie.org>
+ - Maxime Ripard <mripard@kernel.org>
+
+properties:
+ compatible:
+ enum:
+ - allwinner,sun4i-a10-video-engine
+ - allwinner,sun5i-a13-video-engine
+ - allwinner,sun7i-a20-video-engine
+ - allwinner,sun8i-a33-video-engine
+ - allwinner,sun8i-h3-video-engine
+ - allwinner,sun50i-a64-video-engine
+ - allwinner,sun50i-h5-video-engine
+ - allwinner,sun50i-h6-video-engine
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: Bus Clock
+ - description: Module Clock
+ - description: RAM Clock
+
+ clock-names:
+ items:
+ - const: ahb
+ - const: mod
+ - const: ram
+
+ resets:
+ maxItems: 1
+
+ allwinner,sram:
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ description: Phandle to the device SRAM
+
+ memory-region:
+ description:
+ CMA pool to use for buffers allocation instead of the default
+ CMA pool.
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+ - resets
+ - allwinner,sram
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/sun7i-a20-ccu.h>
+ #include <dt-bindings/reset/sun4i-a10-ccu.h>
+
+ video-codec@1c0e000 {
+ compatible = "allwinner,sun7i-a20-video-engine";
+ reg = <0x01c0e000 0x1000>;
+ interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&ccu CLK_AHB_VE>, <&ccu CLK_VE>,
+ <&ccu CLK_DRAM_VE>;
+ clock-names = "ahb", "mod", "ram";
+ resets = <&ccu RST_VE>;
+ allwinner,sram = <&ve_sram 1>;
+ };
+
+...
diff --git a/Documentation/devicetree/bindings/media/cedrus.txt b/Documentation/devicetree/bindings/media/cedrus.txt
deleted file mode 100644
index 20c82fb0c343..000000000000
--- a/Documentation/devicetree/bindings/media/cedrus.txt
+++ /dev/null
@@ -1,57 +0,0 @@
-Device-tree bindings for the VPU found in Allwinner SoCs, referred to as the
-Video Engine (VE) in Allwinner literature.
-
-The VPU can only access the first 256 MiB of DRAM, that are DMA-mapped starting
-from the DRAM base. This requires specific memory allocation and handling.
-
-Required properties:
-- compatible : must be one of the following compatibles:
- - "allwinner,sun4i-a10-video-engine"
- - "allwinner,sun5i-a13-video-engine"
- - "allwinner,sun7i-a20-video-engine"
- - "allwinner,sun8i-a33-video-engine"
- - "allwinner,sun8i-h3-video-engine"
- - "allwinner,sun50i-a64-video-engine"
- - "allwinner,sun50i-h5-video-engine"
- - "allwinner,sun50i-h6-video-engine"
-- reg : register base and length of VE;
-- clocks : list of clock specifiers, corresponding to entries in
- the clock-names property;
-- clock-names : should contain "ahb", "mod" and "ram" entries;
-- resets : phandle for reset;
-- interrupts : VE interrupt number;
-- allwinner,sram : SRAM region to use with the VE.
-
-Optional properties:
-- memory-region : CMA pool to use for buffers allocation instead of the
- default CMA pool.
-
-Example:
-
-reserved-memory {
- #address-cells = <1>;
- #size-cells = <1>;
- ranges;
-
- /* Address must be kept in the lower 256 MiBs of DRAM for VE. */
- cma_pool: default-pool {
- compatible = "shared-dma-pool";
- size = <0x6000000>;
- alloc-ranges = <0x4a000000 0x6000000>;
- reusable;
- linux,cma-default;
- };
-};
-
-video-codec@1c0e000 {
- compatible = "allwinner,sun7i-a20-video-engine";
- reg = <0x01c0e000 0x1000>;
-
- clocks = <&ccu CLK_AHB_VE>, <&ccu CLK_VE>,
- <&ccu CLK_DRAM_VE>;
- clock-names = "ahb", "mod", "ram";
-
- resets = <&ccu RST_VE>;
- interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
- allwinner,sram = <&ve_sram 1>;
-};
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: media: Convert Allwinner hardware codec to a schema
2019-12-13 7:40 [PATCH] dt-bindings: media: Convert Allwinner hardware codec to a schema Maxime Ripard
@ 2019-12-13 15:25 ` Rob Herring
2019-12-16 9:02 ` Maxime Ripard
2019-12-18 1:56 ` Rob Herring
1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring @ 2019-12-13 15:25 UTC (permalink / raw)
To: Maxime Ripard
Cc: Mark Rutland, Frank Rowand, Chen-Yu Tsai, Maxime Ripard,
devicetree,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Mauro Carvalho Chehab, Linux Media Mailing List
On Fri, Dec 13, 2019 at 1:41 AM Maxime Ripard <maxime@cerno.tech> wrote:
>
> The Allwinner SoCs have a hardware video codec that is supported in Linux,
> with a matching Device Tree binding.
>
> Now that we have the DT validation in place, let's convert the device tree
> bindings for that controller over to a YAML schemas.
>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
> .../allwinner,sun4i-a10-video-engine.yaml | 83 +++++++++++++++++++
> .../devicetree/bindings/media/cedrus.txt | 57 -------------
> 2 files changed, 83 insertions(+), 57 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
> delete mode 100644 Documentation/devicetree/bindings/media/cedrus.txt
>
> diff --git a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
> new file mode 100644
> index 000000000000..47c8513555b2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
> @@ -0,0 +1,83 @@
> +# SPDX-License-Identifier: GPL-2.0+
Do you have rights to change the license (adding '+' aka '-or-later')?
If so, please add BSD-2-Clause. I don't have any other comments, so
just confirm and I can change it when applying.
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: media: Convert Allwinner hardware codec to a schema
2019-12-13 15:25 ` Rob Herring
@ 2019-12-16 9:02 ` Maxime Ripard
0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2019-12-16 9:02 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Rutland, Frank Rowand, Chen-Yu Tsai, devicetree,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Mauro Carvalho Chehab, Linux Media Mailing List
[-- Attachment #1: Type: text/plain, Size: 1554 bytes --]
Hi Rob,
On Fri, Dec 13, 2019 at 09:25:51AM -0600, Rob Herring wrote:
> On Fri, Dec 13, 2019 at 1:41 AM Maxime Ripard <maxime@cerno.tech> wrote:
> >
> > The Allwinner SoCs have a hardware video codec that is supported in Linux,
> > with a matching Device Tree binding.
> >
> > Now that we have the DT validation in place, let's convert the device tree
> > bindings for that controller over to a YAML schemas.
> >
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > ---
> > .../allwinner,sun4i-a10-video-engine.yaml | 83 +++++++++++++++++++
> > .../devicetree/bindings/media/cedrus.txt | 57 -------------
> > 2 files changed, 83 insertions(+), 57 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
> > delete mode 100644 Documentation/devicetree/bindings/media/cedrus.txt
> >
> > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
> > new file mode 100644
> > index 000000000000..47c8513555b2
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
> > @@ -0,0 +1,83 @@
> > +# SPDX-License-Identifier: GPL-2.0+
>
> Do you have rights to change the license (adding '+' aka '-or-later')?
> If so, please add BSD-2-Clause. I don't have any other comments, so
> just confirm and I can change it when applying.
That's a mistake, sorry. I'm not the original author, so I can't
change that license...
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: media: Convert Allwinner hardware codec to a schema
2019-12-13 7:40 [PATCH] dt-bindings: media: Convert Allwinner hardware codec to a schema Maxime Ripard
2019-12-13 15:25 ` Rob Herring
@ 2019-12-18 1:56 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2019-12-18 1:56 UTC (permalink / raw)
To: Maxime Ripard
Cc: Mark Rutland, Frank Rowand, Chen-Yu Tsai, Maxime Ripard,
devicetree, linux-arm-kernel, mchehab, linux-media,
Maxime Ripard
On Fri, 13 Dec 2019 08:40:55 +0100, Maxime Ripard wrote:
> The Allwinner SoCs have a hardware video codec that is supported in Linux,
> with a matching Device Tree binding.
>
> Now that we have the DT validation in place, let's convert the device tree
> bindings for that controller over to a YAML schemas.
>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
> .../allwinner,sun4i-a10-video-engine.yaml | 83 +++++++++++++++++++
> .../devicetree/bindings/media/cedrus.txt | 57 -------------
> 2 files changed, 83 insertions(+), 57 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
> delete mode 100644 Documentation/devicetree/bindings/media/cedrus.txt
>
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-18 1:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-13 7:40 [PATCH] dt-bindings: media: Convert Allwinner hardware codec to a schema Maxime Ripard
2019-12-13 15:25 ` Rob Herring
2019-12-16 9:02 ` Maxime Ripard
2019-12-18 1:56 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).