* [PATCH] media: omap3isp: fix the incorrect check in omap3isp_csiphy_acquire
@ 2019-12-19 7:48 Chuhong Yuan
0 siblings, 0 replies; only message in thread
From: Chuhong Yuan @ 2019-12-19 7:48 UTC (permalink / raw)
Cc: Laurent Pinchart, Mauro Carvalho Chehab, linux-media,
linux-kernel, Chuhong Yuan
The check in omap3isp_csiphy_acquire() does not check for ERR_PTR.
Besides, sometimes vdd can be optional and therefore NULL.
Revise the check to fix this issue.
Fixes: 121e9f1c4c49 ("[media] omap3isp: CCP2/CSI2 receivers")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/media/platform/omap3isp/ispcsiphy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/omap3isp/ispcsiphy.c b/drivers/media/platform/omap3isp/ispcsiphy.c
index 6dc7359c5131..4f46d99a4228 100644
--- a/drivers/media/platform/omap3isp/ispcsiphy.c
+++ b/drivers/media/platform/omap3isp/ispcsiphy.c
@@ -261,10 +261,10 @@ int omap3isp_csiphy_acquire(struct isp_csiphy *phy, struct media_entity *entity)
{
int rval;
- if (phy->vdd == NULL) {
+ if (IS_ERR(phy->vdd)) {
dev_err(phy->isp->dev,
"Power regulator for CSI PHY not available\n");
- return -ENODEV;
+ return PTR_ERR(phy->vdd);
}
mutex_lock(&phy->mutex);
--
2.24.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-12-19 7:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-19 7:48 [PATCH] media: omap3isp: fix the incorrect check in omap3isp_csiphy_acquire Chuhong Yuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).