From: Gerd Hoffmann <kraxel@redhat.com>
To: Dmitry Sepp <dmitry.sepp@opensynergy.com>
Cc: Keiichi Watanabe <keiichiw@chromium.org>,
virtio-dev@lists.oasis-open.org, linux-media@vger.kernel.org,
acourbot@chromium.org, alexlau@chromium.org, daniel@ffwll.ch,
dgreid@chromium.org, egranata@google.com, fziglio@redhat.com,
hverkuil@xs4all.nl, marcheu@chromium.org, posciak@chromium.org,
spice-devel@lists.freedesktop.org, stevensd@chromium.org,
tfiga@chromium.org, uril@redhat.com
Subject: Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification
Date: Thu, 19 Dec 2019 13:54:32 +0100 [thread overview]
Message-ID: <20191219125432.ogb2gdvmly6iuqti@sirius.home.kraxel.org> (raw)
In-Reply-To: <2570078.xtWa8k4VtA@os-lin-dmo>
Hi,
> > I also can't see why the flag is needed in the first place. The driver
> > should know which buffers are queued still and be able to figure
> > whenever the drain is complete or not without depending on that flag.
> > So I'd suggest to simply drop it.
> This flag is used not for drain only. In marks the completion of whatever
> specific buffer sequence, like a full end-of-stream, resolution change, drain
> etc. We also need this to handle nested sequences. For instance, a resolution
> change event might happen while in drain.
Ah, ok. That makes sense (please clarify this in the spec).
cheers,
Gerd
next prev parent reply other threads:[~2019-12-19 12:54 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 13:02 [PATCH v2 0/1] VirtIO video device specification Keiichi Watanabe
2019-12-18 13:02 ` [PATCH v2 1/1] virtio-video: Add virtio " Keiichi Watanabe
2019-12-18 13:40 ` Gerd Hoffmann
2019-12-18 14:08 ` [virtio-dev] " Tomasz Figa
2019-12-19 7:46 ` Gerd Hoffmann
2019-12-19 9:48 ` Dmitry Sepp
2019-12-19 9:59 ` Tomasz Figa
2019-12-19 10:54 ` Dmitry Sepp
2019-12-19 12:05 ` Tomasz Figa
2019-12-19 13:12 ` Gerd Hoffmann
2020-01-08 13:52 ` Keiichi Watanabe
2020-01-09 13:40 ` Gerd Hoffmann
2020-01-09 14:20 ` Tomasz Figa
2020-01-14 7:18 ` Keiichi Watanabe
2020-01-14 10:35 ` Dmitry Sepp
2020-01-15 7:49 ` Keiichi Watanabe
2020-01-15 11:12 ` Tomasz Figa
2019-12-19 13:01 ` Gerd Hoffmann
2020-01-08 13:50 ` Keiichi Watanabe
2019-12-19 9:26 ` Dmitry Sepp
2019-12-19 9:59 ` Tomasz Figa
2019-12-19 12:54 ` Gerd Hoffmann [this message]
2019-12-18 17:29 ` Frediano Ziglio
2019-12-20 14:05 ` Keiichi Watanabe
2019-12-20 15:33 ` Dmitry Sepp
2019-12-19 13:28 ` Dmitry Sepp
2019-12-20 15:26 ` Keiichi Watanabe
[not found] ` <2584386.DF4NACHtsB@os-lin-dmo>
2019-12-21 6:46 ` Tomasz Figa
2019-12-30 12:16 ` [virtio-dev] " Dmitry Sepp
2020-01-06 6:31 ` Tomasz Figa
2020-01-06 8:33 ` Gerd Hoffmann
2020-01-06 9:29 ` Dmitry Sepp
2020-01-03 15:47 ` Dmitry Sepp
2020-01-06 8:47 ` Gerd Hoffmann
2020-01-06 10:21 ` Keiichi Watanabe
2020-01-06 14:59 ` Dmitry Sepp
2020-01-07 13:24 ` Keiichi Watanabe
2020-01-07 16:50 ` Dmitry Sepp
2020-01-08 6:59 ` Keiichi Watanabe
2020-01-08 10:00 ` Dmitry Sepp
2020-01-08 12:14 ` Keiichi Watanabe
2020-01-08 12:46 ` Tomasz Figa
2020-01-08 13:05 ` Keiichi Watanabe
2020-01-08 13:11 ` Dmitry Sepp
2020-01-08 13:23 ` [virtio-dev] " Keiichi Watanabe
2020-01-08 12:23 ` Keiichi Watanabe
2019-12-20 15:58 ` [PATCH v2 0/1] VirtIO " Dmitry Sepp
2019-12-21 4:36 ` Keiichi Watanabe
2019-12-21 6:18 ` Tomasz Figa
2019-12-21 6:19 ` Tomasz Figa
2020-01-03 13:05 ` Dmitry Sepp
2020-01-06 10:30 ` Keiichi Watanabe
2020-01-06 11:28 ` Dmitry Sepp
2020-01-07 10:25 ` Keiichi Watanabe
2020-01-09 14:56 ` Dmitry Sepp
2020-01-10 10:16 ` [virtio-dev] " Dmitry Sepp
2020-01-10 13:53 ` Keiichi Watanabe
2020-01-10 15:11 ` Dmitry Sepp
2020-01-11 16:06 ` Tomasz Figa
2020-01-13 9:50 ` Dmitry Sepp
2020-01-15 11:23 ` Keiichi Watanabe
2020-01-13 9:56 ` Gerd Hoffmann
[not found] ` <12433898.dW097sEU6C@os-lin-dmo>
2020-01-13 11:05 ` Gerd Hoffmann
2020-01-13 11:59 ` Tomasz Figa
2020-01-13 13:26 ` Gerd Hoffmann
2020-01-15 11:00 ` Tomasz Figa
2020-01-15 11:23 ` Keiichi Watanabe
2020-01-15 11:26 ` Gerd Hoffmann
2020-01-20 7:20 ` Keiichi Watanabe
2020-01-20 10:47 ` Gerd Hoffmann
2020-01-21 2:47 ` Keiichi Watanabe
2020-01-21 6:44 ` Gerd Hoffmann
2020-01-21 8:56 ` Keiichi Watanabe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219125432.ogb2gdvmly6iuqti@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=acourbot@chromium.org \
--cc=alexlau@chromium.org \
--cc=daniel@ffwll.ch \
--cc=dgreid@chromium.org \
--cc=dmitry.sepp@opensynergy.com \
--cc=egranata@google.com \
--cc=fziglio@redhat.com \
--cc=hverkuil@xs4all.nl \
--cc=keiichiw@chromium.org \
--cc=linux-media@vger.kernel.org \
--cc=marcheu@chromium.org \
--cc=posciak@chromium.org \
--cc=spice-devel@lists.freedesktop.org \
--cc=stevensd@chromium.org \
--cc=tfiga@chromium.org \
--cc=uril@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).