From: Keiichi Watanabe <keiichiw@chromium.org>
To: Dmitry Sepp <dmitry.sepp@opensynergy.com>
Cc: virtio-dev@lists.oasis-open.org,
"Linux Media Mailing List" <linux-media@vger.kernel.org>,
"Alexandre Courbot" <acourbot@chromium.org>,
"Alex Lau" <alexlau@chromium.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Dylan Reid" <dgreid@chromium.org>,
"Enrico Granata" <egranata@google.com>,
"Frediano Ziglio" <fziglio@redhat.com>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Stéphane Marchesin" <marcheu@chromium.org>,
"Pawel Osciak" <posciak@chromium.org>,
spice-devel@lists.freedesktop.org,
"David Stevens" <stevensd@chromium.org>,
"Tomasz Figa" <tfiga@chromium.org>,
uril@redhat.com
Subject: Re: [PATCH v2 0/1] VirtIO video device specification
Date: Sat, 21 Dec 2019 13:36:40 +0900 [thread overview]
Message-ID: <CAD90Vcb=38fXTbsWy6dH9FuE0xU-GAVAHWMFFtju0txPg+e1FA@mail.gmail.com> (raw)
In-Reply-To: <2730251.jGmEEvB50I@os-lin-dmo>
Hi Dmitry,
On Sat, Dec 21, 2019 at 12:59 AM Dmitry Sepp
<dmitry.sepp@opensynergy.com> wrote:
>
> Hi Keiichi,
>
> On Mittwoch, 18. Dezember 2019 14:02:13 CET Keiichi Watanabe wrote:
> > Hi,
> > This is the 2nd version of virtio-video patch. The PDF is available in [1].
> > The first version was sent at [2].
> >
> > Any feedback would be appreciated. Thank you.
> >
> > Best,
> > Keiichi
> >
> > [1]:
> > https://drive.google.com/drive/folders/1eT5fEckBoor2iHZR4f4GLxYzFMVapOFx?us
> > p=sharing [2]: https://markmail.org/message/gc6h25acct22niut
> >
> > Change log:
> >
> > v2:
> > * Removed functionalities except encoding and decoding.
> > * Splited encoder and decoder into different devices that use the same
> > protocol. * Replaced GET_FUNCS with GET_CAPABILITY.
> > * Updated structs for capabilities.
> > - Defined new structs and enums such as image formats, profiles, range
> > (min, max, step), etc
> > * For virtio_video_pixel_format, chose a naming convention that is used
> > in DRM. We removed XBGR, NV21 and I422, as they are not used in the
> > current draft implementation. https://lwn.net/Articles/806416/
> > - Removed virtio_video_control, whose usage was not documented yet and
> > which is not necessary for the simplest decoding scenario.
> > - Removed virtio_video_desc, as it is no longer needed.
> > * Updated struct virtio_video_config for changes around capabilities.
> > * Added a way to represent supported combinations of formats.
> > - A field "mask" in virtio_video_format_desc plays this role.
> > * Removed VIRTIO_VIDEO_T_STREAM_{START,STOP} because they don't play any
> > meaningful roles. * Removed VIRTIO_VIDEO_T_STREAM_{ATTACH, DETACH}_BACKING
> > and merged them into RESOURCE_{CREATE, DESTROY}. * Added a way to
> > notify/specify resource creation method.
> > - Added a feature flag.
> > - Defined enum virtio_video_mem_type.
> > - Added new fields in video_stream_create.
> > * Modified fields in virtio_video_params.
> > - Added crop information.
> > * Removed enum virtio_video_channel_type because we can get this information
> > by image format.
> Could you please explain this? How do you get the information?
It means that if image formats are well-defined, channel information
(e.g. the order of channels) is uniquely determined.
>
> Suppose you have some piece of HW on the host side that wants I420 as one
> contig buffer w/ some offsets. But on the driver side, say, gralloc gives you
> three separate buffers, one per channel. How do we pass those to the device
> then?
You're talking about CrOS use case where buffers are allocated by
virtio-gpu, right?
In this case, virtio-gpu allocates one contiguous host-side buffer and
the client regards a pair of (buffer FD, offset) as one channel.
And, we can register this pair to the device when the buffer is imported.
In the virtio-vdec spec draft, this pair corresponds to struct
virtio_vdec_plane in struct virtio_vdec_plane.
So, I suppose we will need similar structs when we add a control to
import buffers. However, I don't think it's necessary when guest pages
are used.
Best regards,
Keiichi
>
> Best regards,
> Dmitry.
>
> > * Renamed virtio_video_pin to virtio_video_buf_type.
> > - It's similar to V4L2_BUF_TYPE_VIDEO_{OUTPUT, CAPTURE}.
> > * Added an error event.
> > * Reordered some subsections.
> > * Changed styles to make it consistent with other devices.
> >
> > Dmitry Sepp (1):
> > virtio-video: Add virtio video device specification
> >
> > content.tex | 1 +
> > virtio-video.tex | 579 +++++++++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 580 insertions(+)
> > create mode 100644 virtio-video.tex
> >
> > --
> > 2.24.1.735.g03f4e72817-goog
>
>
next prev parent reply other threads:[~2019-12-21 4:36 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 13:02 [PATCH v2 0/1] VirtIO video device specification Keiichi Watanabe
2019-12-18 13:02 ` [PATCH v2 1/1] virtio-video: Add virtio " Keiichi Watanabe
2019-12-18 13:40 ` Gerd Hoffmann
2019-12-18 14:08 ` [virtio-dev] " Tomasz Figa
2019-12-19 7:46 ` Gerd Hoffmann
2019-12-19 9:48 ` Dmitry Sepp
2019-12-19 9:59 ` Tomasz Figa
2019-12-19 10:54 ` Dmitry Sepp
2019-12-19 12:05 ` Tomasz Figa
2019-12-19 13:12 ` Gerd Hoffmann
2020-01-08 13:52 ` Keiichi Watanabe
2020-01-09 13:40 ` Gerd Hoffmann
2020-01-09 14:20 ` Tomasz Figa
2020-01-14 7:18 ` Keiichi Watanabe
2020-01-14 10:35 ` Dmitry Sepp
2020-01-15 7:49 ` Keiichi Watanabe
2020-01-15 11:12 ` Tomasz Figa
2019-12-19 13:01 ` Gerd Hoffmann
2020-01-08 13:50 ` Keiichi Watanabe
2019-12-19 9:26 ` Dmitry Sepp
2019-12-19 9:59 ` Tomasz Figa
2019-12-19 12:54 ` Gerd Hoffmann
2019-12-18 17:29 ` Frediano Ziglio
2019-12-20 14:05 ` Keiichi Watanabe
2019-12-20 15:33 ` Dmitry Sepp
2019-12-19 13:28 ` Dmitry Sepp
2019-12-20 15:26 ` Keiichi Watanabe
[not found] ` <2584386.DF4NACHtsB@os-lin-dmo>
2019-12-21 6:46 ` Tomasz Figa
2019-12-30 12:16 ` [virtio-dev] " Dmitry Sepp
2020-01-06 6:31 ` Tomasz Figa
2020-01-06 8:33 ` Gerd Hoffmann
2020-01-06 9:29 ` Dmitry Sepp
2020-01-03 15:47 ` Dmitry Sepp
2020-01-06 8:47 ` Gerd Hoffmann
2020-01-06 10:21 ` Keiichi Watanabe
2020-01-06 14:59 ` Dmitry Sepp
2020-01-07 13:24 ` Keiichi Watanabe
2020-01-07 16:50 ` Dmitry Sepp
2020-01-08 6:59 ` Keiichi Watanabe
2020-01-08 10:00 ` Dmitry Sepp
2020-01-08 12:14 ` Keiichi Watanabe
2020-01-08 12:46 ` Tomasz Figa
2020-01-08 13:05 ` Keiichi Watanabe
2020-01-08 13:11 ` Dmitry Sepp
2020-01-08 13:23 ` [virtio-dev] " Keiichi Watanabe
2020-01-08 12:23 ` Keiichi Watanabe
2019-12-20 15:58 ` [PATCH v2 0/1] VirtIO " Dmitry Sepp
2019-12-21 4:36 ` Keiichi Watanabe [this message]
2019-12-21 6:18 ` Tomasz Figa
2019-12-21 6:19 ` Tomasz Figa
2020-01-03 13:05 ` Dmitry Sepp
2020-01-06 10:30 ` Keiichi Watanabe
2020-01-06 11:28 ` Dmitry Sepp
2020-01-07 10:25 ` Keiichi Watanabe
2020-01-09 14:56 ` Dmitry Sepp
2020-01-10 10:16 ` [virtio-dev] " Dmitry Sepp
2020-01-10 13:53 ` Keiichi Watanabe
2020-01-10 15:11 ` Dmitry Sepp
2020-01-11 16:06 ` Tomasz Figa
2020-01-13 9:50 ` Dmitry Sepp
2020-01-15 11:23 ` Keiichi Watanabe
2020-01-13 9:56 ` Gerd Hoffmann
[not found] ` <12433898.dW097sEU6C@os-lin-dmo>
2020-01-13 11:05 ` Gerd Hoffmann
2020-01-13 11:59 ` Tomasz Figa
2020-01-13 13:26 ` Gerd Hoffmann
2020-01-15 11:00 ` Tomasz Figa
2020-01-15 11:23 ` Keiichi Watanabe
2020-01-15 11:26 ` Gerd Hoffmann
2020-01-20 7:20 ` Keiichi Watanabe
2020-01-20 10:47 ` Gerd Hoffmann
2020-01-21 2:47 ` Keiichi Watanabe
2020-01-21 6:44 ` Gerd Hoffmann
2020-01-21 8:56 ` Keiichi Watanabe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD90Vcb=38fXTbsWy6dH9FuE0xU-GAVAHWMFFtju0txPg+e1FA@mail.gmail.com' \
--to=keiichiw@chromium.org \
--cc=acourbot@chromium.org \
--cc=alexlau@chromium.org \
--cc=daniel@ffwll.ch \
--cc=dgreid@chromium.org \
--cc=dmitry.sepp@opensynergy.com \
--cc=egranata@google.com \
--cc=fziglio@redhat.com \
--cc=hverkuil@xs4all.nl \
--cc=kraxel@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=marcheu@chromium.org \
--cc=posciak@chromium.org \
--cc=spice-devel@lists.freedesktop.org \
--cc=stevensd@chromium.org \
--cc=tfiga@chromium.org \
--cc=uril@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).